fix(ci): derive version from Cargo.toml in release artifacts (#804)

* fix(ci): derive version from Cargo.toml in release artifacts

macOS Info.plist CFBundleVersion/CFBundleShortVersionString and
Flatpak metainfo.xml release version were hardcoded to 1.0.0.
Now all derive from Cargo.toml at build time, making it the
single source of truth for version across all release artifacts.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(ci): harden version extraction and fix macOS plist format

- Strip prerelease suffix for CFBundleVersion (Apple requires numeric)
- Add validation: fail fast if version extraction returns empty
- Verify Flatpak metainfo.xml replacement actually applied
- Use git tag date for Flatpak releases, current date for dev builds

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(ci): use cargo metadata instead of grep for version extraction

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(ci): harden plist version validation and use release date for Flatpak

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(ci): use CI run number for CFBundleVersion build number

CFBundleVersion (build number) now uses github.run_number for monotonic
increase across builds. CFBundleShortVersionString (marketing version)
stays as the stripped semver from Cargo.toml. This follows Apple's
recommended pattern and distinguishes dev/rc/release builds.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(ci): harden workflow ordering and quoting

- Move Rust toolchain install before cargo metadata in both macOS jobs
- Add Rust toolchain step to flatpak workflow for cargo metadata
- Quote $GITHUB_OUTPUT consistently
- Verify both version and date in flatpak metainfo check

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: lklimek

.github/workflows/flatpak.yml

@@ -37,6 +37,33 @@ jobs:
       - name: Check out code
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683  # v4.2.2
 
+      - name: Install Rust toolchain (for cargo metadata)
+        uses: dtolnay/rust-toolchain@stable
+
+      - name: Sync metainfo version from Cargo.toml
+        run: |
+          VERSION=$(cargo metadata --format-version=1 --no-deps | jq -r '.packages[] | select(.name == "dash-evo-tool") | .version')
+          if [ -z "$VERSION" ]; then
+            echo "::error::Failed to extract version from Cargo.toml"
+            exit 1
+          fi
+          # Use release published date when available, tag commit date for tag pushes, current date otherwise
+          if [ -n "${{ github.event.release.published_at }}" ]; then
+            DATE=$(echo "${{ github.event.release.published_at }}" | cut -dT -f1)
+          elif [ "${{ github.ref_type }}" = "tag" ]; then
+            DATE=$(git log -1 --format=%cs "${{ github.ref }}")
+          else
+            DATE=$(date +%Y-%m-%d)
+          fi
+          sed -i "s|<release version=\"[^\"]*\" date=\"[^\"]*\"|<release version=\"${VERSION}\" date=\"${DATE}\"|" \
+            flatpak/org.dash.DashEvoTool.metainfo.xml
+          # Verify replacement applied
+          if ! grep -q "version=\"${VERSION}\" date=\"${DATE}\"" flatpak/org.dash.DashEvoTool.metainfo.xml; then
+            echo "::error::Failed to update metainfo.xml with version ${VERSION} and date ${DATE}"
+            exit 1
+          fi
+          echo "Metainfo version set to ${VERSION}, date ${DATE}"
+
       - name: Install Flatpak and Flatpak Builder
         run: |
           sudo apt-get update

.github/workflows/release.yml

@@ -177,6 +177,25 @@ jobs:
       - name: Add Rust target
         run: rustup target add aarch64-apple-darwin
 
+      - name: Extract version from Cargo.toml
+        id: version
+        run: |
+          VERSION=$(cargo metadata --format-version=1 --no-deps | jq -r '.packages[] | select(.name == "dash-evo-tool") | .version')
+          if [ -z "$VERSION" ]; then
+            echo "::error::Failed to extract version from Cargo.toml"
+            exit 1
+          fi
+          # Strip prerelease and build metadata suffixes for macOS plist (Apple requires numeric-only)
+          PLIST_VERSION=$(echo "$VERSION" | sed 's/[-+].*//')
+          if ! echo "$PLIST_VERSION" | grep -Eq '^[0-9]+(\.[0-9]+){0,2}$'; then
+            echo "::error::Invalid plist version '$PLIST_VERSION' derived from Cargo version '$VERSION'. Expected numeric x[.y[.z]]."
+            exit 1
+          fi
+          echo "version=$VERSION" >> "$GITHUB_OUTPUT"
+          echo "plist_version=$PLIST_VERSION" >> "$GITHUB_OUTPUT"
+          echo "build_number=${{ github.run_number }}" >> "$GITHUB_OUTPUT"
+          echo "Extracted version: $VERSION (plist: $PLIST_VERSION, build: ${{ github.run_number }})"
+
       - name: Initial disk cleanup
         run: |
           echo "Disk usage before initial cleanup:"
@@ -270,9 +289,9 @@ jobs:
             <key>CFBundleDisplayName</key>
             <string>Dash Evo Tool</string>
             <key>CFBundleVersion</key>
-            <string>1.0.0</string>
+            <string>${{ steps.version.outputs.build_number }}</string>
             <key>CFBundleShortVersionString</key>
-            <string>1.0.0</string>
+            <string>${{ steps.version.outputs.plist_version }}</string>
             <key>CFBundlePackageType</key>
             <string>APPL</string>
             <key>CFBundleSignature</key>
@@ -474,6 +493,25 @@ jobs:
       - name: Add Rust target
         run: rustup target add x86_64-apple-darwin
 
+      - name: Extract version from Cargo.toml
+        id: version
+        run: |
+          VERSION=$(cargo metadata --format-version=1 --no-deps | jq -r '.packages[] | select(.name == "dash-evo-tool") | .version')
+          if [ -z "$VERSION" ]; then
+            echo "::error::Failed to extract version from Cargo.toml"
+            exit 1
+          fi
+          # Strip prerelease and build metadata suffixes for macOS plist (Apple requires numeric-only)
+          PLIST_VERSION=$(echo "$VERSION" | sed 's/[-+].*//')
+          if ! echo "$PLIST_VERSION" | grep -Eq '^[0-9]+(\.[0-9]+){0,2}$'; then
+            echo "::error::Invalid plist version '$PLIST_VERSION' derived from Cargo version '$VERSION'. Expected numeric x[.y[.z]]."
+            exit 1
+          fi
+          echo "version=$VERSION" >> "$GITHUB_OUTPUT"
+          echo "plist_version=$PLIST_VERSION" >> "$GITHUB_OUTPUT"
+          echo "build_number=${{ github.run_number }}" >> "$GITHUB_OUTPUT"
+          echo "Extracted version: $VERSION (plist: $PLIST_VERSION, build: ${{ github.run_number }})"
+
       - name: Initial disk cleanup
         run: |
           echo "Disk usage before initial cleanup:"
@@ -563,9 +601,9 @@ jobs:
             <key>CFBundleDisplayName</key>
             <string>Dash Evo Tool</string>
             <key>CFBundleVersion</key>
-            <string>1.0.0</string>
+            <string>${{ steps.version.outputs.build_number }}</string>
             <key>CFBundleShortVersionString</key>
-            <string>1.0.0</string>
+            <string>${{ steps.version.outputs.plist_version }}</string>
             <key>CFBundlePackageType</key>
             <string>APPL</string>
             <key>CFBundleSignature</key>

flatpak/org.dash.DashEvoTool.metainfo.xml

@@ -43,6 +43,7 @@
     <name>Dash Core Group</name>
   </developer>
 
+  <!-- Version and date are auto-synced from Cargo.toml by CI (flatpak.yml) -->
   <releases>
     <release version="1.0.0-dev" date="2026-02-17" type="development" />
   </releases>