chore(ui): remove the superseded standalone identities screen (#971)

The Identity Hub covers everything the standalone identities list did, and
the nav has not offered a way to reach that list for some time. Four live
controls still routed to it, though, and `set_main_screen` persists the
choice — so finishing a wallet import and choosing "Create Identity" parked
the user on a screen with nothing highlighted in the nav, there and on every
later launch. Those controls now point at the hub, and the screen is gone.

Rerouted to `RootScreenIdentityHub`: "Create Platform Identity" after wallet
creation, "Create Identity" / "Load Existing Identity" on the import success
screen, "Register DPNS Name" on the add-identity success screen, and the
Register-DPNS breadcrumb. The seven `add_left_panel` arguments that named the
retired route highlighted nothing; they now name the hub, matching what
`keys_screen` already did.

Encoding 0 is retired and decodes to `None`, so a returning user's persisted
value falls through to the settings default. That default was DashPay, which
is itself absent from the nav — it becomes the hub, matching
`app::FALLBACK_ROOT_SCREEN`, under a regression test.

`OnboardingAction::ImportIdentity` is dropped: it is absent from
`ONBOARDING_CARDS` and constructed nowhere.

The `nav_button_specs` doc claimed the retired routes stayed reachable via
deep links and MCP tools. Neither exists: there is no URI handler anywhere,
and `src/mcp/` and `src/bin/` reference no UI screen type.

The deleted kittest file's three app-shell tests move to `startup.rs`; a
fourth duplicated `startup::test_app_startup`. Its two Keys-popup regressions
are already covered on the live path by `keys_screen.rs` and at model level
in `encrypted_key_storage.rs`.

Co-authored-by: Lukasz Klimek <842586+lklimek@users.noreply.github.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Author: 3 people

docs/user-stories.md

@@ -814,7 +814,7 @@ As a masternode operator, I want my previously scheduled DPNS votes to survive a
 
 As a user who has requested a username that is not yet awarded, I want to see that the request is pending so that I am not told to "pick a username" for a name I have already chosen.
 
-- A requested-but-unawarded name shows a "Pending" pill next to the identity — on both the Identities list and the Identity Home hero card.
+- A requested-but-unawarded name shows a "Pending" pill next to the identity — on both the Identity Home hero card and the Identity Settings tab.
 - The hero card shows the requested name with the pill instead of the "No username yet — Pick a username" prompt.
 - The onboarding checklist counts the submitted request as completing "Pick a username" while clearly stating that Dash masternodes are voting.
 - The pill's tooltip explains that Dash masternodes decide who receives the username and, when the decision time is known, gives an estimated decision time.

src/app.rs

@@ -25,7 +25,6 @@ use crate::ui::components::{BannerHandle, MessageBanner, OptionBannerExt, Progre
 use crate::ui::contracts_documents::contracts_documents_screen::DocumentQueryScreen;
 use crate::ui::dashpay::{DashPayScreen, DashPaySubscreen, ProfileSearchScreen};
 use crate::ui::dpns::dpns_contested_names_screen::{DPNSScreen, DPNSSubscreen};
-use crate::ui::identities::identities_screen::IdentitiesScreen;
 use crate::ui::identity::identity_pill::shorten_id;
 use crate::ui::network_chooser_screen::{NetworkChooserScreen, chooser_network_label};
 use crate::ui::theme::ThemeMode;
@@ -1504,7 +1503,6 @@ impl AppState {
 
         // All screens are initialized with the active context (chosen_network).
         // They will get the right context via change_context() on network switch.
-        let identities_screen = IdentitiesScreen::new(&active_context);
         let dpns_active_contests_screen = DPNSScreen::new(&active_context, DPNSSubscreen::Active);
         let dpns_past_contests_screen = DPNSScreen::new(&active_context, DPNSSubscreen::Past);
         let dpns_my_usernames_screen = DPNSScreen::new(&active_context, DPNSSubscreen::Owned);
@@ -1613,10 +1611,6 @@ impl AppState {
         };
 
         let main_screens: BTreeMap<RootScreenType, Screen> = [
-            (
-                RootScreenType::RootScreenIdentities,
-                Screen::IdentitiesScreen(identities_screen),
-            ),
             (
                 RootScreenType::RootScreenDPNSActiveContests,
                 Screen::DPNSScreen(dpns_active_contests_screen),

src/model/settings.rs

@@ -39,7 +39,6 @@ pub enum ThemeMode {
 #[derive(Debug, Clone, Copy, Ord, PartialOrd, Eq, PartialEq, Hash)]
 #[allow(clippy::enum_variant_names)]
 pub enum RootScreenType {
-    RootScreenIdentities,
     RootScreenDPNSActiveContests,
     RootScreenDPNSPastContests,
     RootScreenDPNSOwnedNames,
@@ -62,10 +61,10 @@ pub enum RootScreenType {
     RootScreenToolsGroveSTARKScreen,
     RootScreenToolsAddressBalanceScreen,
     RootScreenDashpay,
-    /// New unified Identities hub (Home · Contacts · Activity · Settings).
-    /// Coexists with `RootScreenIdentities` and the DashPay entries while the legacy
-    /// screens are still wired. Distinct variant so user selection, persistence, and
-    /// left-nav highlighting stay independent.
+    /// The unified Identities hub (Home · Contacts · Activity · Settings), and
+    /// the single user-facing `Identities` nav entry. Distinct variant so user
+    /// selection, persistence, and left-nav highlighting stay independent of the
+    /// DashPay entries it coexists with.
     RootScreenIdentityHub,
     /// Masternodes section (Expert-Mode gated). Node-operator surface for
     /// loading masternode/evonode identities, DPNS-contest voting, and
@@ -78,7 +77,7 @@ impl RootScreenType {
     /// Convert `RootScreenType` to an integer
     pub fn to_int(self) -> u32 {
         match self {
-            RootScreenType::RootScreenIdentities => 0,
+            // 0 used to be the standalone Identities screen
             RootScreenType::RootScreenDPNSActiveContests => 1,
             RootScreenType::RootScreenDPNSPastContests => 2,
             RootScreenType::RootScreenDPNSOwnedNames => 3,
@@ -113,7 +112,7 @@ impl RootScreenType {
     /// Convert an integer to a `RootScreenType`
     pub fn from_int(value: u32) -> Option<Self> {
         match value {
-            0 => Some(RootScreenType::RootScreenIdentities),
+            // 0 used to be the standalone Identities screen
             1 => Some(RootScreenType::RootScreenDPNSActiveContests),
             2 => Some(RootScreenType::RootScreenDPNSPastContests),
             3 => Some(RootScreenType::RootScreenDPNSOwnedNames),
@@ -180,6 +179,19 @@ mod root_screen_type_tests {
     fn from_int_returns_none_for_unknown_value() {
         assert!(RootScreenType::from_int(9999).is_none());
     }
+
+    /// Encoding 0 belonged to the standalone Identities screen, so it decodes
+    /// to `None` and the settings default decides where those users land. That
+    /// default must be the Identities hub: any other destination drops someone
+    /// who was last on an identities screen onto an unrelated section.
+    #[test]
+    fn the_retired_identities_encoding_falls_back_to_the_hub() {
+        assert!(RootScreenType::from_int(0).is_none());
+        assert_eq!(
+            super::AppSettings::default().root_screen_type,
+            RootScreenType::RootScreenIdentityHub
+        );
+    }
 }
 
 /// Application-level user preferences.
@@ -237,7 +249,9 @@ impl Default for AppSettings {
     fn default() -> Self {
         Self {
             network: Network::Mainnet,
-            root_screen_type: RootScreenType::RootScreenDashpay,
+            // Matches `app::FALLBACK_ROOT_SCREEN`: the one nav entry every
+            // install has, and where an undecodable persisted value lands.
+            root_screen_type: RootScreenType::RootScreenIdentityHub,
             dash_qt_path: detect_dash_qt_path(),
             overwrite_dash_conf: true,
             disable_zmq: false,
@@ -486,7 +500,7 @@ mod tests {
     fn settings_round_trip_through_wire() {
         let s = AppSettings {
             network: Network::Testnet,
-            root_screen_type: RootScreenType::RootScreenIdentities,
+            root_screen_type: RootScreenType::RootScreenIdentityHub,
             dash_qt_path: Some(PathBuf::from("/tmp/dash-qt")),
             overwrite_dash_conf: false,
             disable_zmq: true,

src/ui/components/left_panel.rs

@@ -16,11 +16,9 @@ use std::sync::Arc;
 /// optional feature gate)`. Entries whose feature gate evaluates to false are
 /// filtered out at render time.
 ///
-/// The former standalone `Identities` ([`RootScreenType::RootScreenIdentities`])
-/// and `Dashpay` ([`RootScreenType::RootScreenDashPayProfile`]) entries are
-/// intentionally hidden from the nav; their screens, routes, and backend paths
-/// stay intact and remain reachable through other means (deep links, MCP tools,
-/// direct screen construction). The Identities hub
+/// `Dashpay` ([`RootScreenType::RootScreenDashPayProfile`]) is intentionally
+/// absent: its screens and backend paths stay wired, reached from the Identity
+/// Hub rather than from the nav. The hub
 /// ([`RootScreenType::RootScreenIdentityHub`]) is the single user-facing
 /// `Identities` entry.
 fn nav_button_specs() -> &'static [(
@@ -370,18 +368,12 @@ pub fn add_left_panel(
 mod tests {
     use super::*;
 
-    /// The nav sidebar hides the legacy standalone `Identities` and `Dashpay`
-    /// entries and surfaces the Identity Hub as the single `Identities` entry.
+    /// The nav sidebar hides the `Dashpay` entry and surfaces the Identity Hub
+    /// as the single `Identities` entry.
     #[test]
-    fn nav_hides_legacy_identities_and_dashpay_and_labels_hub_as_identities() {
+    fn nav_hides_dashpay_and_labels_hub_as_identities() {
         let specs = nav_button_specs();
 
-        assert!(
-            !specs
-                .iter()
-                .any(|(_, screen, _, _)| *screen == RootScreenType::RootScreenIdentities),
-            "the legacy standalone Identities entry must be hidden from the nav"
-        );
         assert!(
             !specs
                 .iter()

src/ui/identities/add_existing_identity_screen.rs

@@ -1033,7 +1033,7 @@ impl ScreenLike for AddExistingIdentityScreen {
         action |= add_left_panel(
             ui,
             &self.app_context,
-            crate::ui::RootScreenType::RootScreenIdentities,
+            crate::ui::RootScreenType::RootScreenIdentityHub,
         );
 
         action |= island_central_panel(ui, |ui| {

src/ui/identities/add_new_identity_screen/mod.rs

@@ -1609,7 +1609,7 @@ impl ScreenLike for AddNewIdentityScreen {
         action |= add_left_panel(
             ui,
             &self.app_context,
-            crate::ui::RootScreenType::RootScreenIdentities,
+            crate::ui::RootScreenType::RootScreenIdentityHub,
         );
 
         let mut request_asset_lock_balance = false;

src/ui/identities/add_new_identity_screen/success_screen.rs

@@ -36,7 +36,7 @@ impl AddNewIdentityScreen {
                 screen.show_identity_selector = false;
             }
             return AppAction::PopThenAddScreenToMainScreen(
-                RootScreenType::RootScreenIdentities,
+                RootScreenType::RootScreenIdentityHub,
                 Screen::RegisterDpnsNameScreen(screen),
             );
         }