refactor: replace WalletSeedHash with WalletId across entire codebase

Commit 3 of the seed_hash → wallet_id refactor.

Bulk-renames the type alias WalletSeedHash to WalletId across 38
files. Since both resolve to [u8; 32], this is a pure naming change
with no semantic impact. Every import, type annotation, function
parameter, and struct field that previously used WalletSeedHash now
uses WalletId directly (re-exported from platform_wallet_bridge).

The legacy WalletSeedHash alias is kept in model/wallet/mod.rs for
ClosedKeyItem.seed_hash (which genuinely is the SHA256 of the seed,
used for encryption) and WalletIdMapping (the bridge between old and
new key schemes).

WalletIdMapping itself now has both sides typed as WalletId — they
are the same underlying [u8; 32] type but carry different semantic
values (seed_hash bytes vs wallet_id bytes). The struct stays until
commit 5+ when AppContext.wallets is re-keyed and the mapping is
deleted.

38 files changed, all tests pass.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: shumkov

Cargo.lock

@@ -12,7 +12,7 @@ use crate::model::qualified_identity::qualified_identity_public_key::QualifiedId
 use crate::model::qualified_identity::{
     DPNSNameInfo, IdentityStatus, IdentityType, QualifiedIdentity,
 };
-use crate::model::wallet::{Wallet, WalletSeedHash};
+use crate::model::wallet::{Wallet, WalletId};
 use crate::ui::identities::add_new_identity_screen::MAX_IDENTITY_INDEX;
 use dash_sdk::Sdk;
 use dash_sdk::dashcore_rpc::dashcore::PrivateKey;
@@ -32,7 +32,7 @@ use std::convert::TryInto;
 use std::sync::{Arc, RwLock};
 
 type WalletKeyMap = BTreeMap<(PrivateKeyTarget, u32), (QualifiedIdentityPublicKey, PrivateKeyData)>;
-type WalletMatchResult = Option<(WalletSeedHash, u32, WalletKeyMap)>;
+type WalletMatchResult = Option<(WalletId, u32, WalletKeyMap)>;
 
 impl AppContext {
     pub(super) async fn load_identity(
@@ -219,7 +219,7 @@ impl AppContext {
             None
         };
 
-        // let mut wallet_seed_hash: Option<(WalletSeedHash, u32)> = None;
+        // let mut wallet_seed_hash: Option<(WalletId, u32)> = None;
 
         if identity_type == IdentityType::User {
             let input_private_keys = keys_input
@@ -371,8 +371,8 @@ impl AppContext {
     pub(super) fn match_user_identity_keys_with_wallet(
         &self,
         identity: &Identity,
-        wallets: &BTreeMap<WalletSeedHash, Arc<RwLock<Wallet>>>,
-        wallet_filter: Option<WalletSeedHash>,
+        wallets: &BTreeMap<WalletId, Arc<RwLock<Wallet>>>,
+        wallet_filter: Option<WalletId>,
     ) -> Result<WalletMatchResult, TaskError> {
         let highest_identity_key_id = identity.public_keys().keys().copied().max().unwrap_or(0);
         let top_bound = highest_identity_key_id.saturating_add(6).max(1);
@@ -413,7 +413,7 @@ impl AppContext {
         &self,
         identity: &Identity,
         wallet: &mut Wallet,
-        wallet_seed_hash: WalletSeedHash,
+        wallet_seed_hash: WalletId,
         top_bound: u32,
     ) -> Result<Option<(u32, WalletKeyMap)>, TaskError> {
         for candidate_index in 0..MAX_IDENTITY_INDEX {
@@ -495,7 +495,7 @@ impl AppContext {
     fn build_wallet_private_key_map(
         &self,
         identity: &Identity,
-        wallet_seed_hash: WalletSeedHash,
+        wallet_seed_hash: WalletId,
         identity_index: u32,
         public_key_map: &BTreeMap<Vec<u8>, u32>,
         public_key_hash_map: &BTreeMap<[u8; 20], u32>,

src/backend_task/identity/load_identity.rs

@@ -4,7 +4,7 @@ use crate::context::AppContext;
 use crate::model::qualified_identity::{
     DPNSNameInfo, IdentityStatus, IdentityType, QualifiedIdentity,
 };
-use crate::model::wallet::WalletSeedHash;
+use crate::model::wallet::WalletId;
 use dash_sdk::Sdk;
 use dash_sdk::platform::{Fetch, Identity};
 
@@ -19,7 +19,7 @@ impl AppContext {
         &self,
         sdk: &Sdk,
         dpns_name: String,
-        selected_wallet_seed_hash: Option<WalletSeedHash>,
+        selected_wallet_seed_hash: Option<WalletId>,
     ) -> Result<BackendTaskSuccessResult, TaskError> {
         // Step 1: Resolve the DPNS name to an identity ID using the SDK.
         //

src/backend_task/identity/load_identity_by_dpns_name.rs

@@ -18,7 +18,7 @@ use crate::model::qualified_identity::encrypted_key_storage::{KeyStorage, Wallet
 use crate::model::qualified_identity::qualified_identity_public_key::QualifiedIdentityPublicKey;
 use crate::model::qualified_identity::{IdentityType, PrivateKeyTarget, QualifiedIdentity};
 use crate::model::secret::Secret;
-use crate::model::wallet::{Wallet, WalletArcRef, WalletSeedHash};
+use crate::model::wallet::{Wallet, WalletArcRef, WalletId};
 use dash_sdk::Sdk;
 use dash_sdk::dashcore_rpc::dashcore::key::Secp256k1;
 use dash_sdk::dashcore_rpc::dashcore::{Address, PrivateKey};
@@ -48,7 +48,7 @@ pub struct IdentityInputToLoad {
     pub payout_address_private_key_input: Secret,
     pub keys_input: Vec<Secret>,
     pub derive_keys_from_wallets: bool,
-    pub selected_wallet_seed_hash: Option<WalletSeedHash>,
+    pub selected_wallet_seed_hash: Option<WalletId>,
 }
 
 /// A key input tuple containing the private key with derivation path, key type, purpose,
@@ -81,7 +81,7 @@ impl IdentityKeys {
         }
     }
 
-    pub fn to_key_storage(&self, wallet_seed_hash: WalletSeedHash) -> KeyStorage {
+    pub fn to_key_storage(&self, wallet_seed_hash: WalletId) -> KeyStorage {
         let Self {
             master_private_key,
             master_private_key_type,
@@ -295,7 +295,7 @@ pub enum RegisterIdentityFundingMethod {
         /// Platform addresses and credits to use
         inputs: BTreeMap<dash_sdk::dpp::address_funds::PlatformAddress, Credits>,
         /// Wallet seed hash for signing
-        wallet_seed_hash: WalletSeedHash,
+        wallet_seed_hash: WalletId,
     },
 }
 
@@ -350,7 +350,7 @@ pub enum IdentityTask {
     SearchIdentitiesUpToIndex(WalletArcRef, IdentityIndex),
     /// Search for an identity by its DPNS name (without .dash suffix)
     /// Second parameter is optional wallet seed hash for key derivation
-    SearchIdentityByDpnsName(String, Option<WalletSeedHash>),
+    SearchIdentityByDpnsName(String, Option<WalletId>),
     RegisterIdentity(IdentityRegistrationInfo),
     TopUpIdentity(IdentityTopUpInfo),
     /// Top up an identity from Platform addresses
@@ -359,7 +359,7 @@ pub enum IdentityTask {
         /// Platform addresses and amounts to use for top-up
         inputs: BTreeMap<dash_sdk::dpp::address_funds::PlatformAddress, Credits>,
         /// Wallet seed hash for signing
-        wallet_seed_hash: WalletSeedHash,
+        wallet_seed_hash: WalletId,
     },
     AddKeyToIdentity(QualifiedIdentity, QualifiedIdentityPublicKey, [u8; 32]),
     WithdrawFromIdentity(QualifiedIdentity, Option<Address>, Credits, Option<KeyID>),
@@ -760,7 +760,7 @@ impl AppContext {
         sdk: &Sdk,
         qualified_identity: QualifiedIdentity,
         inputs: BTreeMap<dash_sdk::dpp::address_funds::PlatformAddress, Credits>,
-        wallet_seed_hash: WalletSeedHash,
+        wallet_seed_hash: WalletId,
     ) -> Result<BackendTaskSuccessResult, TaskError> {
         use crate::model::fee_estimation::PlatformFeeEstimator;
         use dash_sdk::platform::transition::top_up_identity_from_addresses::TopUpIdentityFromAddresses;
@@ -850,7 +850,7 @@ impl AppContext {
         // Update destination address balances in any wallets that contain them
         // (using proof-verified data from the SDK response).
         {
-            let seed_hashes: Vec<WalletSeedHash> = self
+            let seed_hashes: Vec<WalletId> = self
                 .wallets
                 .read()
                 .map(|w| w.keys().copied().collect())

src/backend_task/identity/mod.rs

@@ -351,7 +351,7 @@ impl AppContext {
             dash_sdk::dpp::address_funds::PlatformAddress,
             (AddressNonce, dash_sdk::dpp::fee::Credits),
         >,
-        wallet_seed_hash: super::WalletSeedHash,
+        wallet_seed_hash: super::WalletId,
     ) -> Result<BackendTaskSuccessResult, TaskError> {
         use dash_sdk::platform::transition::put_identity::PutIdentity;
 

src/backend_task/identity/register_identity.rs

@@ -18,7 +18,7 @@ use dash_sdk::dpp::dashcore::bls_sig_utils::BLSSignature;
 use dash_sdk::dpp::dashcore::network::message_qrinfo::QRInfo;
 use dash_sdk::dpp::dashcore::BlockHash;
 use crate::model::qualified_identity::QualifiedIdentity;
-use crate::model::wallet::WalletSeedHash;
+use crate::model::wallet::WalletId;
 use crate::model::grovestark_prover::ProofDataOutput;
 use crate::ui::tokens::tokens_screen::{
     ContractDescriptionInfo, IdentityTokenIdentifier, TokenInfo,
@@ -214,28 +214,28 @@ pub enum BackendTaskSuccessResult {
     GeneratedZKProof(ProofDataOutput),
     VerifiedZKProof(bool, ProofDataOutput),
     GeneratedReceiveAddress {
-        seed_hash: WalletSeedHash,
+        seed_hash: WalletId,
         address: String,
     },
     /// Per-address info loaded from the CoreWallet bridge
     AddressInfo(Vec<crate::platform_wallet_bridge::CoreAddressInfo>),
     /// Platform address balances fetched from Platform
     PlatformAddressBalances {
-        seed_hash: WalletSeedHash,
+        seed_hash: WalletId,
         /// Map of address to (balance, nonce)
         balances: BTreeMap<Address<NetworkChecked>, (u64, u32)>,
     },
     /// Platform credits transferred between addresses
     PlatformCreditsTransferred {
-        seed_hash: WalletSeedHash,
+        seed_hash: WalletId,
     },
     /// Platform address funded from asset lock
     PlatformAddressFunded {
-        seed_hash: WalletSeedHash,
+        seed_hash: WalletId,
     },
     /// Withdrawal from Platform address to Core initiated
     PlatformAddressWithdrawal {
-        seed_hash: WalletSeedHash,
+        seed_hash: WalletId,
     },
 
     // MNList-specific results
@@ -326,36 +326,36 @@ pub enum BackendTaskSuccessResult {
 
     // Shielded pool results
     ShieldedInitialized {
-        seed_hash: WalletSeedHash,
+        seed_hash: WalletId,
         balance: u64,
     },
     ShieldedNotesSynced {
-        seed_hash: WalletSeedHash,
+        seed_hash: WalletId,
         new_notes: u32,
         balance: u64,
     },
     ShieldedCreditsShielded {
-        seed_hash: WalletSeedHash,
+        seed_hash: WalletId,
         amount: u64,
     },
     ShieldedTransferComplete {
-        seed_hash: WalletSeedHash,
+        seed_hash: WalletId,
         amount: u64,
     },
     ShieldedCreditsUnshielded {
-        seed_hash: WalletSeedHash,
+        seed_hash: WalletId,
         amount: u64,
     },
     ShieldedNullifiersChecked {
-        seed_hash: WalletSeedHash,
+        seed_hash: WalletId,
         spent_count: u32,
     },
     ShieldedFromAssetLock {
-        seed_hash: WalletSeedHash,
+        seed_hash: WalletId,
         amount: u64,
     },
     ShieldedWithdrawalComplete {
-        seed_hash: WalletSeedHash,
+        seed_hash: WalletId,
         amount: u64,
     },
     ProvingKeyReady,

src/backend_task/mod.rs

@@ -2,7 +2,7 @@ use crate::backend_task::error::{TaskError, shielded_broadcast_error, shielded_b
 use crate::context::AppContext;
 use crate::context::shielded::get_proving_key;
 use crate::model::fee_estimation::{format_credits_as_dash, shielded_fee_for_actions};
-use crate::model::wallet::WalletSeedHash;
+use crate::model::wallet::WalletId;
 use crate::model::wallet::shielded::{ShieldedNote, ShieldedWalletState};
 use dash_sdk::dpp::address_funds::{
     AddressFundsFeeStrategy, AddressFundsFeeStrategyStep, OrchardAddress, PlatformAddress,
@@ -87,7 +87,7 @@ impl ShieldStage {
 /// Returns the built `StateTransition` so the caller can broadcast in nonce order.
 pub fn build_shield_credit(
     app_context: &Arc<AppContext>,
-    seed_hash: &WalletSeedHash,
+    seed_hash: &WalletId,
     recipient_payment_address: &PaymentAddress,
     amount: u64,
     from_address: PlatformAddress,
@@ -140,7 +140,7 @@ pub fn build_shield_credit(
 /// (including Halo 2 proof generation and RedPallas signature application).
 pub async fn shield_credits(
     app_context: &Arc<AppContext>,
-    seed_hash: &WalletSeedHash,
+    seed_hash: &WalletId,
     recipient_payment_address: &PaymentAddress,
     amount: u64,
     from_address: PlatformAddress,
@@ -246,7 +246,7 @@ pub async fn shield_credits(
 /// Returns the nullifiers of the notes that were spent.
 pub async fn shielded_transfer(
     app_context: &Arc<AppContext>,
-    _seed_hash: &WalletSeedHash,
+    _seed_hash: &WalletId,
     shielded_state: &ShieldedWalletState,
     amount: u64,
     recipient_address_bytes: &[u8],
@@ -338,7 +338,7 @@ pub async fn shielded_transfer(
 /// Returns the nullifiers of the notes that were spent.
 pub async fn unshield_credits(
     app_context: &Arc<AppContext>,
-    _seed_hash: &WalletSeedHash,
+    _seed_hash: &WalletId,
     shielded_state: &ShieldedWalletState,
     amount: u64,
     to_platform_address: PlatformAddress,
@@ -427,7 +427,7 @@ pub async fn unshield_credits(
 /// shielded pool.
 pub async fn shield_from_asset_lock(
     app_context: &Arc<AppContext>,
-    seed_hash: &WalletSeedHash,
+    seed_hash: &WalletId,
     shielded_state: &ShieldedWalletState,
     amount_duffs: u64,
     source_address: Option<&Address>,
@@ -558,7 +558,7 @@ pub async fn shield_from_asset_lock(
 /// Returns the nullifiers of the notes that were spent.
 pub async fn shielded_withdrawal(
     app_context: &Arc<AppContext>,
-    _seed_hash: &WalletSeedHash,
+    _seed_hash: &WalletId,
     shielded_state: &ShieldedWalletState,
     amount: u64,
     to_core_address: Address,