fix(ci): harden version extraction and fix macOS plist format

- Strip prerelease suffix for CFBundleVersion (Apple requires numeric)
- Add validation: fail fast if version extraction returns empty
- Verify Flatpak metainfo.xml replacement actually applied
- Use git tag date for Flatpak releases, current date for dev builds

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: lklimek

.github/workflows/flatpak.yml

@@ -40,9 +40,23 @@ jobs:
       - name: Sync metainfo version from Cargo.toml
         run: |
           VERSION=$(grep '^version = ' Cargo.toml | head -1 | sed 's/version = "\(.*\)"/\1/')
-          DATE=$(date +%Y-%m-%d)
+          if [ -z "$VERSION" ]; then
+            echo "::error::Failed to extract version from Cargo.toml"
+            exit 1
+          fi
+          # Use tag date for releases, current date for manual/PR builds
+          if [ "${{ github.ref_type }}" = "tag" ]; then
+            DATE=$(git log -1 --format=%cs "${{ github.ref }}")
+          else
+            DATE=$(date +%Y-%m-%d)
+          fi
           sed -i "s|<release version=\"[^\"]*\" date=\"[^\"]*\"|<release version=\"${VERSION}\" date=\"${DATE}\"|" \
             flatpak/org.dash.DashEvoTool.metainfo.xml
+          # Verify replacement applied
+          if ! grep -q "version=\"${VERSION}\"" flatpak/org.dash.DashEvoTool.metainfo.xml; then
+            echo "::error::Failed to update metainfo.xml with version ${VERSION}"
+            exit 1
+          fi
           echo "Metainfo version set to ${VERSION}, date ${DATE}"
 
       - name: Install Flatpak and Flatpak Builder

.github/workflows/release.yml

@@ -175,7 +175,15 @@ jobs:
         id: version
         run: |
           VERSION=$(grep '^version = ' Cargo.toml | head -1 | sed 's/version = "\(.*\)"/\1/')
+          if [ -z "$VERSION" ]; then
+            echo "::error::Failed to extract version from Cargo.toml"
+            exit 1
+          fi
+          # Strip prerelease suffix for macOS plist (Apple requires numeric-only)
+          PLIST_VERSION=$(echo "$VERSION" | sed 's/-.*//')
           echo "version=$VERSION" >> $GITHUB_OUTPUT
+          echo "plist_version=$PLIST_VERSION" >> $GITHUB_OUTPUT
+          echo "Extracted version: $VERSION (plist: $PLIST_VERSION)"
 
       - name: Install Rust toolchain
         uses: dtolnay/rust-toolchain@stable
@@ -276,9 +284,9 @@ jobs:
             <key>CFBundleDisplayName</key>
             <string>Dash Evo Tool</string>
             <key>CFBundleVersion</key>
-            <string>${{ steps.version.outputs.version }}</string>
+            <string>${{ steps.version.outputs.plist_version }}</string>
             <key>CFBundleShortVersionString</key>
-            <string>${{ steps.version.outputs.version }}</string>
+            <string>${{ steps.version.outputs.plist_version }}</string>
             <key>CFBundlePackageType</key>
             <string>APPL</string>
             <key>CFBundleSignature</key>
@@ -478,7 +486,15 @@ jobs:
         id: version
         run: |
           VERSION=$(grep '^version = ' Cargo.toml | head -1 | sed 's/version = "\(.*\)"/\1/')
+          if [ -z "$VERSION" ]; then
+            echo "::error::Failed to extract version from Cargo.toml"
+            exit 1
+          fi
+          # Strip prerelease suffix for macOS plist (Apple requires numeric-only)
+          PLIST_VERSION=$(echo "$VERSION" | sed 's/-.*//')
           echo "version=$VERSION" >> $GITHUB_OUTPUT
+          echo "plist_version=$PLIST_VERSION" >> $GITHUB_OUTPUT
+          echo "Extracted version: $VERSION (plist: $PLIST_VERSION)"
 
       - name: Install Rust toolchain
         uses: dtolnay/rust-toolchain@stable
@@ -575,9 +591,9 @@ jobs:
             <key>CFBundleDisplayName</key>
             <string>Dash Evo Tool</string>
             <key>CFBundleVersion</key>
-            <string>${{ steps.version.outputs.version }}</string>
+            <string>${{ steps.version.outputs.plist_version }}</string>
             <key>CFBundleShortVersionString</key>
-            <string>${{ steps.version.outputs.version }}</string>
+            <string>${{ steps.version.outputs.plist_version }}</string>
             <key>CFBundlePackageType</key>
             <string>APPL</string>
             <key>CFBundleSignature</key>