refactor: switch not-simulated flags to ulong and make models init-only

Author: danilrudin

Consyzer/Core/Models/LibraryResolutionResult.cs

@@ -17,7 +17,7 @@ internal sealed class LibraryResolutionResult
     public required IReadOnlyList<string> HeuristicCandidates { get; init; }
 
     /// <summary>
-    /// Flags indicating which loader mechanisms are NOT simulated in current strict version.
+    /// Flags indicating which loader mechanisms are NOT simulated.
     /// Used to justify Inconclusive.
     /// </summary>
     public required NotSimulatedMechanisms NotSimulated { get; init; }
@@ -35,7 +35,6 @@ internal sealed record ResolvedPresence(
     MechanismKind MechanismKind
 );
 
-
 /// <summary>
 /// Loader mechanism category for reporting only.
 /// </summary>
@@ -49,39 +48,37 @@ internal enum MechanismKind
 }
 
 [Flags]
-internal enum NotSimulatedMechanisms
+internal enum NotSimulatedMechanisms : ulong
 {
     None = 0,
 
     // Windows (bit range 0..9)
-    WindowsSxS = 1 << 0,
-    WindowsKnownDlls = 1 << 1,
-    WindowsDllRedirection = 1 << 2,
-    WindowsProcessDirectoryOverrides = 1 << 3,
-    WindowsApiSetSchema = 1 << 4,
-    WindowsPackageGraph = 1 << 5,
-    WindowsLoadedModuleList = 1 << 6,
-    WindowsSafeSearchModeAndFlags = 1 << 7,
-
-    WindowsAppPathsRegistry = 1 << 8,
-    WindowsDotNetSearchPathOverrides = 1 << 9,
+    WindowsSxS = 1UL << 0,
+    WindowsKnownDlls = 1UL << 1,
+    WindowsDllRedirection = 1UL << 2,
+    WindowsProcessDirectoryOverrides = 1UL << 3,
+    WindowsApiSetSchema = 1UL << 4,
+    WindowsPackageGraph = 1UL << 5,
+    WindowsLoadedModuleList = 1UL << 6,
+    WindowsSafeSearchModeAndFlags = 1UL << 7,
+    WindowsAppPathsRegistry = 1UL << 8,
+    WindowsDotNetSearchPathOverrides = 1UL << 9,
 
     // Linux (bit range 10..16)
-    LinuxRPathRunPath = 1 << 10,
-    LinuxLdSoCache = 1 << 11,
-    LinuxLdSoConf = 1 << 12,
-    LinuxSecureExecution = 1 << 13,
-    LinuxTransitiveDependencies = 1 << 14,
-    LinuxMultiarchDefaultPaths = 1 << 15,
-    LinuxLdPreload = 1 << 16,
+    LinuxRPathRunPath = 1UL << 10,
+    LinuxLdSoCache = 1UL << 11,
+    LinuxLdSoConf = 1UL << 12,
+    LinuxSecureExecution = 1UL << 13,
+    LinuxTransitiveDependencies = 1UL << 14,
+    LinuxMultiarchDefaultPaths = 1UL << 15,
+    LinuxLdPreload = 1UL << 16,
 
     // macOS (bit range 17..23)
-    MacOsAtRPathLoaderExecutablePath = 1 << 17,
-    MacOsDyldFallbackLibraryPath = 1 << 18,
-    MacOsProtectedProcessRestrictions = 1 << 19,
-    MacOsDyldSharedCacheOrOverrides = 1 << 20,
-    MacOsTransitiveDependencies = 1 << 21,
-
-    MacOsDyldFrameworkPathOrFrameworkSearch = 1 << 22,
-    MacOsDyldInsertLibraries = 1 << 23
+    MacOsAtRPathLoaderExecutablePath = 1UL << 17,
+    MacOsDyldFallbackLibraryPath = 1UL << 18,
+    MacOsProtectedProcessRestrictions = 1UL << 19,
+    MacOsDyldSharedCacheOrOverrides = 1UL << 20,
+    MacOsTransitiveDependencies = 1UL << 21,
+    MacOsDyldFrameworkPathOrFrameworkSearch = 1UL << 22,
+    MacOsDyldInsertLibraries = 1UL << 23
 }

Consyzer/Core/Models/PInvokeMethod.cs

@@ -4,8 +4,8 @@ namespace Consyzer.Core.Models;
 
 internal sealed class PInvokeMethodGroup
 {
-    public required FileInfo File { get; set; }
-    public required IReadOnlyList<PInvokeMethod> Methods { get; set; }
+    public required FileInfo File { get; init; }
+    public required IReadOnlyList<PInvokeMethod> Methods { get; init; }
 }
 
 internal sealed class PInvokeMethod