chore: move type annotation for global variables

The type annotation comment for global variables must be placed directly before the first usage of that variable. Unfortunately global $ADMIN does not count as usage.

Author: malteschmitz

classes/plugininfo/monitoringexporter.php

@@ -70,7 +70,7 @@ public function get_settings_section_name(): string {
     #[\Override]
     public function load_settings(part_of_admin_tree $adminroot, $parentnodename, $hassiteconfig): void {
         global $ADMIN;
-        /** @var admin_root $ADMIN */
+
         if (!$this->is_installed_and_upgraded()) {
             return;
         }
@@ -86,6 +86,7 @@ public function load_settings(part_of_admin_tree $adminroot, $parentnodename, $h
         include($this->full_path('settings.php'));
         if ($settings->settings != new stdClass()) {
             // Only if settings were actually added to the page, do we want to add it to the tree.
+            /** @var admin_root $ADMIN */
             $ADMIN->add($parentnodename, $settings);
         }
     }

settings.php

@@ -37,13 +37,13 @@
 defined('MOODLE_INTERNAL') || die;
 
 global $ADMIN;
-/** @var admin_root $ADMIN */
 
 // Create a top-level plugin category and add it under the admin tools super-category.
 $monitoringcategory = new admin_category(
     name: 'tool_monitoring',
     visiblename: new lang_string('pluginname', 'tool_monitoring'),
 );
+/** @var admin_root $ADMIN */
 $ADMIN->add('tools', $monitoringcategory);
 
 // Create a link to the metrics overview page and add it as the first item in the monitoring category.