Clarify Open CryptoPay commit capabilities

Author: reubenyap

lib/services/open_crypto_pay/method_support.dart

@@ -18,6 +18,8 @@ class OpenCryptoPayMethodSupport {
       case 'Ethereum':
       case 'Bitcoin':
       case 'Firo':
+        // Firo starts here for transparent/provider-broadcast payments; Spark
+        // or oversized raw transactions fall back to txid at confirmation.
         return OpenCryptoPaySubmissionFlow.rawHexToProvider;
       case 'Lightning':
       case 'BinancePay':

lib/services/open_crypto_pay/models.dart

@@ -274,4 +274,11 @@ class OpenCryptoPayCommit {
   });
 
   bool get isExpired => expiresAt.isBefore(DateTime.now());
+
+  bool get canCommitRawHex =>
+      submissionFlow == OpenCryptoPaySubmissionFlow.rawHexToProvider;
+
+  bool get canCommitTxId =>
+      submissionFlow == OpenCryptoPaySubmissionFlow.txIdAfterLocalBroadcast ||
+      method == 'Firo';
 }

lib/services/open_crypto_pay/open_crypto_pay_api.dart

@@ -44,7 +44,7 @@ class OpenCryptoPayApi {
   }) async {
     final lnurl = LnurlUtils.extractLnurl(qrUrl);
     if (lnurl == null) {
-      throw Exception('No lightning parameter found in URL');
+      throw Exception('No LNURL payload found');
     }
 
     final apiUrl = Uri.parse(LnurlUtils.decodeLnurl(lnurl));
@@ -132,9 +132,7 @@ class OpenCryptoPayApi {
     required OpenCryptoPayCommit commit,
     required String txId,
   }) async {
-    if (commit.submissionFlow !=
-            OpenCryptoPaySubmissionFlow.txIdAfterLocalBroadcast &&
-        commit.method != 'Firo') {
+    if (!commit.canCommitTxId) {
       throw UnsupportedError(
         'OpenCryptoPay method ${commit.method} cannot be committed with txid',
       );
@@ -149,7 +147,7 @@ class OpenCryptoPayApi {
     required OpenCryptoPayCommit commit,
     required String hex,
   }) async {
-    if (commit.submissionFlow != OpenCryptoPaySubmissionFlow.rawHexToProvider) {
+    if (!commit.canCommitRawHex) {
       throw UnsupportedError(
         'OpenCryptoPay method ${commit.method} cannot be committed with hex',
       );