add OwnerReference for Statefulsets

Author: Schmaetz

docs/hugo/content/en/_index.md

@@ -4,7 +4,7 @@ date: 2024-03-11T14:26:51+01:00
 draft: false
 weight: 1
 ---
-Current Release: 0.9.0 (xx.10.2025) [Release Notes](release_notes)
+Current Release: 0.9.0 (31.10.2025) [Release Notes](release_notes)
 
 <img src="https://raw.githubusercontent.com/cybertec-postgresql/CYBERTEC-pg-operator/fac724618ea1395ed49cb1db7f3429f5b4324337/docs/diagrams/cpo_logo.svg" alt="drawing" width="350" />
 

pkg/cluster/cluster.go

@@ -184,7 +184,7 @@ func (c *Cluster) createOwnerReference() []metav1.OwnerReference {
 			Name:               c.Name,
 			UID:                c.UID,
 			Controller:         util.True(),
-			BlockOwnerDeletion: util.True(),
+			BlockOwnerDeletion: util.False(),
 		},
 	}
 }
@@ -664,6 +664,15 @@ func (c *Cluster) compareStatefulSetWith(oldSts, newSts *appsv1.StatefulSet) *co
 	return &compareStatefulsetResult{match: match, reasons: reasons, rollingUpdate: needsRollUpdate, replace: needsReplace}
 }
 
+func (c *Cluster) compareOwnerReferenceFromStatefulSet(current *appsv1.StatefulSet) bool {
+	for _, ref := range current.OwnerReferences {
+		if ref.UID == c.UID && ref.Controller != nil && *ref.Controller {
+			return true
+		}
+	}
+	return false
+}
+
 type containerCondition func(a, b v1.Container) bool
 
 type containerCheck struct {

pkg/cluster/resources.go

@@ -2,6 +2,7 @@ package cluster
 
 import (
 	"context"
+	"encoding/json"
 	"fmt"
 	"strconv"
 	"strings"
@@ -172,6 +173,39 @@ func (c *Cluster) preScaleDown(newStatefulSet *appsv1.StatefulSet) error {
 	return nil
 }
 
+func (c *Cluster) patchOwnerReference(sts *appsv1.StatefulSet) (*appsv1.StatefulSet, error) {
+	c.setProcessName("patching ownerReference")
+
+	if sts == nil {
+		return nil, fmt.Errorf("there is no statefulset in the cluster")
+	}
+
+	statefulSetName := util.NameFromMeta(sts.ObjectMeta)
+	ownerRefs := c.createOwnerReference()
+
+	patchData, err := json.Marshal(map[string]interface{}{
+		"metadata": map[string]interface{}{
+			"ownerReferences": ownerRefs,
+		},
+	})
+	if err != nil {
+		return nil, fmt.Errorf("could not marshal patch for ownerReference: %w", err)
+	}
+
+	patched, err := c.KubeClient.StatefulSets(sts.Namespace).Patch(
+		context.TODO(),
+		sts.Name,
+		types.MergePatchType,
+		patchData,
+		metav1.PatchOptions{},
+	)
+	if err != nil {
+		return nil, fmt.Errorf("could not patch ownerReference for StatefulSet %q: %w", statefulSetName, err)
+	}
+
+	return patched, nil
+}
+
 func (c *Cluster) updateStatefulSet(newStatefulSet *appsv1.StatefulSet) error {
 	c.setProcessName("updating statefulset")
 	if c.Statefulset == nil {

pkg/cluster/sync.go

@@ -582,6 +582,15 @@ func (c *Cluster) syncStatefulSet() error {
 			c.applyRestoreStatefulSetSyncOverrides(desiredSts, c.Statefulset)
 		}
 
+		// Check if OwnerReference still up to date - if not patch it
+		if !c.compareOwnerReferenceFromStatefulSet(c.Statefulset) {
+			patched, err := c.patchOwnerReference(c.Statefulset)
+			if err != nil {
+				return err
+			}
+			c.Statefulset = patched
+		}
+
 		cmp := c.compareStatefulSetWith(c.Statefulset, desiredSts)
 		if !cmp.match {
 			if cmp.rollingUpdate {
@@ -1602,6 +1611,15 @@ func (c *Cluster) syncPgbackrestRepoHostConfig(spec *cpov1.PostgresSpec) error {
 		return fmt.Errorf("could not generate pgbackrest repo-host statefulset: %v", err)
 	}
 
+	// Check if OwnerReference still up to date - if not patch it
+	if !c.compareOwnerReferenceFromStatefulSet(curSts) {
+		patched, err := c.patchOwnerReference(curSts)
+		if err != nil {
+			return err
+		}
+		curSts = patched
+	}
+
 	cmp := c.compareStatefulSetWith(curSts, desiredSts)
 	if !cmp.match {
 		c.logStatefulSetChanges(curSts, desiredSts, false, cmp.reasons)