feat(event): implement event deletion preview and permanent deletion functionality, including team size validation and proposal submission enhancements

Author: Arnab-Afk

backend/routes/event.route.js

@@ -10,7 +10,7 @@ const { sendTeamInviteEmail } = require("../utils/mailer");
 const fetch = require("node-fetch");
 const { get: cGet, set: cSet, del: cDel, keys: cKeys, TTL, invalidateEvent } = require("../utils/cache");
 const { validateMoreDetails, normalizeRegistrationFields } = require("../utils/registration-fields");
-const { pickEventUpdateData } = require("../utils/event-update");
+const { pickEventUpdateData, validateTeamSize } = require("../utils/event-update");
 const {
     normalizeAssignedFacultyEmails,
     getCouncilOrganizerIdsForFaculty,
@@ -1060,6 +1060,10 @@ router.post(protected + "/create", authCheck, (req, res) => {
     if (dates && dates.length) {
         dates = dates.map((d) => new Date(d));
     }
+    const teamCheck = validateTeamSize(min_ppt, ma_ppt);
+    if (!teamCheck.ok) {
+        return res.status(400).json({ error: true, message: teamCheck.message });
+    }
     const normalizedFields = normalizeRegistrationFields(registration_fields);
     prisma.events
         .create({
@@ -1181,6 +1185,19 @@ router.post(
             );
         }
 
+        if (field.ma_ppt !== undefined || field.min_ppt !== undefined) {
+            const teamCheck = validateTeamSize(
+                field.min_ppt ?? existingEvent.min_ppt,
+                field.ma_ppt ?? existingEvent.ma_ppt,
+            );
+            if (!teamCheck.ok) {
+                return res.status(400).json({
+                    error: true,
+                    message: teamCheck.message,
+                });
+            }
+        }
+
         if (req.user.role !== "COUNCIL") {
             delete field.assigned_faculty_emails;
         } else if (field.assigned_faculty_emails !== undefined) {
@@ -1292,6 +1309,25 @@ router.post(
                                 "Selected faculty must be configured in council settings.",
                         });
                     }
+
+                    const proposal = normalizeProposal(
+                        existingEvent.proposal_document,
+                    );
+                    if (!proposal.document) {
+                        return res.status(400).json({
+                            error: true,
+                            message:
+                                "Build and save a proposal document before submitting.",
+                        });
+                    }
+                    if (!allCouncilSignatoriesSigned(proposal)) {
+                        return res.status(400).json({
+                            error: true,
+                            message:
+                                "Every council signatory on the proposal must sign before submitting.",
+                        });
+                    }
+
                     field.assigned_faculty_emails = assigned;
                     field.comment = null;
                 }
@@ -2695,6 +2731,139 @@ router.get(protected + "/export-participants/:id", authCheck, async (req, res) =
     }
 });
 
+/**
+ * GET /p/delete-preview/:id
+ * Counts of data that will be removed if the event is deleted.
+ */
+router.get(protected + "/delete-preview/:id", authCheck, async (req, res) => {
+    if (!req.user) return res.status(401).json({ error: true, message: "Unauthorized" });
+    const eventId = parseInt(req.params.id);
+    if (isNaN(eventId)) return res.status(400).json({ error: true, message: "Invalid id" });
+
+    const denied = await assertCouncilEventAccess(req.user, eventId);
+    if (denied) return res.status(denied.status).json({ error: true, message: denied.message });
+
+    try {
+        const event = await prisma.events.findUnique({
+            where: { id: eventId },
+            select: { name: true },
+        });
+        if (!event) {
+            return res.status(404).json({ error: true, message: "Event not found" });
+        }
+
+        const [
+            participants,
+            teams,
+            attended,
+            documents,
+            budgetItems,
+            announcements,
+            childEvents,
+        ] = await Promise.all([
+            prisma.participant.count({ where: { event_id: eventId } }),
+            prisma.team.count({ where: { event_id: eventId } }),
+            prisma.participant.count({
+                where: { event_id: eventId, attended: true },
+            }),
+            prisma.eventDocument.count({ where: { event_id: eventId } }),
+            prisma.budgetItem.count({ where: { event_id: eventId } }),
+            prisma.announcement.count({ where: { event_id: eventId } }),
+            prisma.events.count({ where: { parent_id: eventId } }),
+        ]);
+
+        return res.json({
+            error: false,
+            preview: {
+                name: event.name,
+                participants,
+                teams,
+                attended,
+                documents,
+                budgetItems,
+                announcements,
+                childEvents,
+            },
+        });
+    } catch (err) {
+        logger.error(err);
+        return res.status(500).json({
+            error: true,
+            message: "Error loading delete preview",
+        });
+    }
+});
+
+async function deleteEventTree(eventId, deletedIds = []) {
+    const children = await prisma.events.findMany({
+        where: { parent_id: eventId },
+        select: { id: true },
+    });
+    for (const child of children) {
+        await deleteEventTree(child.id, deletedIds);
+    }
+    await prisma.events.delete({ where: { id: eventId } });
+    deletedIds.push(eventId);
+    return deletedIds;
+}
+
+/**
+ * POST /p/delete/:id
+ * Permanently delete an event and all related data (participants, teams, etc.).
+ * Body: { confirm_name: string } must match the event name exactly.
+ */
+router.post(protected + "/delete/:id", authCheck, async (req, res) => {
+    if (!req.user) return res.status(401).json({ error: true, message: "Unauthorized" });
+    if (req.user.role !== "COUNCIL") {
+        return res.status(403).json({ error: true, message: "Forbidden" });
+    }
+
+    const eventId = parseInt(req.params.id);
+    if (isNaN(eventId)) return res.status(400).json({ error: true, message: "Invalid id" });
+
+    const denied = await assertCouncilEventAccess(req.user, eventId);
+    if (denied) return res.status(denied.status).json({ error: true, message: denied.message });
+
+    try {
+        const event = await prisma.events.findUnique({
+            where: { id: eventId },
+            select: { name: true },
+        });
+        if (!event) {
+            return res.status(404).json({ error: true, message: "Event not found" });
+        }
+
+        const confirmName =
+            req.body?.confirm_name != null
+                ? String(req.body.confirm_name).trim()
+                : "";
+        if (confirmName !== event.name) {
+            return res.status(400).json({
+                error: true,
+                message:
+                    "Type the exact event name to confirm permanent deletion.",
+            });
+        }
+
+        const deletedIds = await deleteEventTree(eventId);
+        for (const id of deletedIds) {
+            invalidateEvent(id, req.user.id);
+        }
+
+        return res.json({
+            error: false,
+            message: "Event deleted permanently.",
+            deleted_count: deletedIds.length,
+        });
+    } catch (err) {
+        logger.error(err);
+        return res.status(500).json({
+            error: true,
+            message: "Error deleting event",
+        });
+    }
+});
+
 router.get(
     protected + "/attendance-report/:id",
     authCheck,

backend/utils/event-update.js

@@ -55,4 +55,22 @@ function pickEventUpdateData(raw) {
     return data;
 }
 
-module.exports = { EVENT_UPDATE_KEYS, pickEventUpdateData };
+function validateTeamSize(min_ppt, ma_ppt) {
+    const min = Number(min_ppt);
+    const max = Number(ma_ppt);
+    if (!Number.isFinite(min) || !Number.isFinite(max)) {
+        return { ok: false, message: "Team size must be valid numbers." };
+    }
+    if (min < 1 || max < 1) {
+        return { ok: false, message: "Team size must be at least 1." };
+    }
+    if (max < min) {
+        return {
+            ok: false,
+            message: "Max team size cannot be less than min team size.",
+        };
+    }
+    return { ok: true };
+}
+
+module.exports = { EVENT_UPDATE_KEYS, pickEventUpdateData, validateTeamSize };

backend/utils/proposal-document.js

@@ -48,14 +48,21 @@ function allCouncilSignatoriesSigned(proposal) {
         ),
     );
 
-    return signatories.every((sig) =>
-        signedKeys.has(
+    return signatories.every((sig) => {
+        if (
+            sig.signatureUrl &&
+            String(sig.signatureUrl).trim()
+        ) {
+            return true;
+        }
+        return signedKeys.has(
             signatoryKey({
                 memberId: sig.memberId,
                 name: sig.name,
+                email: sig.email,
             }),
-        ),
-    );
+        );
+    });
 }
 
 function getSignaturePngUrl(signature) {

frontend/council-app/app/(dashboard)/approvals/page.tsx

@@ -3,6 +3,7 @@ import { useState, useEffect } from "react";
 import Link from "next/link";
 import { getNextAction, PIPELINE_STAGES, type EventData } from "@/lib/dummy-data";
 import { transitionEventState, fetchCouncilProfile, type FacultyAdvisorRow } from "@/lib/api";
+import { submitProposal } from "@/lib/proposal";
 import FacultyReviewerSelect from "@/components/FacultyReviewerSelect";
 import { useData } from "@/contexts/DataContext";
 import {
@@ -313,13 +314,15 @@ export default function ApprovalsPage() {
     if (loadingId !== null) return;
     setLoadingId(event.id);
     try {
-      await transitionEventState(
-        event.id,
-        newState,
-        assignedFaculty?.length
-          ? { assigned_faculty_emails: assignedFaculty }
-          : undefined,
-      );
+      if (cta === "Submit Proposal" || cta === "Resubmit Proposal") {
+        if (!assignedFaculty?.length) {
+          showToast("Select at least one faculty advisor before submitting.");
+          return;
+        }
+        await submitProposal(event.id, assignedFaculty);
+      } else {
+        await transitionEventState(event.id, newState);
+      }
       await refreshEvents();
       const successMsg: Record<string, string> = {
         "Submit Proposal":   `Proposal for "${event.name}" submitted to selected faculty!`,
@@ -328,8 +331,11 @@ export default function ApprovalsPage() {
       };
       showToast(successMsg[cta]);
       setSubmitModal(null);
-    } catch {
-      showToast(`Failed to perform "${cta}" — please try again.`);
+    } catch (err: unknown) {
+      const msg =
+        (err as { response?: { data?: { message?: string } } })?.response?.data
+          ?.message;
+      showToast(msg ?? `Failed to perform "${cta}" — please try again.`);
     } finally {
       setLoadingId(null);
     }

frontend/council-app/app/(dashboard)/controls/[id]/page.tsx

@@ -16,11 +16,12 @@ import {
   fetchEvent,
   type EventControlStats,
 } from "@/lib/api";
+import DeleteEventModal from "@/components/DeleteEventModal";
 import {
   ArrowLeft, Settings, Zap, Users, Ticket, CreditCard,
   BarChart2, Send, ClipboardList, Download, RefreshCcw,
   Eye, EyeOff, Play, Pause, Square, CheckCircle2, AlertCircle, Lock,
-  ChevronRight, Edit2,
+  ChevronRight, Edit2, Trash2,
 } from "lucide-react";
 import type { EventData } from "@/lib/dummy-data";
 import { useData } from "@/contexts/DataContext";
@@ -173,6 +174,7 @@ export default function EventControlsPage({ params }: { params: Promise<{ id: st
   const [saving, setSaving]         = useState(false);
   const [toast, setToast]           = useState<{ msg: string; ok: boolean } | null>(null);
   const [confirm, setConfirm]       = useState<{ msg: string; onConfirm: () => void } | null>(null);
+  const [showDeleteModal, setShowDeleteModal] = useState(false);
   const [transitioning, setTransitioning] = useState(false);
 
   // Local settings state
@@ -265,6 +267,10 @@ export default function EventControlsPage({ params }: { params: Promise<{ id: st
   }
 
   async function saveSettings() {
+    if (maPpt < minPpt) {
+      showToast("Max team size cannot be less than min team size.", false);
+      return;
+    }
     setSaving(true);
     try {
       await updateEventSettings(id, {
@@ -377,6 +383,19 @@ export default function EventControlsPage({ params }: { params: Promise<{ id: st
         </div>
       )}
 
+      {showDeleteModal && (
+        <DeleteEventModal
+          eventId={id}
+          onClose={() => setShowDeleteModal(false)}
+          onDeleted={async () => {
+            setShowDeleteModal(false);
+            await refreshEvents();
+            showToast("Event deleted permanently.");
+            router.push("/");
+          }}
+        />
+      )}
+
       {/* ── Header ── */}
       <div className="flex items-center gap-3 mb-5">
         <button type="button" onClick={() => router.back()}
@@ -499,6 +518,11 @@ export default function EventControlsPage({ params }: { params: Promise<{ id: st
               value={maPpt} onChange={(v) => setMaPpt(v ?? 1)} min={1} />
             <NumberInput label="Min team size" description="Minimum for submission"
               value={minPpt} onChange={(v) => setMinPpt(v ?? 1)} min={1} />
+            {maPpt < minPpt && (
+              <p className="text-red-500 text-xs font-fira -mt-2">
+                Max team size cannot be less than min team size.
+              </p>
+            )}
             <Toggle label="Somaiya Students Only" description="Restrict to @somaiya.edu"
               checked={somaiyaOnly} onChange={setSomaiyaOnly} />
             <Toggle label="More Details Form" description="Show custom fields during registration"
@@ -565,6 +589,22 @@ export default function EventControlsPage({ params }: { params: Promise<{ id: st
             {saving ? "Saving…" : "Save All Settings"}
           </button>
 
+          {/* Danger zone */}
+          <SectionCard title="Danger Zone" icon={<Trash2 size={16} className="text-red-500" />}>
+            <p className="text-muted-tx text-sm font-fira mb-4">
+              Permanently remove this event and all participant registrations,
+              attendance records, teams, documents, budget entries, and announcements.
+            </p>
+            <button
+              type="button"
+              onClick={() => setShowDeleteModal(true)}
+              className="w-full flex items-center justify-center gap-2 py-2.5 rounded-xl border border-red-500/40 bg-red-500/10 hover:bg-red-500/20 text-red-500 text-sm font-fira font-semibold transition-colors"
+            >
+              <Trash2 size={15} />
+              Delete Event Permanently
+            </button>
+          </SectionCard>
+
         </div>
       </div>