"make build" command fails on tag v0.8.0

[prasad-shirodkar]

"make build" command fails on tag v0.8.0. "make build" command completes successfully on tag v0.9.1 though.

Any idea what could be the issue?

Note: https://github.com/rook/rook/blob/v1.13.10/deploy/examples/images.txt#L5 and https://github.com/rook/rook/blob/v1.14.12/deploy/examples/images.txt#L5 require v0.8.0.

$ go version
go version go1.22.9 (Red Hat 1.22.9-2.el9_5) linux/amd64

$ make build
cd ./tools && go build -o /home/opc/projects/work/oracle-cne/kubernetes-csi-addons/bin/controller-gen ./vendor/sigs.k8s.io/controller-tools/cmd/controller-gen
/home/opc/projects/work/oracle-cne/kubernetes-csi-addons/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./apis/..."
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xa2f68f]

goroutine 24 [running]:
go/types.(*Checker).handleBailout(0xc000112800, 0xc0003dfd40)
	/usr/lib/golang/src/go/types/check.go:367 +0x88
panic({0xbf4be0?, 0x12db6f0?})
	/usr/lib/golang/src/runtime/panic.go:770 +0x132
go/types.(*StdSizes).Sizeof(0x0, {0xdf84f8, 0x12e4000})
	/usr/lib/golang/src/go/types/sizes.go:228 +0x30f
go/types.(*Config).sizeof(...)
	/usr/lib/golang/src/go/types/sizes.go:333
go/types.representableConst.func1({0xdf84f8?, 0x12e4000?})
	/usr/lib/golang/src/go/types/const.go:76 +0x9e
go/types.representableConst({0xdfe890, 0x13072b8}, 0xc000112800, 0x12e4000, 0xc0003dde50)
	/usr/lib/golang/src/go/types/const.go:106 +0x2c7
go/types.(*Checker).representation(0xc000112800, 0xc001171e80, 0x12e4000)
	/usr/lib/golang/src/go/types/const.go:256 +0x65
go/types.(*Checker).representable(0xc000112800, 0xc001171e80, 0x12e4000)
	/usr/lib/golang/src/go/types/const.go:239 +0x26
go/types.(*Checker).shift(0xc000112800, 0xc001171e00, 0xc001171e80, {0xdfc638, 0xc0006f8240}, 0x14)
	/usr/lib/golang/src/go/types/expr.go:650 +0x1eb
go/types.(*Checker).binary(0xc000112800, 0xc001171e00, {0xdfc638, 0xc0006f8240}, {0xdfcb48, 0xc0006e3760}, {0xdfcb48, 0xc0006e3780}, 0x14, 0x335862)
	/usr/lib/golang/src/go/types/expr.go:796 +0x150
go/types.(*Checker).exprInternal(0xc000112800, 0x0, 0xc001171e00, {0xdfc638, 0xc0006f8240}, {0x0, 0x0})
	/usr/lib/golang/src/go/types/expr.go:1416 +0x206
go/types.(*Checker).rawExpr(0xc000112800, 0x0, 0xc001171e00, {0xdfc638?, 0xc0006f8240?}, {0x0?, 0x0?}, 0x0)
	/usr/lib/golang/src/go/types/expr.go:979 +0x19e
go/types.(*Checker).expr(0xc000112800, 0x0?, 0xc001171e00, {0xdfc638?, 0xc0006f8240?})
	/usr/lib/golang/src/go/types/expr.go:1513 +0x30
go/types.(*Checker).binary(0xc000112800, 0xc001171e00, {0xdfc638, 0xc0006f8270}, {0xdfc638, 0xc0006f8240}, {0xdfcb48, 0xc0006e37a0}, 0xd, 0x335866)
	/usr/lib/golang/src/go/types/expr.go:783 +0xa5
go/types.(*Checker).exprInternal(0xc000112800, 0x0, 0xc001171e00, {0xdfc638, 0xc0006f8270}, {0x0, 0x0})
	/usr/lib/golang/src/go/types/expr.go:1416 +0x206
go/types.(*Checker).rawExpr(0xc000112800, 0x0, 0xc001171e00, {0xdfc638?, 0xc0006f8270?}, {0x0?, 0x0?}, 0x0)
	/usr/lib/golang/src/go/types/expr.go:979 +0x19e
go/types.(*Checker).expr(0xc000112800, 0xc001369da0?, 0xc001171e00, {0xdfc638?, 0xc0006f8270?})
	/usr/lib/golang/src/go/types/expr.go:1513 +0x30
go/types.(*Checker).constDecl(0xc000112800, 0xc001369e60, {0x0, 0x0}, {0xdfc638, 0xc0006f8270}, 0x0)
	/usr/lib/golang/src/go/types/decl.go:488 +0x2f1
go/types.(*Checker).objDecl(0xc000112800, {0xe04700, 0xc001369e60}, 0x0)
	/usr/lib/golang/src/go/types/decl.go:191 +0xa49
go/types.(*Checker).packageObjects(0xc000112800)
	/usr/lib/golang/src/go/types/resolver.go:693 +0x4dd
go/types.(*Checker).checkFiles(0xc000112800, {0xc0012a5598, 0x1, 0x1})
	/usr/lib/golang/src/go/types/check.go:408 +0x1a5
go/types.(*Checker).Files(...)
	/usr/lib/golang/src/go/types/check.go:372
sigs.k8s.io/controller-tools/pkg/loader.(*loader).typeCheck(0xc000301380, 0xc000318540)
	/home/opc/projects/work/oracle-cne/kubernetes-csi-addons/tools/vendor/sigs.k8s.io/controller-tools/pkg/loader/loader.go:286 +0x36a
sigs.k8s.io/controller-tools/pkg/loader.(*Package).NeedTypesInfo(0xc000318540)
	/home/opc/projects/work/oracle-cne/kubernetes-csi-addons/tools/vendor/sigs.k8s.io/controller-tools/pkg/loader/loader.go:99 +0x39
sigs.k8s.io/controller-tools/pkg/loader.(*TypeChecker).check(0xc000422600, 0xc000318540)
	/home/opc/projects/work/oracle-cne/kubernetes-csi-addons/tools/vendor/sigs.k8s.io/controller-tools/pkg/loader/refs.go:268 +0x2b7
sigs.k8s.io/controller-tools/pkg/loader.(*TypeChecker).check.func1(0x24?)
	/home/opc/projects/work/oracle-cne/kubernetes-csi-addons/tools/vendor/sigs.k8s.io/controller-tools/pkg/loader/refs.go:262 +0x53
created by sigs.k8s.io/controller-tools/pkg/loader.(*TypeChecker).check in goroutine 43
	/home/opc/projects/work/oracle-cne/kubernetes-csi-addons/tools/vendor/sigs.k8s.io/controller-tools/pkg/loader/refs.go:260 +0x1c5
make: *** [Makefile:139: generate] Error 2

[nixpanic]

Does make docker-build for you?

[nixpanic]

I actually see the same problem locally. v0.8.0 has been built by a GitHub workflow and pushed to the quay.io repository. The image is quite old, so maybe you need to try building it with Go 1.20 which is mentioned in go.mod.

Ideally you use more recent versions of Rook and CSI-Addons, though. That would be my strong recommendation.