fix(lean): emit unqualified trait fields in default method bodies (#1889) - #2023
Open
MavenRain wants to merge 1 commit into
Open
fix(lean): emit unqualified trait fields in default method bodies (#1889)#2023MavenRain wants to merge 1 commit into
MavenRain wants to merge 1 commit into
Conversation
…yspen#1889) The fix matches Maxime Buyse's quick-fix recommendation in the issue thread (drop qualification AND drop the Self argument). It does NOT address the recursion / forward-reference concerns; those are fundamentally constrained by Lean's class default-value semantics and remain in scope of cryspen#1904.
Contributor
|
This PR has been marked as stale due to a lack of activity for 60 days. If you believe this pull request is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days. |
Contributor
|
This PR has been closed due to a lack of activity since being marked as stale. If you believe this pull request is still relevant, please reopen it with an update or comment. |
Contributor
Author
|
Same . . . still seems relevant |
Contributor
|
I'll try to review this asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix matches Maxime Buyse's quick-fix recommendation in the issue thread (drop qualification AND drop the Self argument). It does NOT address the recursion / forward-reference concerns; those are fundamentally constrained by Lean's class default-value semantics and remain in scope of #1904.