Add fedora base repo to get qemu-user-static package#1240
Conversation
By default qemu-user-static package is part of base repo and doesn't get include to update repo until it have and update. For F44 it is observed that there is no update to this package so install fails since only update repo is checked. This PR make sure both base and update repo is enabled before downloading that package.
WalkthroughThis PR updates the Fedora repository configuration for aarch64 systems when downloading ChangesFedora Repo Configuration for aarch64
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
createdisk.sh (1)
153-169:⚠️ Potential issue | 🟠 MajorFix Fedora repo GPG verification:
gpgcheck=1is set butgpgkey=isn’t.
Increatedisk.sh(lines 153-169), the generated/tmp/fedora.reposetsgpgcheck=1for both[fedora]and[fedora-updates]but omitsgpgkey=. Fedora’s standard repo stanzas includegpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-$basearch. Without that (or preinstalled keys), thednf downloadon line 172 may fail when verifying package signatures (repo_gpgcheck=0 only disables metadata signature checking). Addgpgkey=to both stanzas (or install/provide Fedora GPG keys before thednf download; otherwisegpgcheck=0).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@createdisk.sh` around lines 153 - 169, The generated /tmp/fedora.repo in createdisk.sh sets gpgcheck=1 for [fedora] and [fedora-updates] but omits the gpgkey, causing dnf download (line 172) to fail signature verification; update the repo stanzas in createdisk.sh to include a gpgkey entry (e.g., gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-$basearch) for both [fedora] and [fedora-updates], or alternatively ensure the Fedora RPM GPG keys are installed/provisioned before the dnf download, or set gpgcheck=0 if you deliberately want to disable package signature checks. Ensure the change targets the cat > /tmp/fedora.repo block so the correct repo file is written.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@createdisk.sh`:
- Around line 153-169: The generated /tmp/fedora.repo in createdisk.sh sets
gpgcheck=1 for [fedora] and [fedora-updates] but omits the gpgkey, causing dnf
download (line 172) to fail signature verification; update the repo stanzas in
createdisk.sh to include a gpgkey entry (e.g.,
gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-$basearch) for both [fedora]
and [fedora-updates], or alternatively ensure the Fedora RPM GPG keys are
installed/provisioned before the dnf download, or set gpgcheck=0 if you
deliberately want to disable package signature checks. Ensure the change targets
the cat > /tmp/fedora.repo block so the correct repo file is written.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.22 |
|
/cherry-pick master |
|
@praveenkumar: new pull request created: #1241 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@praveenkumar: new pull request created: #1242 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
By default qemu-user-static package is part of base repo and doesn't get include to update repo until it have and update. For F44 it is observed that there is no update to this package so install fails since only update repo is checked. This PR make sure both base and update repo is enabled before downloading that package.
Summary by CodeRabbit