NSIS installer shows technical temporary filename in Windows UAC prompt during auto-update

[marc-legendre]

Hi there, I have a small improvement idea.

When using the auto-update feature (I call cargo_packager_updater::Update::download_and_install()) on Windows with an NSIS installer, the downloaded installer file is saved to a temporary file with a cabalistic name (e.g., .tmpXXXXXX.exe). And this filename is displayed in the Windows UAC (User Account Control) prompt, which can be confusing or unsettling for end users who expect to see a recognizable application name.

Example :

Perhaps cargo-packager could provide a way to specify a custom filename for the downloaded installer ?

[Cristian-Vogel]

Does Windows also fail to show the expected signed publisher/app name there?

[marc-legendre]

Windows displays the correct publisher. It doesn't show an app name in my case.

I am not very familiar with those things. Maybe the UAC prompt can display the app name instead of the file name?

https://stackoverflow.com/a/1730766/2351757 suggests that "the UAC dialog uses the FileDescription field in the exe's VERSION resource". I checked my installer, and the FileDescription field is empty. Perhaps cargo-packager should allow populating this field?

[marc-legendre]

Oh, I digged into the .nsi template, and I see that the FileDescription is populated from short_description, which seems to be populated from the description field of the cargo-packager configuration. I'll test this.

[marc-legendre]

It works! The value of package.metadata.packager.description appears in the UAC prompt, instead of the installer's file name. Perhaps this is worth documenting.

Anyway, that's ok for me, feel free to close the issue.