events: add support for artifact events

- cmd/podman/common/completion.go: Added shell auto-completion for
  the `artifact=` and `type=artifact` event filters.
- libpod/events/events.go: Added `Artifact` to `ToHumanReadable`
  formatting, mirroring the `Image` output formatting.
- libpod/events/filters.go: Implemented event filtering logic for the
  `ARTIFACT` type by name and ID.
- libpod/events/journal_linux.go: Updated journald reader and writer
  functions to accurately parse and log artifact events.
- libpod/events/logfile.go: Allowed the `Artifact` event type to pass
  through the file logger reader without throwing an unknown type error.

Signed-off-by: Byounguk Lee <nimdrak@gmail.com>

Author: nimdrak

cmd/podman/common/completion.go

@@ -1577,7 +1577,7 @@ func getMethodNames(f reflect.Value, prefix string) []formatSuggestion {
 }
 
 // AutocompleteEventFilter - Autocomplete event filter flag options.
-// -> "container=", "event=", "image=", "pod=", "volume=", "type="
+// -> "container=", "event=", "image=", "pod=", "volume=", "type=", "artifact="
 func AutocompleteEventFilter(cmd *cobra.Command, _ []string, toComplete string) ([]string, cobra.ShellCompDirective) {
 	event := func(_ string) ([]string, cobra.ShellCompDirective) {
 		return []string{
@@ -1596,11 +1596,13 @@ func AutocompleteEventFilter(cmd *cobra.Command, _ []string, toComplete string)
 		return []string{
 			events.Container.String(), events.Image.String(), events.Network.String(),
 			events.Pod.String(), events.System.String(), events.Volume.String(), events.Secret.String(),
+			events.Artifact.String(),
 		}, cobra.ShellCompDirectiveNoFileComp
 	}
 	kv := keyValueCompletion{
 		"container=": func(s string) ([]string, cobra.ShellCompDirective) { return getContainers(cmd, s, completeDefault) },
 		"image=":     func(s string) ([]string, cobra.ShellCompDirective) { return getImages(cmd, s) },
+		"artifact=":  func(s string) ([]string, cobra.ShellCompDirective) { return getArtifacts(cmd, s) },
 		"pod=":       func(s string) ([]string, cobra.ShellCompDirective) { return getPods(cmd, s, completeDefault) },
 		"volume=":    func(s string) ([]string, cobra.ShellCompDirective) { return getVolumes(cmd, s) },
 		"event=":     event,

libpod/events/events.go

@@ -79,7 +79,7 @@ func (e *Event) ToHumanReadable(truncate bool) string {
 		} else {
 			humanFormat = fmt.Sprintf("%s %s %s %s (container=%s, name=%s)", e.Time, e.Type, e.Status, id, id, e.Network)
 		}
-	case Image:
+	case Image, Artifact:
 		humanFormat = fmt.Sprintf("%s %s %s %s %s", e.Time, e.Type, e.Status, id, e.Name)
 		if e.Error != "" {
 			humanFormat += " " + e.Error

libpod/events/filters.go

@@ -39,6 +39,16 @@ func generateEventFilter(filter, filterValue string) (func(e *Event) bool, error
 			}
 			return strings.HasPrefix(e.ID, filterValue)
 		}, nil
+	case "ARTIFACT":
+		return func(e *Event) bool {
+			if e.Type != Artifact {
+				return false
+			}
+			if e.Name == filterValue {
+				return true
+			}
+			return strings.HasPrefix(e.ID, filterValue)
+		}, nil
 	case "POD":
 		return func(e *Event) bool {
 			if e.Type != Pod {

libpod/events/journal_linux.go

@@ -37,7 +37,7 @@ func (e EventJournalD) Write(ee Event) error {
 
 	// Add specialized information based on the podman type
 	switch ee.Type {
-	case Image:
+	case Image, Artifact:
 		m["PODMAN_NAME"] = ee.Name
 		m["PODMAN_ID"] = ee.ID
 		if ee.Error != "" {
@@ -281,7 +281,7 @@ func newEventFromJournalEntry(entry *sdjournal.JournalEntry) (*Event, error) {
 		if err := getLabelsFromJournal(entry, &newEvent); err != nil {
 			return nil, err
 		}
-	case Image:
+	case Image, Artifact:
 		newEvent.ID = entry.Fields["PODMAN_ID"]
 		if val, ok := entry.Fields["ERROR"]; ok {
 			newEvent.Error = val

libpod/events/logfile.go

@@ -174,7 +174,7 @@ func (e EventLogFile) Read(ctx context.Context, options ReadOptions) error {
 				continue
 			}
 			switch event.Type {
-			case Image, Volume, Pod, Container, Network, Secret:
+			case Image, Volume, Pod, Container, Network, Secret, Artifact:
 				//	no-op
 			case System:
 				begin, end, err := e.readRotateEvent(event)