Skip to content

Commit 2e88df3

Browse files
committed
fix(ci): pin ttyd 1.7.7 via mise β€” fixes prefix e2e failures
CI installed ttyd 1.7.4 from apt which bundles an older xterm.js. The prefix button's async handler (sendText β†’ openComboPicker) broke silently, causing all 8 prefix Playwright tests to fail. Pin ttyd in mise.toml so CI and local use the same version.
1 parent cae17de commit 2e88df3

3 files changed

Lines changed: 2 additions & 2 deletions

File tree

β€Ž.github/workflows/ci.ymlβ€Ž

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ jobs:
1313
- uses: actions/checkout@v4
1414
- uses: jdx/mise-action@v3
1515
- run: pnpm install
16-
- run: sudo apt-get update && sudo apt-get install -y ttyd
1716
- run: pnpm exec playwright install --with-deps chromium webkit
1817
- run: pnpm test
1918
- run: pnpm run build:dist

β€ŽREADME.mdβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ Your coding agent handles the rest. It installs remobi, inspects your tmux confi
4141
- [ttyd](https://github.com/tsl0922/ttyd) β€” must be on PATH for `remobi serve` and `remobi build` (they spawn a temporary ttyd to fetch base HTML). Install on macOS with `brew install ttyd`; on Linux use your distro package manager or build from source via the [ttyd installation guide](https://github.com/tsl0922/ttyd#installation). `remobi inject` pipes HTML from stdin and does **not** require ttyd β€” useful for CI or environments where ttyd isn't installed locally.
4242
- [tmux](https://github.com/tmux/tmux) (the target multiplexer)
4343

44-
remobi uses standard ttyd flags (`--writable`, `-t`, `-i`) and should work with any recent ttyd release.
44+
Tested with ttyd 1.7.7. Older versions (e.g. 1.7.4 from Ubuntu apt) may have xterm.js incompatibilities.
4545

4646
## Manual setup
4747

β€Žmise.tomlβ€Ž

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@ npm = "latest"
44
pnpm = "latest"
55
typos = "latest"
66
hk = "latest"
7+
ttyd = "1.7.7"

0 commit comments

Comments
Β (0)