Skip to content

Commit d0ea8ac

Browse files
committed
fix: update changeset handling in CI
1 parent 4e94e25 commit d0ea8ac

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ jobs:
216216
exit 0
217217
fi
218218
219-
echo "::error::Missing changeset for: $missing"
219+
echo "::warning::Missing changeset for: $missing"
220220
echo ""
221221
echo "The following packages were changed but not covered by a changeset:"
222222
for pkg in $missing; do
@@ -227,4 +227,6 @@ jobs:
227227
echo " 1. Run 'pnpm changeset' to add a changeset covering the missing packages"
228228
echo " 2. Add an empty changeset (no packages selected) if no version bump is needed"
229229
echo " 3. Add the 'skip-changeset' label to this PR"
230-
exit 1
230+
echo ""
231+
echo "CI will continue; add a changeset before merge if you plan to release."
232+
exit 0

AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Contributor conventions for this repo live in [`CONTRIBUTING.md`](./CONTRIBUTING
44

55
Failure modes that most often trip agents here:
66

7-
- **Forgetting `pnpm changeset`.** Pull requests that touch `codemods/` need a changeset covering each changed package (or the `skip-changeset` label). CI enforces this. See _Adding a changeset_ in `CONTRIBUTING.md`.
7+
- **Forgetting `pnpm changeset`.** Pull requests that touch `codemods/` should include a changeset covering each changed package (or the `skip-changeset` label). CI warns but does not fail when changesets are missing. See _Adding a changeset_ in `CONTRIBUTING.md`.
88
- **Editing `version` in `codemod.yaml` by hand.** The `version` field in `codemod.yaml` is synced automatically from `package.json` by `scripts/sync-codemod-versions.sh` when `pnpm run version-packages` runs. Only edit `version` in `package.json` (via changesets). See _Release workflow_ in `CONTRIBUTING.md`.
99
- **Skipping local checks.** Run `pnpm run format`, `pnpm run lint`, and `pnpm run ci` before you call the task done. See _Development setup_ and _CI_ in `CONTRIBUTING.md`.
1010

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ Three workflows run on every PR and push to `main`:
6565

6666
- **`ci.yml` — Pull request checks:** oxfmt / oxlint and docs-link checks on changed files; `pnpm test` and `pnpm run check-types` only for codemod packages touched by the diff.
6767
- **`ci.yml` — Full workspace (main):** on every push to `main`, runs full `pnpm run ci` (all tests + typechecks) and `pnpm run docs:links`.
68-
- **`ci.yml` — Changeset check:** enforces that every PR touching `codemods/` includes a changeset for each changed package (or has the `skip-changeset` label).
68+
- **`ci.yml` — Changeset check:** warns when a PR touching `codemods/` is missing a changeset for a changed package (or use the `skip-changeset` label to silence the warning).
6969

7070
Match the local checks (`pnpm run ci`) before you push.
7171

0 commit comments

Comments
 (0)