Accept symbol or string keys for inline_icon

Coerce icon arg with to_s in icon lookups and switch literal call
sites to symbols.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: dfl

app/components/back_button_component.html.erb

@@ -1,7 +1,7 @@
 <% extra_class = html_attrs&.delete(:class) %>
 <% label_content = capture do %>
   <span class="inline-flex items-center justify-center gap-cfa-xsm">
-    <%= inline_icon("arrow_left", size: 24, aria_hidden: true) %>
+    <%= inline_icon(:arrow_left, size: 24, aria_hidden: true) %>
     <%= I18n.t("back") %>
   </span>
 <% end %>

app/components/base_component.rb

@@ -57,19 +57,19 @@ def initialize(html_attrs:)
   end
 
   def icon_image_path(icon)
-    ICONS.dig(icon, :path) || ""
+    ICONS.dig(icon.to_s, :path) || ""
   end
 
   def icon_alt_text(icon)
-    base = ICONS.dig(icon, :alt)
+    base = ICONS.dig(icon.to_s, :alt)
     base ? "#{base} icon" : ""
   end
 
   # Render the icon as a CSS-masked span so it inherits CSS `color`
   # via `background-color: currentColor`. Uses the same image-rasterization
   # path as `<img src=...>`, preserving pixel-perfect positioning.
   def inline_icon(icon, size: 20, css_class: nil, aria_hidden: false)
-    path = ICONS.dig(icon, :path)
+    path = ICONS.dig(icon.to_s, :path)
     return "".html_safe unless path
 
     style = "--icon-url: url('#{image_path(path)}'); width: #{size}px; height: #{size}px"
@@ -87,7 +87,7 @@ def required_class
   def checkbox_wrap(checkbox_html, small: false)
     size = small ? 16 : 24
     box = small ? "h-4 w-4" : "h-6 w-6"
-    icon = inline_icon("check", size:, aria_hidden: true, css_class: "absolute inset-0 pointer-events-none text-text-default")
+    icon = inline_icon(:check, size:, aria_hidden: true, css_class: "absolute inset-0 pointer-events-none text-text-default")
     content_tag :span, checkbox_html + icon, class: "cfa-checkbox-wrap relative inline-flex #{box}"
   end
 end

app/components/checkboxes_component.html.erb

@@ -30,7 +30,7 @@
     <%= render(FormErrorsComponent.new(form: @form, method: @method, small: @small)) %>
     <% if has_warning? %>
       <p class="form_warning flex items-center gap-cfa-sm text-text-body-secondary">
-        <%= inline_icon("alert", size: icon_size, css_class: "text-warning") %>
+        <%= inline_icon(:alert, size: icon_size, css_class: "text-warning") %>
         <span><%= @warning_message %></span>
       </p>
     <% end %>

app/components/form_errors_component.html.erb

@@ -1,6 +1,6 @@
 <% if @form.object.errors[@method].any? %>
   <p class="form_errors flex items-center gap-cfa-sm text-text-body-secondary">
-    <%= inline_icon("error", size: @small ? 16 : 24, css_class: "text-error") %>
+    <%= inline_icon(:error, size: @small ? 16 : 24, css_class: "text-error") %>
     <span>
       <%= safe_join(
             @form.object.errors.where(@method).map { |e| e.message.html_safe? ? e.full_message.html_safe : e.full_message },

app/components/modal_component.html.erb

@@ -5,7 +5,7 @@
         <div class="space-x-cfa-xl flex flex-row">
           <h2 :id="$id('<%= @name %>-title')"><%= header %></h2>
           <div class="w-[25px] shrink-0">
-            <a href="#" @click="toggle()" class="flex flex-col items-start cursor-pointer" style="color: inherit" aria-label="<%= t("cfaui.modal.close_aria") %>"><%= inline_icon("xmark", size: 25, aria_hidden: true) %></a>
+            <a href="#" @click="toggle()" class="flex flex-col items-start cursor-pointer" style="color: inherit" aria-label="<%= t("cfaui.modal.close_aria") %>"><%= inline_icon(:xmark, size: 25, aria_hidden: true) %></a>
           </div>
         </div>
         <div :id="$id('<%= @name %>-description')" class="space-y-cfa-med">

app/components/radio_buttons_component.html.erb

@@ -29,7 +29,7 @@
     <%= render(FormErrorsComponent.new(form: @form, method: @method, small: @small)) %>
     <% if has_warning? %>
       <p class="form_warning flex items-center gap-cfa-sm text-text-body-secondary">
-        <%= inline_icon("alert", size: icon_size, css_class: "text-warning") %>
+        <%= inline_icon(:alert, size: icon_size, css_class: "text-warning") %>
         <span><%= @warning_message %></span>
       </p>
     <% end %>

app/components/reveal_component.html.erb

@@ -6,7 +6,7 @@
       <% end %>
       <%= @summary_text %>
     </p>
-    <span class="ml-[10px] inline-flex items-center transition-transform duration-200 group-open:rotate-180"><%= inline_icon("chevron_down", size: 25, aria_hidden: true) %></span>
+    <span class="ml-[10px] inline-flex items-center transition-transform duration-200 group-open:rotate-180"><%= inline_icon(:chevron_down, size: 25, aria_hidden: true) %></span>
   </summary>
 
   <div class="space-y-cfa-med mt-cfa-sm">

app/components/yes_no_buttons_component.html.erb

@@ -6,7 +6,7 @@
               class="yes-no-buttons__button"
               @click="selected = '<%= val %>'"
               :class="{ 'is-selected': selected === '<%= val %>' }">
-        <%= inline_icon("circle_check", size: 24, aria_hidden: true, css_class: "yes-no-buttons__check") %>
+        <%= inline_icon(:circle_check, size: 24, aria_hidden: true, css_class: "yes-no-buttons__check") %>
         <span class="yes-no-buttons__label"><%= label %></span>
       </button>
     <% end %>