Use maven for SonarCloud analysis

Author: Turiok

.github/workflows/java-continuous-integration.yml

@@ -8,6 +8,10 @@
 name: Java CI
 
 on: [push, pull_request]
+env:
+  MVN_USR: dummy
+  MVN_PWD: ${{ secrets.GITHUB_TOKEN }}
+
 
 jobs:
 
@@ -39,10 +43,7 @@ jobs:
           path: "**/target/"
           key: ${{ runner.os }}-cache-java-${{ matrix.java }}-${{ github.sha }}
       - name: Build with Maven
-        run: mvn -B clean install -s settings.xml
-        env:
-          MVN_USR: dummy
-          MVN_PWD: ${{ secrets.GITHUB_TOKEN }}
+        run: mvn -B clean verify -s settings.xml
 
   code-analysis:
     permissions:
@@ -65,14 +66,8 @@ jobs:
           path: "**/target/"
           fail-on-cache-miss: true
           key: ${{ runner.os }}-cache-java-21-${{ github.sha }}
-      # the latest version at https://github.com/marketplace/actions/official-sonarqube-scan
-      # Triggering SonarQube analysis as results of it are required by Quality Gate check.
       - name: SonarQube Scan
-        uses: SonarSource/sonarqube-scan-action@v6
-        with:
-          args: >
-            -Dsonar.qualitygate.wait=true
-            -Dsonar.qualitygate.timeout=600
+        run: mvn -s settings.xml -B org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=Turiok_sonar-icode-cnes-plugin
         env:
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
 

pom.xml

@@ -71,6 +71,7 @@
         <sonar.pluginOrganizationName>CNES</sonar.pluginOrganizationName>
         <sonar.sources>src/main/java</sonar.sources>
         <sonar.test>src/test/java</sonar.test>
+        <sonar.organization>turiok</sonar.organization>
     </properties>
 
     <dependencies>

sonar-project.properties

@@ -200,7 +200,6 @@ private void executeEmbeddedICode(final SensorContext sensorContext) {
             filesMap.put(inputFile.uri().getPath(), inputFile);
         }
 
-
         // Run all checkers on all files.
         final List<CheckResult> results = analyzer.stableCheck(files, LanguageService.getLanguagesIds(), null);
 
@@ -333,9 +332,9 @@ static void saveIssue(final SensorContext context, final Map<String, InputFile>
             newIssue.at(newIssueLocation);
             newIssue.save();
         } else {
-            LOGGER.error(String.format(
-                    "Issue '%s' on file '%s' has not been saved because source file was not found.",
-                    issue.getAnalysisRuleId(), issue.getResult().getFileName()));
+            LOGGER.error(
+                    "Issue '{}' on file '{}' has not been saved because source file was not found.",
+                    issue.getAnalysisRuleId(), issue.getResult().getFileName());
         }
 
     }

src/main/java/fr/cnes/sonar/plugins/icode/check/ICodeSensor.java

@@ -71,7 +71,7 @@ private void createBuiltInProfile(final Context context, final String repository
         }
         profile.setDefault(true);
         profile.done();
-        LOGGER.info(String.format("%s rules are activated for the repository %s.", profile.activeRules().size(),
-                repository));
+        LOGGER.info("{} rules are activated for the repository {}.", profile.activeRules().size(),
+                repository);
     }
 }

src/main/java/fr/cnes/sonar/plugins/icode/languages/ICodeQualityProfiles.java

@@ -317,9 +317,9 @@ private static void saveMeasure(final SensorContext context, final Map<String, I
             // Finally save the measure.
             newMeasure.save();
         } else {
-            LOGGER.error(String.format(
-                    "Measure '%s' on file '%s' has not been saved because source file was not found.",
-                    metric.getName(), filename));
+            LOGGER.error(
+                    "Measure '{}' on file '{}' has not been saved because source file was not found.",
+                    metric.getName(), filename);
         }
     }