feat(server-impl): compress /client getConfiguration responses#3991
Open
Korioz wants to merge 1 commit into
Open
feat(server-impl): compress /client getConfiguration responses#3991Korioz wants to merge 1 commit into
Korioz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Reduce the bandwidth used by
POST /client method=getConfigurationendpoint. The server currently sends the response as JSON to every connecting client. On some servers the response can exceeds 10 Mb per client.This can be an issue with 100 clients connecting at the same time on server restarts this make the server sends a spike of 1 Gbps. With 500+ players this is problematic and requires better bandwidth just for the connection of clients.
How is this PR achieving the goal
/clienthandler now gzips the JSON body when the client supports it.Measured on a test server:
It should not introduce any breaking changes except if some power users MITM the getConfiguration response 😐
This PR applies to the following area(s)
Server, FiveM, RedM
Successfully tested on
Game builds: Not concerned.
Platforms: Windows.
Checklist