chore: linter

Author: evan-forbes

consensus/propagation/commitment.go

@@ -229,8 +229,6 @@ func (blockProp *Reactor) recoverPartsFromMempool(cb *proptypes.CompactBlock) {
 		// a proposer
 		blockProp.broadcastHaves(&haves, blockProp.self, int(partSet.Total()))
 	}
-
-	return
 }
 
 // broadcastProposal gossips the provided proposal to all peers. This should

consensus/propagation/commitment_state.go

@@ -9,11 +9,10 @@ import (
 )
 
 type proposalData struct {
-	compactBlock  *proptypes.CompactBlock
-	block         *proptypes.CombinedPartSet
-	maxRequests   *bits.BitArray
-	catchup       bool
-	decomissioned bool
+	compactBlock *proptypes.CompactBlock
+	block        *proptypes.CombinedPartSet
+	maxRequests  *bits.BitArray
+	catchup      bool
 }
 
 type ProposalCache struct {

consensus/propagation/reactor_test.go

@@ -389,7 +389,7 @@ func TestPropagationSmokeTest(t *testing.T) {
 	})
 
 	for i := int64(1); i < 5; i++ {
-		prop, ps, block, metaData := createTestProposal(sm, int64(i), 2, 1000000)
+		prop, ps, block, metaData := createTestProposal(sm, i, 2, 1000000)
 
 		// predistribute portions of the block
 		for _, tx := range block.Data.Txs {
@@ -424,7 +424,7 @@ func TestPropagationSmokeTest(t *testing.T) {
 		}
 
 		for _, r := range reactors {
-			r.Prune(int64(i))
+			r.Prune(i)
 		}
 	}
 

consensus/state.go

@@ -2533,15 +2533,6 @@ func (cs *State) syncData() {
 			completeProp := cs.isProposalComplete()
 			cs.mtx.RUnlock()
 
-			schema.WriteNote(
-				cs.traceClient,
-				h,
-				r,
-				"syncData udpate",
-				"%d %d %v",
-				h, r, completeProp,
-			)
-
 			if completeProp {
 				continue
 			}

mempool/cat/pool.go

@@ -456,7 +456,7 @@ func (txmp *TxPool) ReapMaxBytesMaxGas(maxBytes, maxGas int64) []*types.CachedTx
 // The result may have fewer than max elements (possibly zero) if the mempool
 // does not have that many transactions available.
 func (txmp *TxPool) ReapMaxTxs(max int) []*types.CachedTx {
-	var keep []*types.CachedTx
+	var keep []*types.CachedTx //nolint:prealloc
 
 	for _, w := range txmp.allEntriesSorted() {
 		if max >= 0 && len(keep) >= max {

mempool/tx.go

@@ -14,6 +14,4 @@ type TxInfo struct {
 
 	// SenderP2PID is the actual p2p.ID of the sender, used e.g. for logging.
 	SenderP2PID p2p.ID
-
-	IsRPC bool
 }

mempool/v1/mempool.go

@@ -223,7 +223,6 @@ func (txmp *TxMempool) CheckTx(tx types.Tx, cb func(*abci.Response), txInfo memp
 				txmp.metrics.AlreadySeenTxs.Add(1)
 				w := elt.Value.(*WrappedTx)
 				w.SetPeer(txInfo.SenderID)
-				w.isRpc = txInfo.IsRPC
 			}
 			return 0, mempool.ErrTxInCache
 		}

mempool/v1/reactor.go

@@ -185,7 +185,7 @@ func (memR *Reactor) ReceiveEnvelope(e p2p.Envelope) {
 			memR.Logger.Error("received tmpty txs from peer", "src", e.Src)
 			return
 		}
-		txInfo := mempool.TxInfo{SenderID: memR.ids.GetForPeer(e.Src), IsRPC: false}
+		txInfo := mempool.TxInfo{SenderID: memR.ids.GetForPeer(e.Src)}
 		if e.Src != nil {
 			txInfo.SenderP2PID = e.Src.ID()
 		}
@@ -286,10 +286,6 @@ func (memR *Reactor) broadcastTxRoutine(peer p2p.Peer) {
 			continue
 		}
 
-		if !memTx.isRpc {
-			continue
-		}
-
 		// NOTE: Transaction batching was disabled due to
 		// https://github.com/tendermint/tendermint/issues/5796
 		if !memTx.HasPeer(peerID) {

mempool/v1/tx.go

@@ -19,8 +19,6 @@ type WrappedTx struct {
 	priority  int64           // app: priority value for this transaction
 	sender    string          // app: assigned sender label
 	peers     map[uint16]bool // peer IDs who have sent us this transaction
-
-	isRpc bool
 }
 
 // Size reports the size of the raw transaction in bytes.