Skip to content

Commit d0d22c3

Browse files
mergify[bot]rootulpclaude
authored
fix: increase base ensureTimeout from 200ms to 400ms (backport #2849) (#2948)
## Summary Increases the base `ensureTimeout` in consensus tests from 200ms to 400ms. This also raises `ensureProposalTimeout` (defined as `ensureTimeout * 5`) from 1s to 2s. `ensureVoteTimeout` stays at 2s (already adequate). ## Motivation Celestia-core has more per-round work than upstream CometBFT: - Propagation reactor - CAT mempool - App-driven timeouts The 200ms base timeout was inherited from upstream, where it is also known to be flaky ([cometbft#1923](cometbft/cometbft#1923)). Upstream has not resolved their consensus test flakes. A modest increase to 400ms better reflects the actual time consensus operations take in celestia-core without meaningfully slowing down the test suite. ## Test plan - [ ] `go test -v -run TestStateFullRound1 -count=10 ./consensus/` passes - [ ] CI passes on this PR Refs: #2430 #1017 #2702 🤖 Generated with [Claude Code](https://claude.com/claude-code)<hr>This is an automatic backport of pull request #2849 done by [Mergify](https://mergify.com). <!-- devin-review-badge-begin --> --- <a href="https://app.devin.ai/review/celestiaorg/celestia-core/pull/2948" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a> <!-- devin-review-badge-end --> Co-authored-by: Rootul P <rootulp@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 479fad9 commit d0d22c3

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Increase consensus test base ensureTimeout from 200ms to 400ms to reduce flaky test failures.

consensus/common_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ type cleanupFunc func()
5555
var (
5656
config *cfg.Config // NOTE: must be reset for each _test.go file
5757
consensusReplayConfig *cfg.Config
58-
ensureTimeout = time.Millisecond * 200
58+
ensureTimeout = time.Millisecond * 400
5959
ensureVoteTimeout = time.Second * 2 // votes need longer timeout on slow CI with race detector
6060
ensureProposalTimeout = ensureTimeout * 5 // proposals can be delayed by TimeoutCommit and scheduling jitter
6161
)

0 commit comments

Comments
 (0)