fixup! fix(validator): guard against nil pointer access

Author: mpolitzer

internal/validator/validator.go

@@ -236,6 +236,11 @@ func (s *Service) validateApplication(ctx context.Context, app *Application) err
 					epoch.Index, input.Index, *input.OutputsHash, *epoch.OutputsMerkleRoot)
 			}
 
+			if input.MachineHash == nil {
+				return s.setApplicationCorrupted(ctx, app,
+				"inconsistent state: epoch %v last input (%v) machine hash is not defined",
+				epoch.Index, input.Index)
+			}
 			if *epoch.MachineHash != *input.MachineHash {
 				return s.setApplicationCorrupted(ctx, app,
 					"epoch %v machine hash does not match epoch last input (%v) machine hash. Expected: %v, Got %v",

internal/validator/validator_test.go

@@ -489,6 +489,34 @@ func (s *ValidatorSuite) TestValidateApplicationFailure() {
 		repo.AssertExpectations(s.T())
 	})
 
+	s.Run("NilInputMachineHash", func() {
+		input := Input{
+			EpochApplicationID: app.ID,
+			OutputsHash:        &validator.pristineRootHash,
+			MachineHash:        nil, // <- trigger nil guard
+		}
+
+		repo.On("ListEpochs",
+			mock.Anything, app.IApplicationAddress.String(), mock.Anything, mock.Anything, false,
+		).Return([]*Epoch{&dummyEpochs[0]}, uint64(1), nil).Once()
+
+		repo.On("ListOutputs",
+			mock.Anything, mock.Anything, mock.Anything, mock.Anything, false,
+		).Return([]*Output{}, uint64(0), nil).Once()
+
+		repo.On("GetLastInput",
+			mock.Anything, app.IApplicationAddress.String(), dummyEpochs[0].Index,
+		).Return(&input, nil).Once()
+
+		repo.On("UpdateApplicationStatus",
+			mock.Anything, mock.Anything, mock.Anything, mock.Anything,
+		).Return(nil).Once()
+
+		err := validator.validateApplication(ctx, &app)
+		s.NotNil(err)
+		repo.AssertExpectations(s.T())
+	})
+
 	s.Run("ClaimMismatch", func() {
 		invalidClaim := common.Hash{}
 		input := Input{