chore: fix lint and compile errors

Author: markwylde

package-lock.json

@@ -7,7 +7,9 @@
     "dev": "tsx src/index.ts",
     "start": "node dist/src",
     "test": "c8 tsx --test tests/basic.ts",
-    "build:ui": "esbuild --bundle src/modules/http-gui/frontend/index.tsx --outfile=src/modules/http-gui/frontend/dist/index.min.js --loader:.ts=ts --loader:.tsx=tsx && cp src/modules/http-gui/frontend/index.html src/modules/http-gui/frontend/dist"
+    "build": "tsc",
+    "build:ui": "esbuild --bundle src/modules/http-gui/frontend/index.tsx --outfile=src/modules/http-gui/frontend/dist/index.min.js --loader:.ts=ts --loader:.tsx=tsx && cp src/modules/http-gui/frontend/index.html src/modules/http-gui/frontend/dist",
+    "lint": "eslint"
   },
   "keywords": [],
   "author": {
@@ -25,11 +27,17 @@
     "uuid": "^10.0.0"
   },
   "devDependencies": {
+    "@eslint/js": "^9.8.0",
+    "@types/mime-types": "^2.1.4",
     "@types/node": "^20.14.12",
+    "@types/uuid": "^10.0.0",
     "c8": "^10.1.2",
     "esbuild": "^0.23.0",
+    "eslint": "^9.8.0",
+    "globals": "^15.9.0",
     "test": "^3.3.0",
     "tsx": "^4.16.2",
-    "typescript": "^5.5.4"
+    "typescript": "^5.5.4",
+    "typescript-eslint": "^8.0.0"
   }
 }

package.json

@@ -58,7 +58,7 @@ export type Context = {
     /** JetStream client */
     js: JetStreamClient;
   }
-  /** Array of cleanup functions */
+  /** Functions added to this array will be executed when the server is closed */
   cleanups: Array<() => Promise<void>>;
 }
 
@@ -88,7 +88,7 @@ export function createContext (config: Config): Context {
     systemCollections: {
       collections: []
     },
-    // @ts-ignore
+    // @ts-expect-error TS2739
     jetStream : {},
     cleanups: []
   };

src/context.ts

@@ -1,7 +1,7 @@
-import { Context, Event, Collection } from "../../context.js";
+import { Context, Event } from "../../context.js";
 
 export function applyEvent(context : Context, event: Event) {
-  const { inMemoryDB, systemCollections } = context;
+  const { inMemoryDB } = context;
 
   const { eventType, collection, documentId, payload } = event;
   if (!inMemoryDB[collection]) {

src/modules/events/applyEvent.ts

@@ -11,49 +11,49 @@ export default async function setupHttpApi(context: Context) {
     cert: await fs.readFile(config.tls.cert)
   };
 
-  const server = https.createServer(options, async (req, res) => {
-    if (!req.url) {
-      res.writeHead(400, { 'Content-Type': 'application/json' });
-      res.end(JSON.stringify({ error: 'Invalid URL' }));
+  const server = https.createServer(options, async (request, response) => {
+    if (!request.url) {
+      response.writeHead(400, { 'Content-Type': 'application/json' });
+      response.end(JSON.stringify({ error: 'Invalid URL' }));
       return;
     }
 
-    const parsedUrl = url.parse(req.url, true);
+    const parsedUrl = url.parse(request.url, true);
     if (!parsedUrl.pathname) {
-      res.writeHead(400, { 'Content-Type': 'application/json' });
-      res.end(JSON.stringify({ error: 'Invalid pathname' }));
+      response.writeHead(400, { 'Content-Type': 'application/json' });
+      response.end(JSON.stringify({ error: 'Invalid pathname' }));
       return;
     }
 
     const path = parsedUrl.pathname.split('/').filter(Boolean);
     const [collection, documentId] = path;
 
     if (!collection) {
-      res.writeHead(400, { 'Content-Type': 'application/json' });
-      res.end(JSON.stringify({ error: 'Collection name is required' }));
+      response.writeHead(400, { 'Content-Type': 'application/json' });
+      response.end(JSON.stringify({ error: 'Collection name is required' }));
       return;
     }
 
     let body = '';
-    req.on('data', chunk => {
+    request.on('data', chunk => {
       body += chunk.toString();
     });
 
-    req.on('end', async () => {
+    request.on('end', async () => {
       try {
         const payload = body ? JSON.parse(body) : null;
 
-        if ((req.method === 'PUT' || req.method === 'PATCH') && payload && 'id' in payload) {
+        if ((request.method === 'PUT' || request.method === 'PATCH') && payload && 'id' in payload) {
           delete payload.id;
         }
 
-        const result = await handleDatabaseOperation(context, config.jetstream.streamName, req.method || 'GET', collection, documentId, payload);
-        res.writeHead(200, { 'Content-Type': 'application/json' });
-        res.end(JSON.stringify(result));
+        const result = await handleDatabaseOperation(context, config.jetstream.streamName, request.method || 'GET', collection, documentId, payload);
+        response.writeHead(200, { 'Content-Type': 'application/json' });
+        response.end(JSON.stringify(result));
       } catch (error) {
         console.error('Error:', error);
-        res.writeHead(500, { 'Content-Type': 'application/json' });
-        res.end(JSON.stringify({ error: error instanceof Error ? error.message : 'Unknown error' }));
+        response.writeHead(500, { 'Content-Type': 'application/json' });
+        response.end(JSON.stringify({ error: error instanceof Error ? error.message : 'Unknown error' }));
       }
     });
   });

src/modules/http-api/setup.ts

@@ -1,7 +1,6 @@
 import React, { useState, useEffect } from 'react';
 
 function App() {
-  const [darkMode, setDarkMode] = useState(false);
   const [collection, setCollection] = useState('');
   const [documentId, setDocumentId] = useState('');
   const [queryResult, setQueryResult] = useState(null);

src/modules/http-gui/frontend/App.tsx

@@ -1,8 +1,8 @@
 import https from 'node:https';
 import fs from 'node:fs/promises';
 import path from 'node:path';
-import { Context } from "../../context.js";
 import mime from 'mime-types';
+import { Context } from '../../context.js';
 
 export default async function setupHttpGui(context: Context) {
   const { config } = context;
@@ -13,36 +13,36 @@ export default async function setupHttpGui(context: Context) {
 
   const staticDir = path.join(import.meta.dirname, 'frontend/dist');
 
-  const server = https.createServer(options, async (req, res) => {
-    if (req.url?.startsWith('/api/')) {
+  const server = https.createServer(options, async (request, response) => {
+    if (request.url?.startsWith('/api/')) {
       // Proxy request to the API server
       const apiReq = https.request({
         hostname: 'localhost',
         port: config.ports.gui,
-        path: req.url.replace('/api', ''),
-        method: req.method,
-        headers: req.headers,
+        path: request.url.replace('/api', ''),
+        method: request.method,
+        headers: request.headers,
         rejectUnauthorized: false // Only for development, remove in production
       }, (apiRes) => {
-        res.writeHead(apiRes.statusCode || 500, apiRes.headers);
-        apiRes.pipe(res);
+        response.writeHead(apiRes.statusCode || 500, apiRes.headers);
+        apiRes.pipe(response);
       });
 
       apiReq.on('error', (error) => {
         console.error('Error proxying to API:', error);
-        res.writeHead(500, { 'Content-Type': 'text/plain' });
-        res.end('Internal Server Error');
+        response.writeHead(500, { 'Content-Type': 'text/plain' });
+        response.end('Internal Server Error');
       });
 
-      req.pipe(apiReq);
+      request.pipe(apiReq);
     } else {
       try {
         let filePath;
-        if (req.url === '/' || req.url === '/index.html') {
+        if (request.url === '/' || request.url === '/index.html') {
           filePath = path.join(staticDir, 'index.html');
         } else {
           // Normalize the path to prevent directory traversal
-          const normalizedPath = path.normalize(req.url || '').replace(/^(\.\.[\/\\])+/, '');
+          const normalizedPath = path.normalize(request.url || '').replace(/^(\.\.[/\\])+/, '');
           filePath = path.join(staticDir, normalizedPath);
         }
 
@@ -58,16 +58,16 @@ export default async function setupHttpGui(context: Context) {
 
         const content = await fs.readFile(filePath);
         const contentType = mime.lookup(filePath) || 'application/octet-stream';
-        res.writeHead(200, { 'Content-Type': contentType });
-        res.end(content);
-      } catch (error) {
+        response.writeHead(200, { 'Content-Type': contentType });
+        response.end(content);
+      } catch (error: any) {
         console.error('Error serving file:', error);
         if (error.code === 'ENOENT') {
-          res.writeHead(404, { 'Content-Type': 'text/plain' });
-          res.end('Not Found');
+          response.writeHead(404, { 'Content-Type': 'text/plain' });
+          response.end('Not Found');
         } else {
-          res.writeHead(500, { 'Content-Type': 'text/plain' });
-          res.end('Internal Server Error');
+          response.writeHead(500, { 'Content-Type': 'text/plain' });
+          response.end('Internal Server Error');
         }
       }
     }

src/modules/http-gui/setup.ts

@@ -23,26 +23,21 @@ interface Response {
 
 async function makeRequest(options: RequestOptions, data: any = null): Promise<Response> {
   const url = `https://${options.hostname}:${options.port}${options.path}`;
-  const fetchOptions: any = {
+  const fetchOptions: RequestInit = { // Changed from any to RequestInit
+    method: options.method, // Explicitly set the method
     headers: {
       'Content-Type': 'application/json'
     },
     body: data ? JSON.stringify(data) : undefined,
-    ...options
   };
 
-  try {
-    const res = await fetch(url, fetchOptions);
-    const responseBody = await res.json();
-    return {
-      statusCode: res.status,
-      headers: res.headers,
-      body: responseBody
-    };
-  } catch (error) {
-    // console.log(error);
-    throw error;
-  }
+  const response = await fetch(url, fetchOptions);
+  const responseBody = await response.json();
+  return {
+    statusCode: response.status,
+    headers: response.headers as Headers,
+    body: responseBody
+  };
 }
 
 const testConfig: Config = {
@@ -81,8 +76,7 @@ describe('CanhazDB Server Tests', async () => {
         hostname: 'localhost',
         port: 3000,
         path: '/users',
-        method: 'POST',
-        rejectUnauthorized: false
+        method: 'POST'
       }, { name: 'John Doe', age: 30 });
 
       assert.equal(response.statusCode, 200);
@@ -97,8 +91,7 @@ describe('CanhazDB Server Tests', async () => {
         hostname: 'localhost',
         port: 3000,
         path: '/users',
-        method: 'POST',
-        rejectUnauthorized: false
+        method: 'POST'
       }, { name: 'Jane Doe', age: 25 });
 
       const documentId = createResponse.body.documentId;
@@ -144,8 +137,7 @@ describe('CanhazDB Server Tests', async () => {
         hostname: 'localhost',
         port: 3000,
         path: `/users/${documentId}`,
-        method: 'GET',
-        rejectUnauthorized: false
+        method: 'GET'
       });
 
       assert.equal(getResponse.body.name, 'Bob Smith');
@@ -158,8 +150,7 @@ describe('CanhazDB Server Tests', async () => {
         hostname: 'localhost',
         port: 3000,
         path: '/users',
-        method: 'POST',
-        rejectUnauthorized: false
+        method: 'POST'
       }, { name: 'Alice Johnson', age: 35 });
 
       const documentId = createResponse.body.documentId;
@@ -169,8 +160,7 @@ describe('CanhazDB Server Tests', async () => {
         hostname: 'localhost',
         port: 3000,
         path: `/users/${documentId}`,
-        method: 'DELETE',
-        rejectUnauthorized: false
+        method: 'DELETE'
       });
 
       assert.equal(response.statusCode, 200);
@@ -182,8 +172,7 @@ describe('CanhazDB Server Tests', async () => {
         hostname: 'localhost',
         port: 3000,
         path: `/users/${documentId}`,
-        method: 'GET',
-        rejectUnauthorized: false
+        method: 'GET'
       });
 
       assert.deepEqual(getResponse.body, { error: 'Document not found' });
@@ -237,8 +226,7 @@ describe('CanhazDB Server Tests', async () => {
         hostname: 'localhost',
         port: 3000,
         path: '',
-        method: 'GET',
-        rejectUnauthorized: false
+        method: 'GET'
       });
       assert.equal(response.statusCode, 400);
       assert.equal(response.body.error, 'Collection name is required');
@@ -249,8 +237,7 @@ describe('CanhazDB Server Tests', async () => {
         hostname: 'localhost',
         port: 3000,
         path: '/',
-        method: 'GET',
-        rejectUnauthorized: false
+        method: 'GET'
       });
       assert.equal(response.statusCode, 400);
       assert.equal(response.body.error, 'Collection name is required');

tests/basic.ts

@@ -20,5 +20,5 @@
     "checkJs": true
   },
   "include": ["tests/**/*", "src/**/*"],
-  "exclude": ["node_modules", "dist"]
+  "exclude": ["node_modules", "dist", "src/modules/http-gui/frontend/**/*"]
 }