To reproduce:
- Create a todo item
- Double-click to edit it
- Delete all of its text
- Press enter.
There is an exception on the console, but more concretely the double-click to edit feature is broken.
The stack points to here:
(todo, editingId) => todo.id === editingId,
and I suspect this is due to some interaction between actions.destroy and the function there -- maybe combine runs the function when editingId$ updates (not sure though).
It would be nice to be able to write that function without having to null check the arguments, but I'm not sure yet where that fix goes.
To reproduce:
There is an exception on the console, but more concretely the double-click to edit feature is broken.
The stack points to here:
and I suspect this is due to some interaction between
actions.destroyand the function there -- maybecombineruns the function wheneditingId$updates (not sure though).It would be nice to be able to write that function without having to null check the arguments, but I'm not sure yet where that fix goes.