Try to reduce crashes when using certain URL types.

Author: bradhowes

SoundFontsFramework/SoundFontsFramework/Audio/SoundFontsAU.swift

@@ -188,21 +188,28 @@ extension SoundFontsAU {
       return
     }
 
+    let url = soundFont.fileURL
+    let secured = url.startAccessingSecurityScopedResource()
+    defer { if secured { url.stopAccessingSecurityScopedResource() } }
+
+    guard FileManager.default.fileExists(atPath: url.path) else {
+      log.error("reloadActivePreset - soundFont file \(url.path) does not exist")
+      return
+    }
+
     // NOTE: do this here instead of using the PresetChangeManager as we want this to run in the current thread.
-    if FileManager.default.fileExists(atPath: soundFont.fileURL.path) {
-      do {
-        try sampler.loadSoundBankInstrument(
-          at: soundFont.fileURL,
-          program: UInt8(activePreset.program),
-          bankMSB: UInt8(activePreset.bankMSB),
-          bankLSB: UInt8(activePreset.bankLSB)
-        )
-      } catch {
-        log.error("reloadActivePreset - failed to load sound font: \(error)")
-      }
-    } else {
-      log.error("reloadActivePreset - soundFont file \(soundFont.fileURL.path) does not exist")
+    do {
+      sampler.reset()
+      try sampler.loadSoundBankInstrument(
+        at: url,
+        program: UInt8(activePreset.program),
+        bankMSB: UInt8(activePreset.bankMSB),
+        bankLSB: UInt8(activePreset.bankLSB)
+      )
+    } catch {
+      log.error("reloadActivePreset - failed to load sound font: \(error)")
     }
+
     log.debug("reloadActivePreset END")
   }
 

SoundFontsFramework/SoundFontsFramework/Protocols/PresetLoader.swift

@@ -23,9 +23,22 @@ public protocol PresetLoader: AnyObject {
 extension AVAudioUnitSampler: PresetLoader {
 
   public func loadAndActivatePreset(_ preset: Preset, from url: URL) -> NSError? {
+    let secured = url.startAccessingSecurityScopedResource()
+    defer { if secured { url.stopAccessingSecurityScopedResource() } }
+
+    guard FileManager.default.fileExists(atPath: url.path) else {
+      os_log(.error, "reloadActivePreset - soundFont file %{public}s does not exist", url.path)
+      return nil
+    }
+
     do {
-      try loadSoundBankInstrument(at: url, program: UInt8(preset.program), bankMSB: UInt8(preset.bankMSB),
-                                  bankLSB: UInt8(preset.bankLSB))
+      reset()
+      try loadSoundBankInstrument(
+        at: url,
+        program: UInt8(preset.program),
+        bankMSB: UInt8(preset.bankMSB),
+        bankLSB: UInt8(preset.bankLSB)
+      )
     } catch let error as NSError {
       switch error.code {
       case -43: // not found