Merge pull request #630 from kennethshackleton/package-local-test

Address visibility in SQLiteOpenHelperJavaTest.java

Author: kennethshackleton

selekt-android/src/test/java/com/bloomberg/selekt/android/SQLiteDatabaseJavaTest.java

@@ -35,7 +35,7 @@
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-public final class SQLiteDatabaseJavaTest {
+final class SQLiteDatabaseJavaTest {
     private final Context targetContext = mock(Context.class);
     private SQLiteDatabase database = null;
 
@@ -47,16 +47,16 @@ public final class SQLiteDatabaseJavaTest {
         0x42, 0x42, 0x42, 0x42, 0x42, 0x42, 0x42, 0x42
     };
 
-    public SQLiteDatabaseJavaTest() throws IOException {}
+    SQLiteDatabaseJavaTest() throws IOException {}
 
     @BeforeEach
-    public void setUp() {
+    void setUp() {
         file.deleteOnExit();
         when(targetContext.getDatabasePath(anyString())).thenReturn(file);
     }
 
     @AfterEach
-    public void tearDown() {
+    void tearDown() {
         final SQLiteDatabase database = this.database;
         if (database != null) {
             try {
@@ -71,7 +71,7 @@ public void tearDown() {
     }
 
     @Test
-    public void creation() {
+    void creation() {
         database = SQLiteDatabase.openOrCreateDatabase(
             targetContext.getDatabasePath("sample"),
             SQLiteJournalMode.WAL.databaseConfiguration,

selekt-android/src/test/java/com/bloomberg/selekt/android/SQLiteOpenHelperJavaTest.java

@@ -36,7 +36,7 @@
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-public final class SQLiteOpenHelperJavaTest {
+final class SQLiteOpenHelperJavaTest {
     private final File file = File.createTempFile("test-java-open-helper", ".db");
     private final byte[] key = new byte[] {
         0x42, 0x42, 0x42, 0x42, 0x42, 0x42, 0x42, 0x42,
@@ -48,16 +48,16 @@ public final class SQLiteOpenHelperJavaTest {
     private final Context targetContext = mock(Context.class);
     private SQLiteOpenHelper databaseHelper = null;
 
-    public SQLiteOpenHelperJavaTest() throws IOException {}
+    SQLiteOpenHelperJavaTest() throws IOException {}
 
     @BeforeEach
-    public void setUp() {
+    void setUp() {
         file.deleteOnExit();
         when(targetContext.getDatabasePath(anyString())).thenReturn(file);
     }
 
     @AfterEach
-    public void tearDown() {
+    void tearDown() {
         final SQLiteOpenHelper helper = databaseHelper;
         if (helper != null) {
             final SQLiteDatabase database = helper.getWritableDatabase();
@@ -73,7 +73,7 @@ public void tearDown() {
     }
 
     @Test
-    public void creation() {
+    void creation() {
         final ISQLiteOpenHelper.Callback callback = mock(ISQLiteOpenHelper.Callback.class);
         databaseHelper = new SQLiteOpenHelper(
             targetContext,
@@ -90,7 +90,7 @@ public void creation() {
     }
 
     @Test
-    public void createWithLoggingEnabled() {
+    void createWithLoggingEnabled() {
         final ISQLiteOpenHelper.Callback callback = mock(ISQLiteOpenHelper.Callback.class);
         databaseHelper = new SQLiteOpenHelper(
             targetContext,