Updated with tests

Author: finiteops

bin/reth/tests/commands/bitfinity_node_it.rs

@@ -49,6 +49,57 @@ async fn bitfinity_test_should_start_local_reth_node() {
     assert!(reth_client.get_chain_id().await.is_ok());
 }
 
+#[tokio::test]
+async fn bitfinity_test_lb_lag_check() {
+    // Arrange
+    let _log = init_logs();
+
+    let eth_server = EthImpl::new();
+    let (_server, eth_server_address) =
+        mock_eth_server_start(EthServer::into_rpc(eth_server)).await;
+    let (reth_client, _reth_node) =
+        start_reth_node(Some(format!("http://{}", eth_server_address)), None).await;
+
+    // Try `eth_lbLagCheck`
+    let result: String = reth_client
+        .single_request(
+            "eth_lbLagCheck".to_owned(),
+            ethereum_json_rpc_client::Params::Array(vec![10.into()]),
+            ethereum_json_rpc_client::Id::Num(1),
+        )
+        .await
+        .unwrap();
+
+    assert!(result.contains("ACCEPTED_LAG"), "{result:?}");
+
+    // Need time to generate extra blocks at `eth_server`
+    // Assuming it ticks 100ms for the next block
+    tokio::time::sleep(std::time::Duration::from_millis(1500)).await;
+
+    let result: String = reth_client
+        .single_request(
+            "eth_lbLagCheck".to_owned(),
+            ethereum_json_rpc_client::Params::Array(vec![5.into()]),
+            ethereum_json_rpc_client::Id::Num(1),
+        )
+        .await
+        .unwrap();
+
+    assert!(result.contains("LAGGING"), "{result:?}");
+
+    // Default accepted lag is 3 so it should be lagging too
+    let result: String = reth_client
+        .single_request(
+            "eth_lbLagCheck".to_owned(),
+            ethereum_json_rpc_client::Params::None,
+            ethereum_json_rpc_client::Id::Num(1),
+        )
+        .await
+        .unwrap();
+
+    assert!(result.contains("LAGGING"), "{result:?}");
+}
+
 #[tokio::test]
 async fn bitfinity_test_node_forward_ic_or_eth_get_last_certified_block() {
     // Arrange

crates/rpc/rpc-eth-api/src/core.rs

@@ -399,7 +399,7 @@ where
             Ok(block) => block,
             Err(e) => {
                 // Must not fail if rpc-url/evmc is not responding
-                // or it would to break nodes cluster -> LB will stop traffic
+                // or it could've disable all nodes under LB
                 tracing::error!(target: "rpc::eth", "Failed to get block number from the network. {}", e);
                 return Ok(format!("{}: NO_SOURCE", LAG_STATUS_OK));
             }