Skip to content

refactor(chain,core)!: replace CanonicalIter with sans-IO CanonicalTask + ChainQuery trait #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oleonardolima wants to merge 7 commits into
base: master
Choose a base branch
from

fix(chain): position resolution for assumed txs

a3b2e10
Select commit
Loading
Failed to load commit list.
Open

refactor(chain,core)!: replace CanonicalIter with sans-IO CanonicalTask + ChainQuery trait #2038

fix(chain): position resolution for assumed txs
a3b2e10
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 2, 2026 in 1s

78.65% (+0.96%) compared to 47556ab

View this Pull Request on Codecov

78.65% (+0.96%) compared to 47556ab

Details

Codecov Report

❌ Patch coverage is 89.15187% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.65%. Comparing base (47556ab) to head (a3b2e10).

Files with missing lines Patch % Lines
crates/chain/src/canonical.rs 80.18% 19 Missing and 2 partials ⚠️
crates/chain/src/canonical_task.rs 94.71% 9 Missing and 3 partials ⚠️
crates/chain/src/canonical_view_task.rs 91.80% 6 Missing and 4 partials ⚠️
crates/chain/src/indexed_tx_graph.rs 0.00% 8 Missing ⚠️
crates/chain/src/local_chain.rs 88.88% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2038      +/-   ##
==========================================
+ Coverage   77.69%   78.65%   +0.96%     
==========================================
  Files          29       30       +1     
  Lines        5801     5909     +108     
  Branches      271      279       +8     
==========================================
+ Hits         4507     4648     +141     
+ Misses       1223     1185      -38     
- Partials       71       76       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov