Fix compiler warnings

Author: beckdave

src/protocols/ProtocolHttpClient.cpp

@@ -1777,7 +1777,7 @@ bool ProtocolHttpClient::received(const IStreamConnectionPtr& /*connection*/, co
         int res = 0;
         do
         {
-            res = socket->receive(const_cast<char*>(m_receiveBuffer.data() + bytesReceived + m_sizeRemaining), static_cast<int>(bytesToRead - bytesReceived));
+            res = socket->receive((m_receiveBuffer.data() + bytesReceived + m_sizeRemaining), static_cast<int>(bytesToRead - bytesReceived));
             if (res > 0)
             {
                 bytesReceived += res;

src/protocols/ProtocolHttpServer.cpp

@@ -1032,7 +1032,7 @@ bool ProtocolHttpServer::received(const IStreamConnectionPtr& /*connection*/, co
         int res = 0;
         do
         {
-            res = socket->receive(const_cast<char*>(m_receiveBuffer.data() + bytesReceived + m_sizeRemaining), static_cast<int>(bytesToRead - bytesReceived));
+            res = socket->receive((m_receiveBuffer.data() + bytesReceived + m_sizeRemaining), static_cast<int>(bytesToRead - bytesReceived));
             if (res > 0)
             {
                 bytesReceived += res;

src/protocols/ProtocolMqtt5Client.cpp

@@ -141,7 +141,7 @@ static std::string getUuid()
     strUuid.resize(50); // 37 is the exact number
     uuid_t uuid;
     uuid_generate(uuid);
-    uuid_unparse(uuid, const_cast<char*>(strUuid.data()));
+    uuid_unparse(uuid, strUuid.data());
     std::string strUuidRet = strUuid.data();
     return strUuidRet;
 }
@@ -152,7 +152,7 @@ static std::string getUuid()
     strUuid.resize(50); // 37 is the exact number
     uuid_t uuid;
     uuid_generate(uuid);
-    uuid_unparse(uuid, const_cast<char*>(strUuid.data()));
+    uuid_unparse(uuid, strUuid.data());
     std::string strUuidRet = strUuid.data();
     return strUuidRet;
 }

src/protocols/protocolhelpers/ProtocolDelimiter.cpp

@@ -166,9 +166,9 @@ bool ProtocolDelimiter::received(const IStreamConnectionPtr& /*connection*/, con
     m_receiveBuffer->resize(sizeDelimiterPrefix + bytesToRead);
     if (sizeDelimiterPrefix > 0)
     {
-        memcpy(const_cast<char*>(m_receiveBuffer->data()), const_cast<char*>(receiveBufferOld->data() + indexStart), sizeDelimiterPrefix);
+        memcpy(m_receiveBuffer->data(), const_cast<char*>(receiveBufferOld->data() + indexStart), sizeDelimiterPrefix);
     }
-    int res = socket->receive(const_cast<char*>(m_receiveBuffer->data()) + sizeDelimiterPrefix, bytesToRead);
+    int res = socket->receive(m_receiveBuffer->data() + sizeDelimiterPrefix, bytesToRead);
     if (res > 0)
     {
         auto callback = m_callback.lock();
@@ -214,12 +214,12 @@ bool ProtocolDelimiter::received(const IStreamConnectionPtr& /*connection*/, con
                         {
                             const auto& receiveBufferStore = m_receiveBuffers[n];
                             ssize_t sizeCopy = receiveBufferStore.indexEndMessage - receiveBufferStore.indexStartMessage;
-                            memcpy(const_cast<char*>(receiveBufferHelper->data()) + offset,
-                                   const_cast<char*>(receiveBufferStore.receiveBuffer->data()) + receiveBufferStore.indexStartMessage,
+                            memcpy(receiveBufferHelper->data() + offset,
+                                   receiveBufferStore.receiveBuffer->data() + receiveBufferStore.indexStartMessage,
                                    sizeCopy);
                             offset += sizeCopy;
                         }
-                        memcpy(const_cast<char*>(receiveBufferHelper->data()) + offset, const_cast<char*>(m_receiveBuffer->data()), sizeLast);
+                        memcpy(receiveBufferHelper->data() + offset, m_receiveBuffer->data(), sizeLast);
                         message->setReceiveBuffer(receiveBufferHelper, 0, m_receiveBuffersTotal);
                         m_receiveBuffersTotal = 0;
                         m_receiveBuffers.clear();

src/protocols/protocolhelpers/ProtocolFixHeaderHelper.cpp

@@ -72,7 +72,7 @@ bool ProtocolFixHeaderHelper::receiveHeader(const SocketPtr& socket, int& bytesT
     {
         sizeRead = bytesToRead;
     }
-    int res = socket->receive(const_cast<char*>(m_header.data() + m_sizeCurrent), static_cast<int>(sizeRead));
+    int res = socket->receive(m_header.data() + m_sizeCurrent, static_cast<int>(sizeRead));
     if (res > 0)
     {
         int bytesReceived = res;

src/protocolsession/ProtocolMessage.cpp

@@ -97,13 +97,13 @@ char* ProtocolMessage::addBuffer(ssize_t size, ssize_t reserve)
     ssize_t sizeBuffer = sizeHeader + reserve + m_sizeTrailer;
     m_payloadBuffers.resize(m_payloadBuffers.size() + 1);
     m_payloadBuffers.back().resize(sizeBuffer);
-    m_sendBufferRefs.push_back({const_cast<char*>(m_payloadBuffers.back().data()), sizeBuffer});
-    m_sendPayloadRefs.push_back({const_cast<char*>(m_payloadBuffers.back().data() + sizeHeader), reserve});
+    m_sendBufferRefs.push_back({m_payloadBuffers.back().data(), sizeBuffer});
+    m_sendPayloadRefs.push_back({m_payloadBuffers.back().data() + sizeHeader, reserve});
     if (size < reserve)
     {
         downsizeLastBuffer(size);
     }
-    return const_cast<char*>(m_payloadBuffers.back().data() + sizeHeader);
+    return (m_payloadBuffers.back().data() + sizeHeader);
 }
 
 void ProtocolMessage::downsizeLastBuffer(ssize_t newSize)
@@ -294,7 +294,7 @@ char* ProtocolMessage::resizeReceiveBuffer(ssize_t size)
     if (static_cast<size_t>(size) > m_receiveBuffer->size())
     {
         m_receiveBuffer->resize(size);
-        m_receiveBufferRef.first = const_cast<char*>(m_receiveBuffer->data());
+        m_receiveBufferRef.first = m_receiveBuffer->data();
     }
     m_receiveBufferRef.second = size;
     return m_receiveBufferRef.first;
@@ -305,7 +305,7 @@ void ProtocolMessage::setReceiveBuffer(const std::shared_ptr<std::string>& recei
     assert(receiveBuffer != nullptr);
     assert(offset + size <= static_cast<ssize_t>(receiveBuffer->size()));
     m_receiveBuffer = receiveBuffer;
-    m_receiveBufferRef.first = const_cast<char*>(m_receiveBuffer->data()) + offset;
+    m_receiveBufferRef.first = m_receiveBuffer->data() + offset;
     m_receiveBufferRef.second = size;
 }
 
@@ -341,8 +341,8 @@ void ProtocolMessage::moveSendBuffers(std::list<std::string>&& payloadBuffers, c
     {
         m_payloadBuffers.emplace_back(std::move(*it));
         size_t size = itSize->second;
-        m_sendBufferRefs.emplace_back(const_cast<char*>(m_payloadBuffers.back().data()), size);
-        m_sendPayloadRefs.emplace_back(const_cast<char*>(m_payloadBuffers.back().data()), size);
+        m_sendBufferRefs.emplace_back(m_payloadBuffers.back().data(), size);
+        m_sendPayloadRefs.emplace_back(m_payloadBuffers.back().data(), size);
         m_offset = size;
         m_sizeLastBlock = size;
         m_sizeSendBufferTotal += size;
@@ -374,9 +374,9 @@ char* ProtocolMessage::addSendHeader(ssize_t size)
     }
     m_headerBuffers.resize(m_headerBuffers.size() + 1);
     m_headerBuffers.back().resize(size);
-    m_sendBufferRefs.insert(m_itSendBufferRefsPayloadBegin, {const_cast<char*>(m_headerBuffers.back().data()), m_headerBuffers.back().size()});
+    m_sendBufferRefs.insert(m_itSendBufferRefsPayloadBegin, {m_headerBuffers.back().data(), m_headerBuffers.back().size()});
     m_sizeSendBufferTotal += size;
-    return const_cast<char*>(m_headerBuffers.back().data());
+    return m_headerBuffers.back().data();
 }
 void ProtocolMessage::downsizeLastSendHeader(ssize_t newSize)
 {