skip ping if node has no ip

Author: Despire

internal/clusters/ping4.go

@@ -124,13 +124,18 @@ func ping4(logger zerolog.Logger, conn *icmp.PacketConn, id, seq int, dst *net.U
 // Ping pings a single IPv4 address with the requested amount of retries.
 // An error is returned when more then count/2 packets are lost.
 func Ping(logger zerolog.Logger, count int, dst string) error {
+	dstAddr := &net.UDPAddr{IP: net.ParseIP(dst)}
+	if dstAddr.IP == nil {
+		logger.Warn().Msgf("Received invalid IP address to ping %q, skipping unreachability check", dst)
+		return nil
+	}
+
 	conn, err := icmp.ListenPacket("udp4", "0.0.0.0")
 	if err != nil {
 		return fmt.Errorf("failed to listen for icmp packets: %w", err)
 	}
 	defer conn.Close()
 
-	dstAddr := &net.UDPAddr{IP: net.ParseIP(dst)}
 	id := os.Getpid() & 0xffff // 16bit id
 	lost := 0
 

internal/clusters/ping4_test.go

@@ -250,3 +250,53 @@ func TestPingAll(t *testing.T) {
 		})
 	}
 }
+
+func TestPing(t *testing.T) {
+	logger := zerolog.New(os.Stdout)
+	type args struct {
+		count int
+		dst   string
+	}
+
+	tests := []struct {
+		name    string
+		args    args
+		wantErr bool
+	}{
+		{
+			name: "ok-empty",
+			args: args{
+				count: 5,
+				dst:   "",
+			},
+			wantErr: false,
+		},
+		{
+			name: "ok-localhost",
+			args: args{
+				count: 5,
+				dst:   "127.0.0.1",
+			},
+			wantErr: false,
+		},
+		{
+			name: "fail-invalid",
+			args: args{
+				count: 5,
+				dst:   "0.0.0.0",
+			},
+			wantErr: true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+
+			err := Ping(logger, tt.args.count, tt.args.dst)
+			if (err != nil) != tt.wantErr {
+				t.Fatalf("Ping() = %v want %v", err, tt.wantErr)
+			}
+		})
+	}
+}