Merge pull request #539 from bcorfman/phase2validationharness

Phase2validationharness

Author: bcorfman

.github/workflows/ci-build-test.yml

@@ -22,15 +22,8 @@ jobs:
   unit-tests-node:
     runs-on: ubuntu-latest
     steps:
-      - name: Install Git LFS
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y git-lfs
-
       - name: Checkout
         uses: actions/checkout@v7
-        with:
-          lfs: true
 
       - name: Setup Node
         uses: actions/setup-node@v7

.github/workflows/deploy-frontend-pages.yml

@@ -41,11 +41,6 @@ jobs:
         github.event.workflow_run.head_repository.full_name == github.repository
       )
     steps:
-      - name: Install Git LFS
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y git-lfs
-
       - name: Checkout
         uses: actions/checkout@v7
         with:

.github/workflows/e2e-main.yml

@@ -27,15 +27,8 @@ jobs:
         shard: [1, 2, 3, 4]
         shards: [4]
     steps:
-      - name: Install Git LFS
-        run: |
-          apt-get update
-          apt-get install -y git-lfs
-
       - name: Checkout
         uses: actions/checkout@v7
-        with:
-          lfs: true
 
       - name: Setup Node
         uses: actions/setup-node@v7

.github/workflows/e2e-nightly-full-matrix.yml

@@ -28,15 +28,8 @@ jobs:
         shard: [1, 2, 3, 4, 5, 6, 7, 8]
         shards: [8]
     steps:
-      - name: Install Git LFS
-        run: |
-          apt-get update
-          apt-get install -y git-lfs
-
       - name: Checkout
         uses: actions/checkout@v7
-        with:
-          lfs: true
 
       - name: Setup Node
         uses: actions/setup-node@v7

.github/workflows/e2e-pr.yml

@@ -24,15 +24,8 @@ jobs:
         shard: [1, 2]
         shards: [2]
     steps:
-      - name: Install Git LFS
-        run: |
-          apt-get update
-          apt-get install -y git-lfs
-
       - name: Checkout
         uses: actions/checkout@v7
-        with:
-          lfs: true
 
       - name: Setup Node
         uses: actions/setup-node@v7

.plans/ci-repair-harness-implementation-plan-2026-07-26.md

@@ -307,7 +307,7 @@ Goal: shake out the PhaserForge adapter before any generalization.
   change, false success, or token-expensive repeated loop.
 - [ ] Tune parsers and catalog entries from measured failures, not anticipated
   abstractions.
-- [x] Decide whether main-manifest support is justified; defer it until the
+- [x] Decide whether main-manifest support is justified; defer it until theHe
   required 10--20 failure sample exists because the current evidence does not
   justify a second adapter scope.
 

.plans/hosted-deployment-validation-harness-implementation-plan-2026-07-27.md

@@ -1,6 +1,6 @@
 # Hosted Deployment Validation Harness Implementation Plan
 
-Status: Phase 1 complete
+Status: Phase 2 complete
 
 Date: 2026-07-27
 
@@ -176,19 +176,19 @@ Timing diagnostics exit criteria:
 
 ## Phase 2 — Real-origin browser smoke
 
-- [ ] Add a Playwright adapter using the repository's installed Chromium.
-- [ ] Open the configured development Pages frontend, not the local dev
+- [x] Add a Playwright adapter using the repository's installed Chromium.
+- [x] Open the configured development Pages frontend, not the local dev
   server.
-- [ ] Assert that API requests target the configured development API origin.
-- [ ] Capture request failures, console errors, final URL, and approved
+- [x] Assert that API requests target the configured development API origin.
+- [x] Capture request failures, console errors, final URL, and approved
   response metadata without storing cookie values or auth headers.
-- [ ] Add read-only checks for app load, API reachability, and unauthenticated
+- [x] Add read-only checks for app load, API reachability, and unauthenticated
   state.
-- [ ] Add a separate explicit mutation mode for login/signup, project CRUD,
+- [x] Add a separate explicit mutation mode for login/signup, project CRUD,
   and reload persistence.
-- [ ] Use run-specific project names such as
+- [x] Use run-specific project names such as
   `REPAIR-HARNESS-DEV-<run-id>`.
-- [ ] Assert that reload preserves authentication and the updated project.
+- [x] Assert that reload preserves authentication and the updated project.
 
 Exit criteria:
 

scripts/e2e-external-webserver.cjs

@@ -251,13 +251,20 @@ async function startManagedExternalWebServer({
   };
 
   child.once('exit', (code, signal) => {
-    const phase = lifecycle.state.readyAt ? 'during the Playwright run' : 'before ready';
-    const exitError = createManagedServerError(
-      `Managed E2E web server exited ${phase} (code=${code ?? 'null'}, signal=${signal ?? 'null'})`,
-      logDir,
-    );
-    recordExit(code, signal);
-    rejectUnexpectedExit(exitError);
+    void (async () => {
+      // The child can emit `exit` before pipe consumers have flushed their final
+      // chunks. Wait for both layers before rejecting so lifecycle diagnostics
+      // never lose the stderr/stdout that explains an early server failure.
+      await recordExit(code, signal);
+      await childOutputStreamsFinished;
+      await logStreamsFinished;
+      const phase = lifecycle.state.readyAt ? 'during the Playwright run' : 'before ready';
+      const exitError = createManagedServerError(
+        `Managed E2E web server exited ${phase} (code=${code ?? 'null'}, signal=${signal ?? 'null'})`,
+        logDir,
+      );
+      rejectUnexpectedExit(exitError);
+    })();
   });
 
   try {

scripts/repair-harness/cli.ts

@@ -10,7 +10,7 @@ import { appendEvent, readState, resolveResumeDirectory, writeState } from './st
 import type { EvidenceEnvelope } from './types';
 import { aggregateRepairOutcomes, formatRepairMetrics, readRepairOutcomes, writeRepairMetrics } from './metrics';
 import { loadHostedConfig } from './hosted/config';
-import { runHostedProbe } from './hosted/run';
+import { runHostedBrowser, runHostedMutationCommand, runHostedProbe } from './hosted/run';
 import { runE2ETiming } from './e2eTimingRun';
 
 const repositoryRoot = path.resolve(new URL('../..', import.meta.url).pathname);
@@ -47,6 +47,38 @@ if (args[0] === 'e2e-timing') {
     console.error(error instanceof Error ? error.message : String(error));
     process.exitCode = 1;
   }
+} else if (args[0] === 'hosted-browser') {
+  try {
+    const configPath = value('--config');
+    if (!configPath) throw new Error('Expected --config <path> for hosted-browser.');
+    const result = await runHostedBrowser({ repo: value('--repo') ?? repositoryRoot, config: loadHostedConfig(path.resolve(configPath)), runId: value('--run-id') });
+    console.log(`Hosted browser ${result.status} in ${result.runDirectory}`);
+    if (result.status !== 'passed') process.exitCode = 1;
+  } catch (error) {
+    console.error(error instanceof Error ? error.message : String(error));
+    process.exitCode = 1;
+  }
+} else if (args[0] === 'hosted-mutate') {
+  try {
+    const configPath = value('--config');
+    const email = value('--email');
+    const password = value('--password');
+    if (!configPath) throw new Error('Expected --config <path> for hosted-mutate.');
+    if (!email || !password) throw new Error('Hosted mutation requires --email and --password; credentials are used in memory only.');
+    const result = await runHostedMutationCommand({
+      repo: value('--repo') ?? repositoryRoot,
+      config: loadHostedConfig(path.resolve(configPath)),
+      runId: value('--run-id'),
+      account: { email, password, inviteToken: value('--invite-token') },
+      signup: has('--signup'),
+      explicitFlag: has('--allow-hosted-mutations'),
+    });
+    console.log(`Hosted mutation ${result.result.status} in ${result.runDirectory}`);
+    if (result.result.status !== 'passed') process.exitCode = 1;
+  } catch (error) {
+    console.error(error instanceof Error ? error.message : String(error));
+    process.exitCode = 1;
+  }
 } else if (args[0] === 'metrics') {
   try {
     const repo = value('--repo') ?? repositoryRoot;