WIP PR comments

Author: imRohan

lib/intelligent_foods/api_client.rb

@@ -24,28 +24,35 @@ def authenticate!
       self
     end
 
-    def execute_request(request:, uri:, body: nil,
-                        authorization: default_authorization)
-      Net::HTTP.start(uri.host, uri.port, use_ssl: true) do |http|
-        request["Authorization"] = authorization.header
-        assign_body request: request, body: body
-        response = http.request(request)
-        handle_response(response: response)
-      end
+    def build_patch_request(uri:, body: nil)
+      build_request_with_body(uri: uri, body: body,
+                              http_method: Net::HTTP::Patch)
     end
 
-    def build_patch_request(uri:, body:)
+    def build_post_request(uri:, body: nil)
       build_request_with_body(uri: uri, body: body,
-                              http_method: Net::HTTP::Patch)
+                              http_method: Net::HTTP::Post)
     end
 
-    def build_request_with_body(uri:, body:, http_method: Net::HTTP::Post)
+    def build_request_with_body(uri:, body:, http_method:)
       request = http_method.new(uri)
-      request.body = body.to_json
       request["content-type"] = "application/json"
+      unless body.nil?
+        request.body = body.to_json
+      end
       request
     end
 
+    def execute_request(request:, uri:, body: nil,
+                        authorization: default_authorization)
+      Net::HTTP.start(uri.host, uri.port, use_ssl: true) do |http|
+        request["Authorization"] = authorization.header
+        assign_body request: request, body: body
+        response = http.request(request)
+        handle_response(response: response)
+      end
+    end
+
     def authenticated?
       access_token.present?
     end

lib/intelligent_foods/resources/order.rb

@@ -22,7 +22,7 @@ def self.build_from_response(data)
 
     def create!
       uri = URI("#{IntelligentFoods.base_url}/order")
-      request = client.build_request_with_body(uri: uri, body: request_body)
+      request = client.build_post_request(uri: uri, body: request_body)
       response = client.execute_request(request: request, uri: uri)
       if response.success?
         Order::build_from_response(response.data)
@@ -53,7 +53,7 @@ def update!
         Order::build_from_response(response.data)
       else
         mark_as_invalid
-        raise_error(OrderNotUpdatedError, response)
+        raise OrderNotUpdatedError.build(response)
       end
     end
 
@@ -68,7 +68,7 @@ def request_body
     end
 
     def update_request_body
-      @update_request_body ||= {
+      {
         ship_to: ship_to,
       }
     end

spec/intelligent_foods/api_client_spec.rb

@@ -175,6 +175,16 @@
       end
     end
 
+    describe "#build_post_request" do
+      it "builds a request using the Post HTTP method" do
+        client = IntelligentFoods::ApiClient.new(id: "id", secret: "secret")
+
+        result = client.build_post_request(uri: "test.com", body: {})
+
+        expect(result.method).to eq("POST")
+      end
+    end
+
     describe "#authenticated?" do
       it "is not authenticated" do
         client = IntelligentFoods::ApiClient.new(id: "id", secret: "secret")