Skip to content

Commit 517eac5

Browse files
ci: there are no flaky tests any more (#181)
* ci: there are no flaky tests any more Signed-off-by: Kostis Kapelonis <kostis.kapelonis@octopus.com> * ci: there are no flaky tests any more Signed-off-by: Kostis Kapelonis <kostis.kapelonis@octopus.com> --------- Signed-off-by: Kostis Kapelonis <kostis.kapelonis@octopus.com>
1 parent 0b6c907 commit 517eac5

1 file changed

Lines changed: 6 additions & 9 deletions

File tree

.github/pull_request_template.md

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,17 @@ If the DCO action in the integration test fails, one or more of your commits are
66

77
## Description of this PR
88

9-
109
Explain what this PR does, what is the use case and if it breaks existing behavior for other users
1110

12-
1311
## Checklist:
1412

1513
* [ ] I have added a brief description of why this PR is necessary and/or what this PR solves.
1614
* [ ] I have signed off all my commits as required by [DCO](https://github.com/argoproj/argoproj/blob/master/community/CONTRIBUTING.md#legal)
17-
* [ ] My build is green (Existing flaky test can fail)<sup>1</sup>.
18-
* [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
15+
* [ ] My build is green.
16+
* [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged
1917
* [ ] The tests actually define testcases about the feature/fix implemented
20-
* [ ] I have run all tests locally (including the flaky ones) and they pass <sup>1</sup>
21-
* [ ] I haven't changed the existing tests in a significant way, as this will break functionality for existing users <sup>2</sup>
18+
* [ ] I have run all tests locally and they pass
19+
* [ ] I haven't changed the existing tests in a significant way, as this will break functionality for existing users <sup>1</sup>
2220
* [ ] I've updated documentation as required by this PR.
2321
* [ ] I have used LLM/AI/Agent tools for this PR but I am responsible for all code of this PR
2422
* [ ] I understand what the code does and WHY it works that way according to my use case
@@ -27,7 +25,6 @@ Explain what this PR does, what is the use case and if it breaks existing behavi
2725
* [ ] My new code is using existing utility functions instead of re-implementing everything again
2826
* [ ] Optional. My organization is added to [USERS.md](https://github.com/argoproj/argo-rollouts/blob/master/USERS.md)
2927

30-
3128
Notes
32-
1. Flaky tests intermittently fail in GitHub but should always pass when you run them locally
33-
2. Unless a discussion has happened already in an issue and the breaking change is deemed acceptable
29+
30+
1. Unless a discussion has happened already in an issue and the breaking change is deemed acceptable

0 commit comments

Comments
 (0)