fix memory leak of VolAuxData on host - #691
Merged
SeverinDiederichs merged 1 commit intoAug 14, 2026
Merged
Conversation
Collaborator
Author
|
@codex review |
Collaborator
Author
|
/run-test |
|
Can one of the admins verify this patch? |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
agheata
approved these changes
Aug 14, 2026
agheata
left a comment
Contributor
There was a problem hiding this comment.
The ownership and teardown sequence is coherent: the transport owns the host array, the GPU worker is joined before device cleanup, the constant device pointer is cleared, and the singleton’s non-owning views are reset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The volume auxiliary data was allocated as a raw pointer and never freed in
InitializeSharedAdePTTransport():This is fixed by using a smart pointer on the host, and the view is cleared when the device is freed.