Access modifiers on imports in generated files

[czechboy0]

Motivation

Starting in Swift 6.0, users can set InternalImportsByDefault as an upcoming feature flag, which makes imports internal by default. Then, if they add accessModifier: package/public, the code fails to build.

Proposed solution

There should be some way to get the access modifier added on the imports as well.

One way: put if #compiler(>=6.0) around imports with the access modifier, and #else won't have it. That way we can do it without other feature flags.

Alternatives considered

No response

Additional information

No response

[YooGyeongMo]

Hi! I’m interested in working on this as a first contribution.

From what I understand, when accessModifier is set to public or package, the generated imports should also use the corresponding access modifier under Swift 6, possibly guarded with #if compiler(>=6.0) as suggested in the issue.

Before I start, I wanted to confirm the expected behavior: should generated imports use the same access modifier as the generated declarations when the access modifier is public or package, and remain unchanged otherwise?

If this is still available, I’d be happy to take a look and start with a small generated-code test.

[simonjbeaumont]

@YooGyeongMo Thanks for expressing an interest in contributing. This one is already being worked on by someone else in #883. But appreciate you being willing to take a stab at it.

[YooGyeongMo]

@simonjbeaumont Thanks for comment :) I’d love to start contributing, and I was wondering if there might be a beginner-friendly issue or a good first issue that I could take on.

I’d be happy to start small and learn through contributing.