From 3b06b1899af8bd447c35dd241824326fec909f46 Mon Sep 17 00:00:00 2001 From: yangyang23333 Date: Thu, 25 Jun 2026 09:46:46 +0800 Subject: [PATCH] docs(services/s3): fix inverted comment on disable_list_objects_v2 The first line of the doc comment said disabling list objects v2 makes OpenDAL 'not use the older List Objects V1', which is the opposite of the actual behavior. Setting disable_list_objects_v2 = true makes the backend select S3ListerV1, i.e. it falls back TO the older List Objects V1. Fix the wording to 'fall back to the older List Objects V1' to match the code and the following sentence about legacy services not supporting V2. --- core/services/s3/src/backend.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/services/s3/src/backend.rs b/core/services/s3/src/backend.rs index fe939b974930..624351c6cd6f 100644 --- a/core/services/s3/src/backend.rs +++ b/core/services/s3/src/backend.rs @@ -404,7 +404,7 @@ impl S3Builder { self } - /// Disable list objects v2 so that opendal will not use the older + /// Disable list objects v2 so that opendal will fall back to the older /// List Objects V1 to list objects. /// /// By default, OpenDAL uses List Objects V2 to list objects. However,