fix: block timestamp precision narrowing unwrap#22837
Open
discord9 wants to merge 2 commits into
Open
Conversation
Signed-off-by: discord9 <discord9@163.com>
Signed-off-by: discord9 <discord9@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of GreptimeTeam/greptimedb#8214.
Follow-up / smaller alternative to #21908.
Rationale for this change
unwrap_castcan currently rewrite predicates like:into an equality against the original nanosecond column. That is not equivalent: the original predicate matches every nanosecond timestamp within the same millisecond, while the rewritten predicate only matches the exact millisecond boundary.
What changes are included in this PR?
This is intentionally a small blocklist-only fix:
is_timestamp_precision_narrowing_casthelperAre these changes tested?
Added targeted logical, physical, and helper tests.
Ran:
Are there any user-facing changes?
Plans will keep timestamp precision-narrowing casts in comparison predicates instead of unwrapping them incorrectly.