* upgrade rubocop + upgrade for graphql ruby + ci upgrades

Author: palkan

.github/workflows/lint.yml

@@ -24,10 +24,10 @@ jobs:
     env:
       BUNDLE_GEMFILE: "gemfiles/rubocop.gemfile"
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
     - uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 3.1
+        ruby-version: 3.4
         bundler-cache: true
     - name: Lint Ruby code with RuboCop
       run: |

.github/workflows/release.yml

@@ -13,7 +13,7 @@ jobs:
       id-token: write
       packages: write
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
         with:
           fetch-depth: 0 # Fetch current tag as annotated. See https://github.com/actions/checkout/issues/290
       - uses: ruby/setup-ruby@v1

.github/workflows/test.yml

@@ -18,6 +18,10 @@ jobs:
       fail-fast: false
       matrix:
         include:
+          - ruby: "4.0"
+            graphql: '~> 2.3'
+            anycable: '~> 1.6'
+            redis_version: latest
           - ruby: "3.3"
             graphql: '~> 2.3'
             anycable: '~> 1.5'
@@ -52,7 +56,7 @@ jobs:
         ports:
           - 6379:6379
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}

.rubocop.yml

@@ -2,8 +2,7 @@ inherit_mode:
   merge:
     - Exclude
 
-require:
-  - standard
+plugins:
   - standard-custom
   - standard-performance
   - rubocop-performance

.rubocop/rspec.yml

@@ -1,4 +1,4 @@
-require:
+plugins:
   - rubocop-rspec
 
 # Disable all cops by default,

gemfiles/rubocop.gemfile

@@ -1,5 +1,4 @@
-source "https://rubygems.org" do
-  gem "standard", "~> 1.28"
+source "https://rubygems.org"
 
-  gem "rubocop-rspec"
-end
+gem "standard"
+gem "rubocop-rspec"

graphql-anycable.gemspec

@@ -34,7 +34,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency "redis", ">= 4.2.0"
 
   spec.add_development_dependency "anycable-rails"
-  spec.add_development_dependency "bundler", "~> 2.0"
+  spec.add_development_dependency "bundler", ">= 2.0"
   spec.add_development_dependency "rack"
   spec.add_development_dependency "railties"
   spec.add_development_dependency "rake", ">= 12.3.3"

lib/graphql/subscriptions/anycable_subscriptions.rb

@@ -4,8 +4,6 @@
 require "graphql/subscriptions"
 require "graphql/anycable/errors"
 
-# rubocop: disable Metrics/AbcSize, Metrics/LineLength, Metrics/MethodLength
-
 # A subscriptions implementation that sends data as AnyCable broadcastings.
 #
 # Since AnyCable is aimed to be compatible with ActionCable, this adapter
@@ -249,4 +247,3 @@ def redis_key(prefix)
     end
   end
 end
-# rubocop: enable Metrics/AbcSize, Metrics/LineLength, Metrics/MethodLength

spec/graphql/anycable_spec.rb

@@ -55,37 +55,42 @@
     expect(AnyCable).to have_received(:broadcast).with("graphql-subscriptions:#{fingerprint}", expected_result)
   end
 
-  context "with multiple subscriptions in one query" do
+  context "triggering update event" do
     let(:query) do
       <<~GRAPHQL
         subscription SomeSubscription {
-          productCreated { id title }
           productUpdated { id }
         }
       GRAPHQL
     end
 
-    context "triggering update event" do
-      it "broadcasts message only for update event" do
-        subject
-        AnycableSchema.subscriptions.trigger(:product_updated, {}, {id: 1, title: "foo"})
-        expect(AnyCable).to have_received(:broadcast).with("graphql-subscriptions:#{fingerprint}", expected_result)
-      end
+    it "broadcasts message only for update event" do
+      subject
+      AnycableSchema.subscriptions.trigger(:product_updated, {}, {id: 1, title: "foo"})
+      expect(AnyCable).to have_received(:broadcast).with("graphql-subscriptions:#{fingerprint}", expected_result)
     end
+  end
 
-    context "triggering create event" do
-      let(:expected_result) do
-        <<~JSON.strip
-          {"result":{"data":{"productCreated":{"id":"1","title":"Gravizapa"}}},"more":true}
-        JSON
-      end
+  context "triggering create event" do
+    let(:query) do
+      <<~GRAPHQL
+        subscription SomeSubscription {
+          productCreated { id title }
+        }
+      GRAPHQL
+    end
 
-      it "broadcasts message only for create event" do
-        subject
-        AnycableSchema.subscriptions.trigger(:product_created, {}, {id: 1, title: "Gravizapa"})
+    let(:expected_result) do
+      <<~JSON.strip
+        {"result":{"data":{"productCreated":{"id":"1","title":"Gravizapa"}}},"more":true}
+      JSON
+    end
 
-        expect(AnyCable).to have_received(:broadcast).with("graphql-subscriptions:#{fingerprint}", expected_result)
-      end
+    it "broadcasts message only for create event" do
+      subject
+      AnycableSchema.subscriptions.trigger(:product_created, {}, {id: 1, title: "Gravizapa"})
+
+      expect(AnyCable).to have_received(:broadcast).with("graphql-subscriptions:#{fingerprint}", expected_result)
     end
   end
 

spec/graphql/stats_spec.rb

@@ -5,12 +5,19 @@
     let(:query) do
       <<~GRAPHQL
         subscription SomeSubscription {
-          productCreated { id title }
           productUpdated { id }
         }
       GRAPHQL
     end
 
+    let(:query2) do
+      <<~GRAPHQL
+        subscription SomeSubscription {
+          productCreated { id title }
+        }
+      GRAPHQL
+    end
+
     let(:channel) do
       socket = double("Socket", istate: AnyCable::Socket::State.new({}))
       connection = double("Connection", anycable_socket: socket)
@@ -22,12 +29,21 @@
     end
 
     before do
-      AnycableSchema.execute(
+      res = AnycableSchema.execute(
         query: query,
         context: {channel: channel, subscription_id: subscription_id},
         variables: {},
         operation_name: "SomeSubscription"
       )
+      expect(res.to_h.fetch("errors", [])).to be_empty
+
+      res2 = AnycableSchema.execute(
+        query: query2,
+        context: {channel: channel, subscription_id: subscription_id},
+        variables: {},
+        operation_name: "SomeSubscription"
+      )
+      expect(res2.to_h.fetch("errors", [])).to be_empty
     end
 
     context "when include_subscriptions is false" do