Skip to content

fix(nginx): mount bundle_cacert volumes in nginx sidecar containers#347

Open
amasolov wants to merge 1 commit into
ansible:mainfrom
amasolov:fix/nginx-bundle-cacert-volume-mount
Open

fix(nginx): mount bundle_cacert volumes in nginx sidecar containers#347
amasolov wants to merge 1 commit into
ansible:mainfrom
amasolov:fix/nginx-bundle-cacert-volume-mount

Conversation

@amasolov
Copy link
Copy Markdown

@amasolov amasolov commented May 19, 2026

Summary

  • Follow-up to PR fix(eda-api): mount bundle_cacert volumes in gunicorn container #342: mount ca-trust-extracted and bundle-cacert volumes in the nginx sidecar containers within both the API and event-stream deployments when bundle_cacert_secret is configured
  • Ensures the custom CA trust store is consistently available across all containers in the pod, matching daphne, gunicorn, and the worker containers

Test plan

  • Deploy EDA with bundle_cacert_secret set and verify the nginx container has the CA trust mounts
  • Verify existing CI tests pass

Made with Cursor

AAP-75755

Summary by CodeRabbit

  • New Features
    • Enhanced deployment configurations with support for custom CA certificate management and secure connections. When enabled, custom certificate authority bundles are automatically mounted and trusted within API and event stream service containers, facilitating secure HTTPS connections to external services, internal endpoints, and third-party integrations that use private, custom, or self-signed SSL/TLS certificates.

PR ansible#342 added the ca-trust-extracted and bundle-cacert volume mounts to
the eda-api (gunicorn) container but the nginx sidecar in both the API
and event-stream deployments was still missing these mounts.

Add the same conditional volume mounts to the nginx containers in
eda-api.deployment.yaml.j2 and eda-event-stream.deployment.yaml.j2 so
that the custom CA trust store is available consistently across every
container in the pod when bundle_cacert_secret is configured.

Signed-off-by: Alexey Masolov <amasolov@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

📝 Walkthrough

Walkthrough

This pull request adds conditional CA trust bundle volume mounts to the nginx containers in both the eda-api and eda-event-stream Kubernetes Deployment templates. When the bundle_ca_crt variable is set, both templates now mount the extracted CA trust directory and the bundle certificate secret file into the appropriate container paths.

Changes

CA Trust Bundle Volume Mounts

Layer / File(s) Summary
Conditional CA trust bundle mounts in nginx containers
roles/eda/templates/eda-api.deployment.yaml.j2, roles/eda/templates/eda-event-stream.deployment.yaml.j2
Both deployment templates add a conditional {% if bundle_ca_crt %} block to mount the extracted CA trust directory (/etc/pki/ca-trust/extracted) from the ca-trust-extracted volume and mount the bundle-ca.crt file (read-only) from the bundle certificate secret into the nginx container's CA anchors path when enabled.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding conditional mounts of bundle_cacert volumes to nginx sidecar containers in both deployment templates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@amasolov
Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant