artifact_hub_has_content_data (set in roles/artifact/tasks/consume.yml, consumed in roles/automationhub/tasks/import_hub_content.yml and, as of #102, also in _artifact_need_temp_resources and the "Delete hub file-storage PVC" guard) is a purely internal, computed fact - it has no entry in any defaults/main.yml and isn't a documented/settable role variable.
Every other internal computed fact in this codebase uses a leading underscore (_artifact_import_components, _artifact_need_temp_resources, _artifact_do_postgresql_import, _preflight_artifact_has_dumps, etc.). This one is the odd one out, which makes it easy to mistake for a public/settable variable.
Suggest renaming to _artifact_hub_has_content_data across all reference sites for consistency. Low risk, no behavior change - purely a naming cleanup.
Surfaced during review of #102.
artifact_hub_has_content_data(set inroles/artifact/tasks/consume.yml, consumed inroles/automationhub/tasks/import_hub_content.ymland, as of #102, also in_artifact_need_temp_resourcesand the "Delete hub file-storage PVC" guard) is a purely internal, computed fact - it has no entry in anydefaults/main.ymland isn't a documented/settable role variable.Every other internal computed fact in this codebase uses a leading underscore (
_artifact_import_components,_artifact_need_temp_resources,_artifact_do_postgresql_import,_preflight_artifact_has_dumps, etc.). This one is the odd one out, which makes it easy to mistake for a public/settable variable.Suggest renaming to
_artifact_hub_has_content_dataacross all reference sites for consistency. Low risk, no behavior change - purely a naming cleanup.Surfaced during review of #102.