From b0393b6087d8604972620b4ed637d5e4c9c421b5 Mon Sep 17 00:00:00 2001
From: dmitriy-kiriyenko <dmitriy.kiriyenko@gmail.com>
Date: Wed, 8 Jul 2020 08:20:57 +0300
Subject: [PATCH] Allow override eventProperties

For my particular case I need to pull off the element more properties
than pulled by default (`id`, `className`, `section`). To be more
precise, I want to pull whole `dataset`.

The most straightforward way to do so is overriding `eventProperties`,
which is used in `trackClicks`, `trackSubmits` and `trackChanges`.

However in its current state I can override `trackClick` and others,
but that would be too much of a monkey patch.

I believe making `eventProperties` overridable won't hurt anyone and will
improve the options to customize events data.
---
 src/index.js | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/index.js b/src/index.js
index 0d1d2bb2..8967bf2d 100644
--- a/src/index.js
+++ b/src/index.js
@@ -252,17 +252,6 @@ function cleanObject(obj) {
   return obj;
 }
 
-function eventProperties(e) {
-  let target = e.target;
-  return cleanObject({
-    tag: target.tagName.toLowerCase(),
-    id: presence(target.id),
-    "class": presence(target.className),
-    page: page(),
-    section: getClosestSection(target)
-  });
-}
-
 function getClosestSection(element) {
   for ( ; element && element !== document; element = element.parentNode) {
     if (element.hasAttribute('data-section')) {
@@ -337,6 +326,17 @@ function createVisit() {
   }
 }
 
+ahoy.eventProperties = function(e) {
+  let target = e.target;
+  return cleanObject({
+    tag: target.tagName.toLowerCase(),
+    id: presence(target.id),
+    "class": presence(target.className),
+    page: page(),
+    section: getClosestSection(target)
+  });
+}
+
 ahoy.getVisitId = ahoy.getVisitToken = function () {
   return getCookie("ahoy_visit");
 };
@@ -420,7 +420,7 @@ ahoy.trackView = function (additionalProperties) {
 ahoy.trackClicks = function () {
   onEvent("click", "a, button, input[type=submit]", function (e) {
     let target = e.target;
-    let properties = eventProperties(e);
+    let properties = ahoy.eventProperties(e);
     properties.text = properties.tag == "input" ? target.value : (target.textContent || target.innerText || target.innerHTML).replace(/[\s\r\n]+/g, " ").trim();
     properties.href = target.href;
     ahoy.track("$click", properties);
@@ -429,14 +429,14 @@ ahoy.trackClicks = function () {
 
 ahoy.trackSubmits = function () {
   onEvent("submit", "form", function (e) {
-    let properties = eventProperties(e);
+    let properties = ahoy.eventProperties(e);
     ahoy.track("$submit", properties);
   });
 };
 
 ahoy.trackChanges = function () {
   onEvent("change", "input, textarea, select", function (e) {
-    let properties = eventProperties(e);
+    let properties = ahoy.eventProperties(e);
     ahoy.track("$change", properties);
   });
 };