refactor: remove Doctype check in Python to allow user to add button via client scripts in other doctypes

Author: HenningWendtland

pdf_on_submit/public/js/pdf_button_utils.js

@@ -2,7 +2,9 @@
 
 window.pdf_on_submit = window.pdf_on_submit || {};
 
-// Doctypes that support PDF button
+// Common doctypes with PDF button enabled by default
+// To enable for other doctypes, add a Client Script:
+//   frappe.ui.form.on("Your DocType", { refresh: pdf_on_submit.add_pdf_button });
 pdf_on_submit.ALLOWED_DOCTYPES = [
 	"Quotation",
 	"Sales Order",

pdf_on_submit/utils.py

@@ -3,30 +3,13 @@
 from pdf_on_submit.attach_pdf import get_matching_enabled_doctype
 
 
-ALLOWED_DOCTYPES = [
-	"Quotation",
-	"Sales Order",
-	"Sales Invoice",
-	"Delivery Note",
-	"Dunning",
-	"Request for Quotation",
-	"Supplier Quotation",
-	"Purchase Order",
-	"Purchase Invoice",
-	"Purchase Receipt",
-]
-
-
 @frappe.whitelist()
 def get_print_details(doctype: str, docname: str) -> tuple:
 	"""
 	Get print format and letter head for a document based on PDF on Submit Settings.
 
 	Returns: (print_format, letter_head)
 	"""
-	if doctype not in ALLOWED_DOCTYPES:
-		frappe.throw(_("Print details not available for this document type"))
-
 	if not frappe.has_permission(doctype, "print", docname):
 		frappe.throw(_("No permission to print this document"))