Single responsibility principle example forgets to validate in the "good" version

[upngo]

There is no validation in the good version so $request->validated() will be empty....

Section copied below for context

bad

public function update(Request $request): string
{
    $validated = $request->validate([
        'title' => 'required|max:255',
        'events' => 'required|array:date,type'
    ]);

    foreach ($request->events as $event) {
        $date = $this->carbon->parse($event['date'])->toString();

        $this->logger->log('Update event ' . $date . ' :: ' . $);
    }

    $this->event->updateGeneralEvent($request->validated());

    return back();
}

good

public function update(UpdateRequest $request): string
{
    /* MISSING VALIDATION HERE */
    $this->logService->logEvents($request->events);

    $this->event->updateGeneralEvent($request->validated());

    return back();
}

[carlos-mora]

The validation is not missing, it has been moved to the UpdateRequest that extends FormRequest (UpdateRequest $request) El jue, 29 ene 2026 a las 4:57, tom perwick ***@***.***>) escribió:

…

*upngo* created an issue (alexeymezenin/laravel-best-practices#196) <#196> There is no validation in the good version so $request->validated() will be empty.... Section copied below for context bad public function update(Request $request): string { $validated = $request->validate([ 'title' => 'required|max:255', 'events' => 'required|array:date,type' ]); foreach ($request->events as $event) { $date = $this->carbon->parse($event['date'])->toString(); $this->logger->log('Update event ' . $date . ' :: ' . $); } $this->event->updateGeneralEvent($request->validated()); return back(); } good public function update(UpdateRequest $request): string { /* MISSING VALIDATION HERE */ $this->logService->logEvents($request->events); $this->event->updateGeneralEvent($request->validated()); return back(); } — Reply to this email directly, view it on GitHub <#196>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAW4YF2O5PSTTWG2PLAOXGD4JGAKZAVCNFSM6AAAAACTIH57CCVHI2DSMVQWIX3LMV43ASLTON2WKOZTHA3DQNRWGQ2TSNQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>