Adapt agama config to return error code when no validates (#3304)

## Problem

When running `agama config load`, `agama config generate` or `agama
config validate` it always returns `0` even when the profile is invalid.

- [*bsc#1256951*](https://bugzilla.suse.com/show_bug.cgi?id=1256951)


## Solution

Return Err (`return code 1`) in case of invalid profile.

## Testing

- *Tested manually*

### agama config generate
```bash
suse@vikingo-laptop:~$ ~/agama_not_fix/agama config generate profile.jsonnet || echo $?
{
   "hostname": {
      "static": "Agama"
   },
   "product": {
      "ID": "Tumbleweed"
   },
   "scripts": {
      "post": [
         {
            "chroot": true,
            "content": "#!/usr/bin/env bash\necho 'PermitRootLogin yes' > /etc/ssh/sshd_config.d/root.conf\nsystemctl enable sshd\n",
            "name": "enable root login"
         }
      ]
   }
}
✗ The profile is not valid. Please, check the following errors:

        * Additional properties are not allowed ('ID' was unexpected). /product
        * "id" is a required property. /product

suse@vikingo-laptop:~$ ~/agama_fix/agama config generate profile.jsonnet || echo $?
{
   "hostname": {
      "static": "Agama"
   },
   "product": {
      "ID": "Tumbleweed"
   },
   "scripts": {
      "post": [
         {
            "chroot": true,
            "content": "#!/usr/bin/env bash\necho 'PermitRootLogin yes' > /etc/ssh/sshd_config.d/root.conf\nsystemctl enable sshd\n",
            "name": "enable root login"
         }
      ]
   }
}
✗ The profile is not valid. Please, check the following errors:

        * Additional properties are not allowed ('ID' was unexpected). /product
        * "id" is a required property. /product

The profile is not valid
1
```
### agama config load
```bash
suse@vikingo-laptop:~$ ~/agama_not_fix/agama config load profile.json || echo $?
✗ The profile is not valid. Please, check the following errors:

        * Additional properties are not allowed ('ID' was unexpected). /product
        * "id" is a required property. /product

suse@vikingo-laptop:~$ ~/agama_fix/agama config load profile.json || echo $?
✗ The profile is not valid. Please, check the following errors:

        * Additional properties are not allowed ('ID' was unexpected). /product
        * "id" is a required property. /product

The profile is not valid
1

```
### agama config validate
```bash
suse@vikingo-laptop:~$ ~/agama_not_fix/agama config validate profile.json || echo $?
✗ The profile is not valid. Please, check the following errors:

        * Additional properties are not allowed ('ID' was unexpected). /product
        * "id" is a required property. /product

suse@vikingo-laptop:~$ ~/agama_fix/agama config validate profile.json || echo $?
✗ The profile is not valid. Please, check the following errors:

        * Additional properties are not allowed ('ID' was unexpected). /product
        * "id" is a required property. /product

The profile is not valid
1

```

Author: teclator

rust/agama-cli/src/config.rs

@@ -129,7 +129,7 @@ pub async fn run(subcommand: ConfigCommands, opts: GlobalOpts) -> anyhow::Result
             let valid = validate(&http_client, CliInput::Full(contents.clone()), false).await?;
 
             if !matches!(valid, ValidationOutcome::Valid) {
-                return Ok(());
+                return Err(anyhow!("The profile is not valid"));
             }
 
             let model: api::Config = serde_json::from_str(&contents)?;
@@ -138,12 +138,16 @@ pub async fn run(subcommand: ConfigCommands, opts: GlobalOpts) -> anyhow::Result
             monitor_progress(monitor).await?;
         }
         ConfigCommands::Validate { url_or_path, local } => {
-            let _ = if !local {
+            let validity = if !local {
                 let http_client = build_http_client(api_url, opts.insecure, true).await?;
-                validate(&http_client, url_or_path, false).await
+                validate(&http_client, url_or_path, false).await?
             } else {
-                validate_local(url_or_path, opts.insecure)
+                validate_local(url_or_path, opts.insecure)?
             };
+
+            if !matches!(validity, ValidationOutcome::Valid) {
+                return Err(anyhow!("The profile is not valid"));
+            }
         }
         ConfigCommands::Generate { url_or_path } => {
             let http_client = build_http_client(api_url, opts.insecure, true).await?;
@@ -293,7 +297,7 @@ async fn generate(
         println!("{}", &profile_json);
         let _ = validation_msg(&validity);
 
-        return Ok(());
+        return Err(anyhow!("The profile is not valid"));
     }
 
     let config = api::Config::from_json(&profile_json, &context.source)?;
@@ -303,10 +307,9 @@ async fn generate(
     let validity = validate(client, CliInput::Full(config_json.clone()), false).await?;
 
     if matches!(validity, ValidationOutcome::NotValid(_)) {
-        eprintln!(
-            "{} Internal error: the profile was made invalid by InstallSettings round trip",
-            style("\u{2717}").bold().red()
-        );
+        return Err(anyhow!(
+            "Internal error: the profile became invalid during Config round trip"
+        ));
     }
 
     Ok(())
@@ -364,10 +367,14 @@ async fn edit(
     let status = command.status().context(format!("Running {:?}", command))?;
     // TODO: do nothing if the content of the file is unchanged
     if status.success() {
-        // FIXME: invalid profile still gets loaded
         let updated =
             std::fs::read_to_string(&path).context(format!("Reading from file {:?}", path))?;
-        validate(http_client, CliInput::Full(updated.clone()), false).await?;
+        let validity = validate(http_client, CliInput::Full(updated.clone()), false).await?;
+
+        if !matches!(validity, ValidationOutcome::Valid) {
+            return Err(anyhow!("The profile is not valid"));
+        }
+
         return Ok(serde_json::from_str(&updated)?);
     }
 

rust/package/agama.changes

@@ -1,3 +1,10 @@
+-------------------------------------------------------------------
+Fri Mar 20 08:46:19 UTC 2026 - Knut Anderssen <kanderssen@suse.com>
+
+- Return error code when using "agama config generate",
+  "agama config load" or "agama config validate" does not validate
+  the given profile (bsc#1256951, gh#agama-project/agama#3304).
+
 -------------------------------------------------------------------
 Fri Mar 20 07:54:46 UTC 2026 - Knut Anderssen <kanderssen@suse.com>