Add predicate_eval to standard benchmark allowlist#12
Merged
Conversation
predicate_eval is a bench.sh standard benchmark (`bench.sh run predicate_eval`): conjunctive (AND) filter-evaluation micro-benchmarks backed by the sql_benchmarks/predicate_eval query set, with subgroups that exercise adaptive predicate ordering. It was missing from the standard allowlist, so `run benchmark predicate_eval` fell through to the wildcard criterion path and ran `cargo bench --bench predicate_eval`, which has no such target and failed. Adding it to the standard list routes it to the bench.sh runner. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
predicate_evalis a bench.sh standard benchmark (bench.sh run predicate_eval): conjunctive (AND) filter-evaluation micro-benchmarks backed by thesql_benchmarks/predicate_evalquery set, with subgroups that exercise adaptive predicate ordering.It was missing from the standard allowlist, so
run benchmark predicate_evalfell through to the wildcard criterion path and rancargo bench --bench predicate_eval, which has no such target and failed. Adding it to the standard list routes it to the bench.sh runner.Requested in apache/datafusion#22698 (comment).
🤖 Generated with Claude Code