Skip to content

Commit d6ba276

Browse files
committed
chore: update close button migration guide
1 parent 531d968 commit d6ba276

1 file changed

Lines changed: 12 additions & 8 deletions

File tree

CONTRIBUTOR-DOCS/03_project-planning/03_components/close-button/migration-plan.md

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363

6464
### Most blocking open questions
6565

66-
- [Q2](#architecture-and-behavior): Confirm whether `icon-size` should be a public API in SWC or kept internal.
66+
- [Q1](#architecture-and-behavior): Confirm whether `icon-size` should be a public API in SWC or kept internal.
6767

6868
---
6969

@@ -149,7 +149,7 @@ Prerequisite dependency:
149149
| --- | --- | --- | --- | --- |
150150
| B1 | Tag rename | `<sp-close-button>` | `<swc-close-button>` | Rename markup and import path. |
151151
| B2 | Accessible name channel rename | `label` | `accessible-label` | Rename attribute/property and keep semantics identical. |
152-
| B3 | Static color API cleanup | `variant="white|black"` and `static-color` both allowed | `static-color` is canonical; `variant` deprecated/removed | Replace `variant` with `static-color`. |
152+
| B3 | Static color API cleanup and deprecation | `variant="white|black"` and `static-color` both allowed | `static-color` is canonical; `variant` is deprecated in this migration and scheduled for removal after deprecation window | Replace `variant` with `static-color`; treat `variant` usage as migration debt. |
153153

154154
#### Styling and visuals
155155

@@ -184,6 +184,7 @@ Prerequisite dependency:
184184
| `staticColor` | `'white' \| 'black' \| undefined` | `undefined` | `static-color` | Confirmed |
185185
| `accessibleLabel` | `string \| undefined` | `undefined` | `accessible-label` | Confirmed |
186186
| `disabled` | `boolean` | `false` | `disabled` | Confirmed |
187+
| `variant` (deprecated alias) | `'white' \| 'black' \| ''` | `''` | `variant` | Deprecated in 2nd-gen close-button migration; map to `static-color` with deprecation warning during transition, then remove. |
187188

188189
### Behavioral semantics
189190

@@ -253,18 +254,21 @@ Prerequisite dependency:
253254

254255
### Design
255256

256-
- **Resolved:** Visual sign-off sources are confirmed:
257-
- [S2 Web Desktop scale (Figma)](https://www.figma.com/design/Mngz9H7WZLbrCvGQf3GnsY/S2---Web--Desktop-scale-?node-id=125265-577&t=99qlf018hYjRXRft-4)
258-
- [S2 close-button anatomy](https://s2.spectrum.corp.adobe.com/page/close-button/#anatomy)
259-
- `spectrum-css` `spectrum-two` `components/closebutton/index.css`
257+
| # | Item | Blocking? | Status | Owner |
258+
| --- | --- | --- | --- | --- |
259+
| Q0 | Visual sign-off sources are confirmed: [S2 Web Desktop scale (Figma)](https://www.figma.com/design/Mngz9H7WZLbrCvGQf3GnsY/S2---Web--Desktop-scale-?node-id=125265-577&t=99qlf018hYjRXRft-4), [S2 close-button anatomy](https://s2.spectrum.corp.adobe.com/page/close-button/#anatomy), and `spectrum-css` `spectrum-two` `components/closebutton/index.css` | No | Resolved | Design + implementation |
260260

261261
### Architecture and behavior
262262

263-
- **Q2:** Should `icon-size` be exposed in public API, or remain internal visual implementation detail?
263+
| # | Item | Blocking? | Status | Owner |
264+
| --- | --- | --- | --- | --- |
265+
| Q1 | Should `icon-size` be exposed in public API, or remain internal visual implementation detail? | Yes | Open | Design + implementation |
264266

265267
### Scope and prerequisites
266268

267-
- No additional blockers currently.
269+
| # | Item | Blocking? | Status | Owner |
270+
| --- | --- | --- | --- | --- |
271+
| Q2 | No additional scope or prerequisite blockers identified at this time. | No | Resolved | Ticket owner |
268272

269273
---
270274

0 commit comments

Comments
 (0)