Tiff read error when reading EXR file

[tjdcs]

Hi all,

I'm hoping to get some help when running a simple example. Something is probably missing in my environment config, but I'm at a loss of finding it.

I'm getting a tiff read error when reading exr

 ctlrender -ctl /var/folders/ss/58q74x5j7fs8zmz2x9f8ybz00000gn/T/tmpgui4jhl1.ctl -param1 exposure 3.0 /Users/tucker/Dev/colour/colour/examples/io/../../io/tests/resources/CMS_Test_Pattern.exr /var/folders/ss/58q74x5j7fs8zmz2x9f8ybz00000gn/T/tmpb1kr7hc0.exr -verbose -force
global ctl parameters:

       source file: /Users/tucker/Dev/colour/colour/examples/io/../../io/tests/resources/CMS_Test_Pattern.exr
  destination file: /var/folders/ss/58q74x5j7fs8zmz2x9f8ybz00000gn/T/tmpb1kr7hc0.exr
destination format: exr
       input scale: default
      output scale: default

Unable to read tiff file: Not a TIFF or MDI file, bad magic number 12150 (0x2f76)unable to read file /Users/tucker/Dev/colour/colour/examples/io/../../io/tests/resources/CMS_Test_Pattern.exr (unknown format).```

[michaeldsmith]

can you try testing with the more direct path to that input file and let me know if it gives the same error?

/Users/tucker/Dev/colour/colour/io/tests/resources/CMS_Test_Pattern.exr

I believe ctl_render tries to read the input file looking for the magic numbers that would idenity it has DPX, TIF and EXR, instead of just relying on the file extension

[tjdcs]

Same result.

CMS_Test_Pattern.exr.zip

[michaeldsmith]

are you sure you are using the most recent code available in the master branch?

I didn't get the error you are seeing when using the CMS_Test_Pattern.exr file you attached when using the ctl in /unittests/ctlrender/unity.ctl

Here are the steps I used to test after cloning the repo:

docker build --rm -f Dockerfile -t ctl:latest .
docker run -it --rm -v C:\\temp:/tmp/ ctl:latest
ctlrender -ctl ./unittest/ctlrender/unity.ctl /tmp/CMS_Test_Pattern.exr /tmp/out.exr

out.exr looks identical to the input file CMS_Test_Pattern.exr

[tjdcs]

I strictly followed installation instructions using brew on macOS. I can try a build from scratch now

[tjdcs]

Build from scratch worked great.

[michaeldsmith]

I think some of the instructions are out-of-date, the CTL repo had not been updated since 2014 so I volunteered to maintain it in May 2022. Since then, we've fixed a lot of bugs and extended support to many more platforms and OpenEXR3, so I think we should do a release soon. The brew CTL distribution may need a new release version number to trigger their repo to use the latest code, I'm not sure.

[tjdcs]

Sounds good. I'm trying to also become a better contributor to colour-science and need ctl-render to run some of our examples. Not something I'm particularly familiar with.

Anyway. This seems to be fixed. I'm having an issue with

exception thrown (oops...): CTL parameter 'aIn' not specified on the command line and does not have a default value.

now, but I assume that's some of your changes / bug fixes and we need to update on our side.

Tagging @KelSolaar for vis.

[michaeldsmith]

OK good to hear. My guess is that you are getting that aIn error because the CTL file you are using expects RGBA input but your input file is only RGB. To overcome this without changing the CTL file to only input RGB, you can provide this additional argument when running ctlrender
-global_param1 aIn 1.0
which will set the input A value to 1.0

Let me know if that fixes the exception.

[tjdcs]

Thanks. Perfect workaround for now.

Next up to debug is our fileIO. Did the output parameters / usage change at all?

[michaeldsmith]

i don't believe the output parameters or usage has changed. Are you getting other errors now?

[michaeldsmith]

Another work around is to write your CTL code to handle both RGB and RGBA input files and set a default value for aIn within the CTL code, like this:

void main
    (output varying half rOut,
     output varying half gOut,
     output varying half bOut,
     output varying half aOut,
     input varying half rIn,
     input varying half gIn,
     input varying half bIn,
     input varying half aIn = 1.0)
{  
  rOut=rIn;
  gOut=gIn;
  bOut=bIn;
  aOut=aIn;
}

[tjdcs]

Thanks for your help @michaeldsmith. Probably best that we re-write out CTL template to have defaults there.

I am solved on my other issues, but we would like to have a release soon if you think you've stabilized CTL. That way we can test against a release version.

Cheers,

[scottdyer]

ctlrender stopped working for me and started showing me the same error about Unable to read tiff file: Not a TIFF or MDI file, bad magic number 12150 (0x2f76)unable to read file...*.exr (unknown format).

I have tried reinstalling from source using cmake and get an error on the make when linking ctlrender. Any ideas on how to fix?

(Up to here, all builds fine, except for a few warnings of deprecated syntax)

... 
[ 68%] Building CXX object ctlrender/CMakeFiles/ctlrender.dir/format.cc.o
[ 69%] Building CXX object ctlrender/CMakeFiles/ctlrender.dir/compression.cc.o
[ 70%] Linking CXX executable ctlrender
ld: Undefined symbols:
  half::_eLut, referenced from:
      half::half(float) in exr_file.cc.o
  half::convert(int), referenced from:
      half::half(float) in exr_file.cc.o
  half::_toFloat, referenced from:
      half::operator float() const in libIlmCtlSimd.a[14](CtlSimdStdLibLookupTable.cpp.o)
  Imf_3_2::Header::Header(int, int, float, Imath_2_5::Vec2<float> const&, float, Imf_3_2::LineOrder, Imf_3_2::Compression), referenced from:
      exr_write(char const*, float, ctl::dpx::fb<float> const&, format_t*, Compression*) in exr_file.cc.o
  Imath_2_5::SingMatrixExc::SingMatrixExc(char const*), referenced from:
      Imath_2_5::Matrix33<float>::inverse(bool) const in libIlmCtlSimd.a[15](CtlSimdStdLibMath.cpp.o)
      Imath_2_5::Matrix33<float>::inverse(bool) const in libIlmCtlSimd.a[15](CtlSimdStdLibMath.cpp.o)
      Imath_2_5::Matrix44<float>::inverse(bool) const in libIlmCtlSimd.a[15](CtlSimdStdLibMath.cpp.o)
      Imath_2_5::Matrix44<float>::gjInverse(bool) const in libIlmCtlSimd.a[15](CtlSimdStdLibMath.cpp.o)
      Imath_2_5::Matrix44<float>::gjInverse(bool) const in libIlmCtlSimd.a[15](CtlSimdStdLibMath.cpp.o)
  Imath_2_5::SingMatrixExc::~SingMatrixExc(), referenced from:
      Imath_2_5::Matrix33<float>::inverse(bool) const in libIlmCtlSimd.a[15](CtlSimdStdLibMath.cpp.o)
      Imath_2_5::Matrix33<float>::inverse(bool) const in libIlmCtlSimd.a[15](CtlSimdStdLibMath.cpp.o)
      Imath_2_5::Matrix44<float>::inverse(bool) const in libIlmCtlSimd.a[15](CtlSimdStdLibMath.cpp.o)
      Imath_2_5::Matrix44<float>::gjInverse(bool) const in libIlmCtlSimd.a[15](CtlSimdStdLibMath.cpp.o)
      Imath_2_5::Matrix44<float>::gjInverse(bool) const in libIlmCtlSimd.a[15](CtlSimdStdLibMath.cpp.o)
  typeinfo for Imath_2_5::SingMatrixExc, referenced from:
      Imath_2_5::Matrix33<float>::inverse(bool) const in libIlmCtlSimd.a[15](CtlSimdStdLibMath.cpp.o)
      Imath_2_5::Matrix33<float>::inverse(bool) const in libIlmCtlSimd.a[15](CtlSimdStdLibMath.cpp.o)
      Imath_2_5::Matrix44<float>::inverse(bool) const in libIlmCtlSimd.a[15](CtlSimdStdLibMath.cpp.o)
      Imath_2_5::Matrix44<float>::gjInverse(bool) const in libIlmCtlSimd.a[15](CtlSimdStdLibMath.cpp.o)
      Imath_2_5::Matrix44<float>::gjInverse(bool) const in libIlmCtlSimd.a[15](CtlSimdStdLibMath.cpp.o)
  operator<<(std::__1::basic_ostream<char, std::__1::char_traits<char>>&, half), referenced from:
      void Ctl::(anonymous namespace)::printFunc<half>(Ctl::SimdBoolMask const&, Ctl::SimdXContext&) in libIlmCtlSimd.a[16](CtlSimdStdLibPrint.cpp.o)
      void Ctl::(anonymous namespace)::printFunc<half>(Ctl::SimdBoolMask const&, Ctl::SimdXContext&) in libIlmCtlSimd.a[16](CtlSimdStdLibPrint.cpp.o)
      Ctl::SimdPushLiteralInst<half>::print(int) const in libIlmCtlSimd.a[19](CtlSimdSyntaxTree.cpp.o)
      Ctl::HalfLiteralNode::print(int) const in libIlmCtl.a[15](CtlSyntaxTree.cpp.o)
      Ctl::HalfLiteralNode::printLiteral() const in libIlmCtl.a[15](CtlSyntaxTree.cpp.o)
      Ctl::HalfType::evaluate(Ctl::LContext&, Ctl::RcPtr<Ctl::ExprNode> const&) const in libIlmCtl.a[17](CtlType.cpp.o)
      Ctl::HalfType::evaluate(Ctl::LContext&, Ctl::RcPtr<Ctl::ExprNode> const&) const in libIlmCtl.a[17](CtlType.cpp.o)
      ...
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [ctlrender/ctlrender] Error 1
make[1]: *** [ctlrender/CMakeFiles/ctlrender.dir/all] Error 2
make: *** [all] Error 2

[michaeldsmith]

@scottdyer it looks like your build may be trying to use version 3.2 of OpenEXR (Imf_3_2) while trying to use version 2.5 of IMath (Imath_2_5).

version 2.5 of Imath was part of ilmbase for years, but Imath was spun out of ilmbase when OpenEXR went to version 3, there is now a separate Imath 3 library [1] dependency in OpenEXR 3

My guess is that you may have both Imath 3 and Imath 2.5 (part of ilmbase) installed on your system somehow and CTL is trying to use Imath 2.5 with OpenEXR 3.2

Can you try uninstalling ilmbase on your system and re-running cmake?

If you still have issues, can you provide the cmake output text? It should look something like this:

cmake ..
-- The C compiler identification is GNU 11.4.0
-- The CXX compiler identification is GNU 11.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- CMAKE_BUILD_TYPE : ""
-- To use AddressSanitizer, use "cmake .. -DCMAKE_BUILD_TYPE=asan"
-- Found OpenEXR 3.2.1
-- Found TIFF: /usr/lib/x86_64-linux-gnu/libtiff.so (found version "4.3.0")  
-- found TIFF, TIFF_LIBRARIES : /usr/lib/x86_64-linux-gnu/libtiff.so
CMake Warning at ctlrender/CMakeLists.txt:53 (find_package):
  By not providing "FindAcesContainer.cmake" in CMAKE_MODULE_PATH this
  project has asked CMake to find a package configuration file provided by
  "AcesContainer", but CMake did not find one.

  Could not find a package configuration file provided by "AcesContainer"
  with any of the following names:

    AcesContainerConfig.cmake
    acescontainer-config.cmake

  Add the installation prefix of "AcesContainer" to CMAKE_PREFIX_PATH or set
  "AcesContainer_DIR" to a directory containing one of the above files.  If
  "AcesContainer" provides a separate development package or SDK, be sure it
  has been installed.


ctlrender test executable: /usr/src/CTL/build/ctlrender/ctlrender
-- LibTIFF found, OpenEXR found, including TIF and EXR files in ctlrender unit tests
ctlrender test output folder will be created at: /usr/src/CTL/build/unittest/ctlrender/output
exrdpx build director: /usr/src/CTL/build/OpenEXR_CTL/exrdpx
exrdpx test executable: /usr/src/CTL/build/OpenEXR_CTL/exrdpx/exrdpx
exrdpx test output folder will be created at: /usr/src/CTL/build/unittest/exrdpx/output
-- Configuring done
-- Generating done
-- Build files have been written to: /usr/src/CTL/build

[1] https://github.com/AcademySoftwareFoundation/Imath