Update CHANGELOG for version 2.0.4; refactor pathfinding functions and fix issues with capacity and event emissions

Author: Zehir

CHANGELOG.md

@@ -75,3 +75,14 @@
 ### Fixed
 
 - Fix debug container redraw
+
+## 2.0.4
+
+### Updated
+
+- \_pathfinding_generate_points() function is now called pathfinding_generate_points()
+
+### Fixed
+
+- Fix issue with pathfinding points capacity #1
+- astar_changed event was called twice.

addons/hexagon_tilemaplayer/CHANGELOG.md

@@ -75,3 +75,14 @@
 ### Fixed
 
 - Fix debug container redraw
+
+## 2.0.4
+
+### Updated
+
+- \_pathfinding_generate_points() function is now called pathfinding_generate_points()
+
+### Fixed
+
+- Fix issue with pathfinding points capacity #1
+- astar_changed event was called twice.

addons/hexagon_tilemaplayer/hexagon_tilemaplayer.gd

@@ -101,8 +101,7 @@ func _ready() -> void:
 
 	if pathfinding_enabled:
 		astar_changed.connect(_draw_debug, Object.CONNECT_DEFERRED)
-		_pathfinding_generate_points()
-		astar_changed.emit()
+		pathfinding_generate_points()
 	else:
 		_draw_debug.call_deferred()
 
@@ -176,10 +175,20 @@ func pathfinding_recalculate_tile_weight(coord: Vector2i):
 	)
 
 
+## @deprecated: Use [method pathfinding_generate_points] instead.
 func _pathfinding_generate_points():
+	pathfinding_generate_points()
+
+
+## Generate points and connections for the [Astar2D] instance.
+##
+## [br]This is automatically called in the _ready() function.
+## [br]The points capacity is automatically adjusted based on the number of used cells.
+## [br]If later you need to add more points to the astar instance call [method AStar2D.reserve_space] with num_nodes the total of points multiplied by 1.12.
+## [br]See [url=https://github.com/godotengine/godot/issues/102612#issuecomment-2702275926]this issue[/url] for more information.
+func pathfinding_generate_points():
 	if not astar:
 		astar = AStar2D.new()
-	astar.clear()
 	_pathfinding_create_points()
 	_pathfinding_create_connections()
 	astar_changed.emit()
@@ -220,11 +229,16 @@ func _draw_debug():
 
 
 func _pathfinding_create_points():
+	astar.clear()
 	var cells := get_used_cells()
-	astar.reserve_space(1 << int(log(cells.size()) / log(2)))
+	# Why 1.12 ? See https://github.com/godotengine/godot/issues/102612#issuecomment-2702275926
+	var needed_space = cells.size() * 1.12
+	if astar.get_point_capacity() < needed_space:
+		astar.reserve_space(needed_space)
 
+	var id: int = -1
 	for coord in cells:
-		var id = astar.get_available_point_id()
+		id += 1
 		var weight = _pathfinding_get_tile_weight(coord)
 		var pos = map_to_local(coord)
 		astar.add_point(id, pos, weight)

project.godot

@@ -16,7 +16,7 @@ config/features=PackedStringArray("4.4", "Mobile")
 
 [editor_plugins]
 
-enabled=PackedStringArray("res://addons/hexagon_tilemaplayer/plugin.cfg", "res://addons/script-ide/plugin.cfg")
+enabled=PackedStringArray("res://addons/hexagon_tilemaplayer/plugin.cfg")
 
 [input]