Merge pull request #121 from Yoast/stories/inverted-listeners-regression

Fix inverted listeners

Author: moorscode

js/src/app.js

@@ -58,15 +58,15 @@ App.prototype.acf5Listener = function() {
 
 App.prototype.bindListeners = function() {
 	if ( helper.acf_version >= 5 ) {
-		jQuery( this.acf4Listener.bind( this ) );
+		jQuery( this.acf5Listener.bind( this ) );
 	} else {
 		var fieldSelectors = config.fieldSelectors.slice( 0 );
 		var wysiwygSelector = "textarea[id^=wysiwyg-acf]";
 
 		// Ignore Wysiwyg fields because they trigger a refresh in Yoast SEO itself
 		var fieldSelectorsWithoutWysiwyg = _.without( fieldSelectors, wysiwygSelector );
 
-		jQuery( document ).on( "acf/setup_fields", this.acf5Listener.bind( this, fieldSelectors, wysiwygSelector, fieldSelectorsWithoutWysiwyg ) );
+		jQuery( document ).on( "acf/setup_fields", this.acf4Listener.bind( this, fieldSelectors, wysiwygSelector, fieldSelectorsWithoutWysiwyg ) );
 	}
 };
 

js/yoast-acf-analysis.js

@@ -59,15 +59,15 @@ App.prototype.acf5Listener = function() {
 
 App.prototype.bindListeners = function() {
 	if( helper.acf_version >= 5 ) {
-		jQuery( this.acf4Listener.bind( this ) );
+		jQuery( this.acf5Listener.bind( this ) );
 	}else{
 		var fieldSelectors = config.fieldSelectors.slice( 0 );
 		var wysiwygSelector = "textarea[id^=wysiwyg-acf]";
 
 		// Ignore Wysiwyg fields because they trigger a refresh in Yoast SEO itself
 		var fieldSelectorsWithoutWysiwyg = _.without( fieldSelectors, wysiwygSelector );
 
-		jQuery( document ).on( "acf/setup_fields", this.acf5Listener.bind( this, fieldSelectors, wysiwygSelector, fieldSelectorsWithoutWysiwyg ) );
+		jQuery( document ).on( "acf/setup_fields", this.acf4Listener.bind( this, fieldSelectors, wysiwygSelector, fieldSelectorsWithoutWysiwyg ) );
 	}
 };