Skip to content

RTC: Do not sync taxonomy term entities #78594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxschmeling wants to merge 1 commit into
base: trunk
Choose a base branch
from
+19 −6
Open

RTC: Do not sync taxonomy term entities #78594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/core-data/src/entities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import { getSyncManager } from './sync';
import {
applyPostChangesToCRDTDoc,
defaultCollectionSyncConfig,
defaultSyncConfig,
getPostChangesFromCRDTDoc,
POST_META_KEY_FOR_CRDT_DOC_PERSISTENCE,
} from './utils/crdt';
Expand Down Expand Up @@ -475,7 +474,7 @@ async function loadTaxonomyEntities() {
} );
return Object.entries( taxonomies ?? {} ).map( ( [ name, taxonomy ] ) => {
const namespace = taxonomy?.rest_namespace ?? 'wp/v2';
const entity = {
return {
kind: 'taxonomy',
baseURL: `/${ namespace }/${ taxonomy.rest_base }`,
baseURLParams: { context: 'edit' },
Expand All @@ -484,10 +483,6 @@ async function loadTaxonomyEntities() {
getTitle: ( record ) => record?.name,
supportsPagination: true,
};

entity.syncConfig = defaultSyncConfig;

return entity;
} );
}

Expand Down
18 changes: 18 additions & 0 deletions packages/core-data/src/test/entities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,4 +333,22 @@ describe( 'loadTaxonomyEntities', () => {

expect( entities[ 0 ].supportsPagination ).toBe( true );
} );

it( 'should not enable entity syncing for taxonomy term records', async () => {
const mockTaxonomies = {
category: {
name: 'Categories',
rest_base: 'categories',
},
};

apiFetch.mockResolvedValueOnce( mockTaxonomies );

const taxonomyLoader = additionalEntityConfigLoaders.find(
( loader ) => loader.kind === 'taxonomy'
);
const entities = await taxonomyLoader.loadEntities();

expect( entities[ 0 ].syncConfig ).toBeUndefined();
} );
} );
Loading